Re: BUG #15446: Crash on ALTER TABLE

2019-01-10 Thread Dean Rasheed
On Wed, 9 Jan 2019 at 23:24, Andrew Dunstan wrote: > Here's another attempt. For the rewrite case it kept the logic of the > previous patch to clear all the missing attributes, but if we're not > rewriting we reconstruct the missing value according to the new type > settings. > Looks good to me.

Re: BUG #15446: Crash on ALTER TABLE

2019-01-09 Thread Andrew Dunstan
On 1/8/19 7:41 PM, Andrew Dunstan wrote: > On 1/8/19 4:48 PM, Dean Rasheed wrote: >> On Tue, 8 Jan 2019 at 19:34, Andrew Dunstan >> wrote: >>> Here's a patch that I think cures the problem. >>> >> Hmm, that doesn't quite work because the table might not actually be >> rewritten as a result of

Re: BUG #15446: Crash on ALTER TABLE

2019-01-08 Thread Andrew Dunstan
On 1/8/19 4:48 PM, Dean Rasheed wrote: > On Tue, 8 Jan 2019 at 19:34, Andrew Dunstan > wrote: >> Here's a patch that I think cures the problem. >> > Hmm, that doesn't quite work because the table might not actually be > rewritten as a result of the type change. For example: > > DROP TABLE IF