On 1/5/24 12:56, Robert Haas wrote:
On Sun, Aug 27, 2023 at 4:25 PM Heikki Linnakangas wrote:
I think you got that it backwards. 'perl_locale_obj' is set to the perl
interpreter's locale, whenever we are *outside* the interpreter.
This thread has had no update for more than 4 months, so I'm
On Sun, Aug 27, 2023 at 4:25 PM Heikki Linnakangas wrote:
> I think you got that it backwards. 'perl_locale_obj' is set to the perl
> interpreter's locale, whenever we are *outside* the interpreter.
This thread has had no update for more than 4 months, so I'm marking
the CF entry RwF for now.
On 27/08/2023 16:41, Joe Conway wrote:
On 8/15/23 10:40, Heikki Linnakangas wrote:
If multiple interpreters are used, is the single perl_locale_obj
variable still enough? Each interpreter can have their own locale I believe.
So in other words plperl and plperlu both used in the same query? I
On 8/15/23 10:40, Heikki Linnakangas wrote:
On 01/08/2023 16:48, Joe Conway wrote:
Any further comments on the posted patch[1]? I would like to apply/push
this prior to the beta and minor releases next week.
I'm not sure about the placement of the uselocale() calls. In
plperl_spi_exec(), for
On 01/08/2023 16:48, Joe Conway wrote:
Any further comments on the posted patch[1]? I would like to apply/push
this prior to the beta and minor releases next week.
I'm not sure about the placement of the uselocale() calls. In
plperl_spi_exec(), for example, I think we should switch to the
On Tue Aug 1, 2023 at 8:48 AM CDT, Joe Conway wrote:
On 7/3/23 12:25, Tristan Partin wrote:
> On Sat Jun 24, 2023 at 8:09 AM CDT, Joe Conway wrote:
>> Although I have not looked yet, presumably we could have similar
>> problems with plpython. I would like to get agreement on this approach
>>
On 7/3/23 12:25, Tristan Partin wrote:
On Sat Jun 24, 2023 at 8:09 AM CDT, Joe Conway wrote:
Although I have not looked yet, presumably we could have similar
problems with plpython. I would like to get agreement on this approach
against plperl before diving into that though.
Thoughts?
I
Here is an up to date patch given some churn on the master branch.
--
Tristan Partin
Neon (https://neon.tech)
From b68cec481768c7c635ec48329b4764eced264572 Mon Sep 17 00:00:00 2001
From: Tristan Partin
Date: Fri, 30 Jun 2023 09:31:04 -0500
Subject: [PATCH v3 1/3] Skip checking for uselocale on
Someday I will learn...
Attached is the v2.
--
Tristan Partin
Neon (https://neon.tech)
From 5688bc2b2c6331f437a72b6a429199c5416ccd76 Mon Sep 17 00:00:00 2001
From: Tristan Partin
Date: Fri, 30 Jun 2023 09:31:04 -0500
Subject: [PATCH v2 1/3] Skip checking for uselocale on Windows
Windows
On Mon Jul 3, 2023 at 9:42 AM CDT, Tristan Partin wrote:
> Thanks for your patience. Attached is a patch that should cover all the
> problematic use cases of setlocale(). There are some setlocale() calls in
> tests, initdb, and ecpg left. I plan to get to ecpglib before the final
> version of this
On 7/3/23 12:25, Tristan Partin wrote:
On Sat Jun 24, 2023 at 8:09 AM CDT, Joe Conway wrote:
Although I have not looked yet, presumably we could have similar
problems with plpython. I would like to get agreement on this approach
against plperl before diving into that though.
Thoughts?
I
On 7/3/23 12:17, Tristan Partin wrote:
The Reply-To header in your email is pointing at joe@cd, fyi. Pretty
strange.
I noticed that -- it happened only the one time, and I am not sure why.
Seems fine now though.
--
Joe Conway
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon
On Sat Jun 24, 2023 at 8:09 AM CDT, Joe Conway wrote:
> Although I have not looked yet, presumably we could have similar
> problems with plpython. I would like to get agreement on this approach
> against plperl before diving into that though.
>
> Thoughts?
I don't see anything immediately wrong
Joe,
The Reply-To header in your email is pointing at joe@cd, fyi. Pretty
strange.
--
Tristan Partin
Neon (https://neon.tech)
On Fri Jun 30, 2023 at 7:13 AM CDT, Joe Conway wrote:
> On 6/29/23 22:13, Tristan Partin wrote:
> > On Mon Jun 5, 2023 at 11:00 AM CDT, Heikki Linnakangas wrote:
> >> I think the uselocale() call renders ineffective the setlocale() calls
> >> that we make later. Maybe we should replace our
On 6/29/23 22:13, Tristan Partin wrote:
On Mon Jun 5, 2023 at 11:00 AM CDT, Heikki Linnakangas wrote:
I think the uselocale() call renders ineffective the setlocale() calls
that we make later. Maybe we should replace our setlocale() calls with
uselocale(), too.
For what it's worth to
On 6/22/23 03:26, Heikki Linnakangas wrote:
On 21/06/2023 01:02, Joe Conway wrote:
On 6/19/23 19:30, Heikki Linnakangas wrote:
I think we should call "uselocale(LC_GLOBAL_LOCALE)" immediately after
returning from the perl interpreter, instead of before setlocale()
calls, if we want all
On 21/06/2023 01:02, Joe Conway wrote:
On 6/19/23 19:30, Heikki Linnakangas wrote:
On 18/06/2023 21:27, Joe Conway wrote:
With the patch you're proposing, do we now have a coding rule that you
must call "uselocale(LC_GLOBAL_LOCALE)" before every and any call to
setlocale()? If so, you missed a
On 6/19/23 19:30, Heikki Linnakangas wrote:
On 18/06/2023 21:27, Joe Conway wrote:
I have proposed a targeted fix that I believe is safe to backpatch --
attached.
IIUC, Tom was +1, but Heikki was looking for a more general solution.
My issue with the more general solution is that it will
On 18/06/2023 21:27, Joe Conway wrote:
I have proposed a targeted fix that I believe is safe to backpatch --
attached.
IIUC, Tom was +1, but Heikki was looking for a more general solution.
My issue with the more general solution is that it will likely be too
invasive to backpatch, and at the
On 6/12/23 17:28, Joe Conway wrote:
On 6/12/23 10:44, Joe Conway wrote:
1/ how do we fix the misbehavior reported due to libperl in existing
stable branches
I was mostly trying to concentrate on #1, but 2 & 3 are worthy of
discussion.
Hmm, browsing through the perl source I came across a
On Mon Jun 12, 2023 at 4:13 AM CDT, Heikki Linnakangas wrote:
> There are a few uselocale() calls in ecpg, and they are protected by
> HAVE_USELOCALE. Interestingly, the calls in pg_locale.c are not, but
> they are protected by HAVE_LOCALE_T. Seems a little inconsistent.
Patch is attached.
On 6/12/23 10:44, Joe Conway wrote:
1/ how do we fix the misbehavior reported due to libperl in existing
stable branches
I was mostly trying to concentrate on #1, but 2 & 3 are worthy of
discussion.
Hmm, browsing through the perl source I came across a reference to this
(from
(moving to hackers)
On 6/12/23 05:13, Heikki Linnakangas wrote:
On 10/06/2023 22:28, Joe Conway wrote:
On 6/10/23 15:07, Joe Conway wrote:
On 6/10/23 14:42, Tom Lane wrote:
Joe Conway writes:
5/ The attached fixes the issue for me on pg10 and passes check-world.
Comments?
The call in
24 matches
Mail list logo
