Re: DNS SRV support for LDAP authentication

2019-03-20 Thread Thomas Munro
On Tue, Mar 19, 2019 at 9:01 PM Thomas Munro wrote: > I'd like to commit this soon. Done, after some more comment adjustments. Thanks Daniel and Graham for your feedback! -- Thomas Munro https://enterprisedb.com

Re: DNS SRV support for LDAP authentication

2019-03-19 Thread Thomas Munro
On Sat, Feb 16, 2019 at 10:57 PM Thomas Munro wrote: > Yeah. This coding is ugly and StringInfo would be much nicer. > Thinking about that made me realise that the proposed SRV case should > also handle multiple SRV records by building a multi-URL string too > (instead of just taking the first

Re: DNS SRV support for LDAP authentication

2019-02-16 Thread Thomas Munro
On Sat, Feb 2, 2019 at 12:48 AM Daniel Gustafsson wrote: > + new_uris = psprintf("%s%s%s://%s:%d", > > While this construction isn't introduced in this patch, would it not make > sense > to convert uris to StringInfo instead to improve readability? Yeah. This coding is ugly and

Re: DNS SRV support for LDAP authentication

2019-02-02 Thread Thomas Munro
On Sat, Feb 2, 2019 at 10:34 PM Graham Leggett wrote: > On 02 Feb 2019, at 01:57, Thomas Munro wrote: > > On Sat, Feb 2, 2019 at 9:25 AM Graham Leggett wrote: > >> Does this support SSL/TLS? > > I didn't try it myself but I found several claims that it works. I > > see complaints that it

Re: DNS SRV support for LDAP authentication

2019-02-02 Thread Graham Leggett
On 02 Feb 2019, at 01:57, Thomas Munro wrote: > On Sat, Feb 2, 2019 at 9:25 AM Graham Leggett wrote: >> On 25 Sep 2018, at 04:09, Thomas Munro wrote: >>> Some people like to use DNS SRV records to advertise LDAP servers on >>> their network. Microsoft Active Directory is usually (always?) set

Re: DNS SRV support for LDAP authentication

2019-02-01 Thread Thomas Munro
On Sat, Feb 2, 2019 at 9:25 AM Graham Leggett wrote: > On 25 Sep 2018, at 04:09, Thomas Munro wrote: > > Some people like to use DNS SRV records to advertise LDAP servers on > > their network. Microsoft Active Directory is usually (always?) set up > > that way. Here is a patch to allow our

Re: DNS SRV support for LDAP authentication

2019-02-01 Thread Graham Leggett
On 25 Sep 2018, at 04:09, Thomas Munro wrote: > Some people like to use DNS SRV records to advertise LDAP servers on > their network. Microsoft Active Directory is usually (always?) set up > that way. Here is a patch to allow our LDAP auth module to support > that kind of discovery. Does this

Re: DNS SRV support for LDAP authentication

2019-02-01 Thread Daniel Gustafsson
> On 25 Sep 2018, at 04:09, Thomas Munro wrote: > Some people like to use DNS SRV records to advertise LDAP servers on > their network. Microsoft Active Directory is usually (always?) set up > that way. Here is a patch to allow our LDAP auth module to support > that kind of discovery. It

Re: DNS SRV support for LDAP authentication

2018-11-15 Thread Thomas Munro
On Wed, Nov 7, 2018 at 4:39 PM Thomas Munro wrote: > On Tue, Sep 25, 2018 at 2:09 PM Thomas Munro > wrote: > > Some people like to use DNS SRV records to advertise LDAP servers on > > their network. Microsoft Active Directory is usually (always?) set up > > that way. Here is a patch to allow

Re: DNS SRV support for LDAP authentication

2018-11-06 Thread Thomas Munro
On Tue, Sep 25, 2018 at 2:09 PM Thomas Munro wrote: > Some people like to use DNS SRV records to advertise LDAP servers on > their network. Microsoft Active Directory is usually (always?) set up > that way. Here is a patch to allow our LDAP auth module to support > that kind of discovery. It

Re: DNS SRV support for LDAP authentication

2018-09-24 Thread Thomas Munro
On Tue, Sep 25, 2018 at 2:09 PM Thomas Munro wrote: > 2. Define a new zone for testing, by adding the following to the end > 3. Create that zone file in /usr/local/etc/namedb/master/my.test.domain: Oops, I changed my testing domain name in the middle of my experiment, but pasted the older

DNS SRV support for LDAP authentication

2018-09-24 Thread Thomas Munro
Hello hackers, Some people like to use DNS SRV records to advertise LDAP servers on their network. Microsoft Active Directory is usually (always?) set up that way. Here is a patch to allow our LDAP auth module to support that kind of discovery. It copies the convention of the OpenLDAP command