On Thu, May 09, 2019 at 02:36:48PM +0900, Michael Paquier wrote:
> Yes, I can see that. The issue is that even if we do a backup with
> --tablespace-mapping then we still need a tweak to allow the copy of
> symlinks. I am not sure that this is completely what we are looking
> for either, as it
On Fri, Mar 22, 2019 at 04:25:53PM +0800, Shaoqi Bai wrote:
> Deleted the test for group permissions in updated patch.
Well, there are a couple of things I am not really happy about in this
patch:
- There is not much point to have has_tablespace_mapping as it is not
extensible. Instead I'd
On Fri, Apr 26, 2019 at 11:21:48AM -0400, Tom Lane wrote:
> I don't think feature freeze precludes adding new test cases.
I think as well that adding this stuff into v12 would be fine. Now if
there is any objection let's wait for later.
--
Michael
signature.asc
Description: PGP signature
Alvaro Herrera writes:
> On 2019-Apr-26, Michael Paquier wrote:
>> On Fri, Apr 26, 2019 at 10:11:24AM -0400, Alvaro Herrera wrote:
>>> I just noticed this thread. What do we think of adding this test to
>>> pg12? (The patch doesn't apply verbatim, but it's a small update to get
>>> it to
On 2019-Apr-26, Michael Paquier wrote:
> On Fri, Apr 26, 2019 at 10:11:24AM -0400, Alvaro Herrera wrote:
> > I just noticed this thread. What do we think of adding this test to
> > pg12? (The patch doesn't apply verbatim, but it's a small update to get
> > it to apply.)
>
> Could you let me
On Fri, Apr 26, 2019 at 10:11:24AM -0400, Alvaro Herrera wrote:
> I just noticed this thread. What do we think of adding this test to
> pg12? (The patch doesn't apply verbatim, but it's a small update to get
> it to apply.)
Could you let me have a look at it? I have not tested on Windows, but
I just noticed this thread. What do we think of adding this test to
pg12? (The patch doesn't apply verbatim, but it's a small update to get
it to apply.)
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Fri, Mar 22, 2019 at 1:34 PM Michael Paquier wrote:
> On Thu, Mar 21, 2019 at 11:41:01PM +0800, Shaoqi Bai wrote:
> > Have updated the patch doing as you suggested
>
> + RewindTest::setup_cluster($test_mode, ['-g']);
> + RewindTest::start_master();
>
> There is no need to test for group
On Thu, Mar 21, 2019 at 11:41:01PM +0800, Shaoqi Bai wrote:
> Have updated the patch doing as you suggested
+ RewindTest::setup_cluster($test_mode, ['-g']);
+ RewindTest::start_master();
There is no need to test for group permissions here, 002_databases.pl
already looks after that.
+ #
On Tue, Mar 12, 2019 at 10:27 AM Michael Paquier
wrote:
> It could be an idea to split the patch in two pieces:
> - One patch which refactors the code for the new option in
> PostgresNode.pm
> - Second patch for the new test with integration in RewindTest.pm.
> This should touch different parts
On Tue, Mar 19, 2019 at 08:16:21PM +0800, Shaoqi Bai wrote:
> Thanks for your advice, sorry for taking so long to give update in the
> thread, because I am stuck in modifing Perl script, knowing little about
> Perl language.
No problem. It is true that using perl for the first time can be a
On Tue, Mar 12, 2019 at 10:27 AM Michael Paquier
wrote:
> On Mon, Mar 11, 2019 at 07:49:11PM +0800, Shaoqi Bai wrote:
> > Thanks, will work on it as you suggested
> > Add pg_basebackup --T olddir=newdir to support check the consistency of a
> > tablespace created before promotion
> > Add
On Mon, Mar 11, 2019 at 07:49:11PM +0800, Shaoqi Bai wrote:
> Thanks, will work on it as you suggested
> Add pg_basebackup --T olddir=newdir to support check the consistency of a
> tablespace created before promotion
> Add run_test('remote');
Thanks for considering my input. Why don't you
Thanks, will work on it as you suggested
Add pg_basebackup --T olddir=newdir to support check the consistency of a
tablespace created before promotion
Add run_test('remote');
On Mon, Mar 11, 2019 at 6:50 AM Michael Paquier wrote:
> On Sat, Mar 09, 2019 at 09:09:24AM +0900, Michael Paquier
On Sat, Mar 09, 2019 at 09:09:24AM +0900, Michael Paquier wrote:
> When working on the first version of pg_rewind for VMware with Heikki,
> tablespace support has been added only after, so what you propose is
> sensible I think.
>
> +# Run the test in both modes.
> +run_test('local');
> Small
On Fri, Mar 08, 2019 at 09:42:29PM +0800, Shaoqi Bai wrote:
> There is already a databases tap tests in pg_rewind, wonder if there is a
> need for tablespace tap tests in pg_rewind. Attached is a initial
> patch from me.
When working on the first version of pg_rewind for VMware with Heikki,
Hi hackers,
There is already a databases tap tests in pg_rewind, wonder if there is a
need for tablespace tap tests in pg_rewind.
Attached is a initial patch from me.
Here is a patch for runing pg_rewind, it is very similar to
src/bin/pg_rewind/t/002_databases.pl, but there is no
17 matches
Mail list logo
