Re: Incorrect comments in partition.c

2018-03-01 Thread Etsuro Fujita
(2018/03/01 0:12), Robert Haas wrote: On Wed, Feb 28, 2018 at 3:24 AM, Etsuro Fujita wrote: I'll add this to the upcoming commitfest. Committed. Sorry that I didn't notice this thread sooner (and that the original commits didn't take care of it). Thanks!

Re: Incorrect comments in partition.c

2018-02-28 Thread Robert Haas
On Wed, Feb 28, 2018 at 3:24 AM, Etsuro Fujita wrote: > I'll add this to the upcoming commitfest. Committed. Sorry that I didn't notice this thread sooner (and that the original commits didn't take care of it). -- Robert Haas EnterpriseDB:

Re: Incorrect comments in partition.c

2018-02-28 Thread Etsuro Fujita
(2018/01/24 14:44), Etsuro Fujita wrote: > (2018/01/24 13:06), Amit Langote wrote: >> On 2018/01/23 20:43, Etsuro Fujita wrote: >>> Here is a comment for get_qual_for_list in partition.c: >>> >>> * get_qual_for_list >>> * >>> * Returns an implicit-AND list of expressions to use as a

Re: Incorrect comments in partition.c

2018-01-23 Thread Etsuro Fujita
(2018/01/24 13:06), Amit Langote wrote: > On 2018/01/23 20:43, Etsuro Fujita wrote: >> Here is a comment for get_qual_for_list in partition.c: >> >>* get_qual_for_list >>* >>* Returns an implicit-AND list of expressions to use as a list partition's >> - * constraint, given the

Re: Incorrect comments in partition.c

2018-01-23 Thread Amit Langote
On 2018/01/23 20:43, Etsuro Fujita wrote: > Here is a comment for get_qual_for_list in partition.c: > > * get_qual_for_list > * > * Returns an implicit-AND list of expressions to use as a list partition's > - * constraint, given the partition key and bound structures. > > I don't think the

Incorrect comments in partition.c

2018-01-23 Thread Etsuro Fujita
Here is a comment for get_qual_for_list in partition.c: * get_qual_for_list * * Returns an implicit-AND list of expressions to use as a list partition's - * constraint, given the partition key and bound structures. I don't think the part "given the partition key and bound structures." is