Re: Old protocol fastpath calls borked?

2019-01-24 Thread Tom Lane
Andres Freund writes: > Ah, brainfade. Probably triggered by the fact that I forgot that we call > input functions even on NULL (which never quite made sense to me). That's so that domain_in can reject NULLs if the domain constraints say to do so. Mind you, the SQL committee should never have

Re: Old protocol fastpath calls borked?

2019-01-24 Thread Andres Freund
Hi, On 2019-01-24 17:04:32 -0500, Tom Lane wrote: > Andres Freund writes: > > In parse_fcall_arguments_20(): > > we appear to constantly setting argnull to true for all arguments? > > Uh, it looks to me like it does so only if the frontend sends a -1 > length field, which is the protocol's

Re: Old protocol fastpath calls borked?

2019-01-24 Thread Tom Lane
Andres Freund writes: > In parse_fcall_arguments_20(): > we appear to constantly setting argnull to true for all arguments? Uh, it looks to me like it does so only if the frontend sends a -1 length field, which is the protocol's convention for indicating a null. regards,

Old protocol fastpath calls borked?

2019-01-24 Thread Andres Freund
Hi, In parse_fcall_arguments_20(): c0a8c3ac13f8 (Tom Lane 2003-05-08 18:16:37 + 579) argsize = pq_getmsgint(msgBuf, 4); 0ac6298bb8ac (Tom Lane 2003-05-09 18:08:48 + 580) if (argsize == -1) 0ac6298bb8ac (Tom Lane 2003-05-09 18:08:48 +