Re: Parallel bt build crashes when DSM_NONE

2018-02-13 Thread Michael Paquier
On Wed, Feb 14, 2018 at 10:38:58AM +0900, Kyotaro HORIGUCHI wrote: > I'll post a patch that eliminate DSM_IMPL_NONE after this. I'd like it > to be shipped on 11. Feel free to. Be just careful that the connection attempts in test_config_settings() should try to use the DSM implementation defined

Re: Parallel bt build crashes when DSM_NONE

2018-02-13 Thread Kyotaro HORIGUCHI
At Mon, 12 Feb 2018 22:05:36 +0900, Michael Paquier wrote in <20180212130536.ga18...@paquier.xyz> > On Fri, Feb 09, 2018 at 05:06:35PM +0900, Kyotaro HORIGUCHI wrote: > 4 regression tests fail when using dynamic_shared_memory_type=none: > join, aggregates, select_parallel and write_parallel. tes

Re: Parallel bt build crashes when DSM_NONE

2018-02-13 Thread Kyotaro HORIGUCHI
At Mon, 12 Feb 2018 15:00:54 -0500, Robert Haas wrote in > On Mon, Feb 12, 2018 at 12:26 PM, Peter Geoghegan wrote: > > I think that your patch does the right thing. > > plan_create_index_workers() is supposed to take care of parallel > > safety, and this is a parallel safety issue. > > Commit

Re: Parallel bt build crashes when DSM_NONE

2018-02-12 Thread Robert Haas
On Mon, Feb 12, 2018 at 12:26 PM, Peter Geoghegan wrote: > I think that your patch does the right thing. > plan_create_index_workers() is supposed to take care of parallel > safety, and this is a parallel safety issue. Committed the patch. -- Robert Haas EnterpriseDB: http://www.enterprisedb.co

Re: Parallel bt build crashes when DSM_NONE

2018-02-12 Thread Peter Geoghegan
On Fri, Feb 9, 2018 at 12:06 AM, Kyotaro HORIGUCHI wrote: > I happend to find that server crashes during regtest when > DSM_NONE is enforced. The attached patch fixes that. > > The cause is the fact that _bt_spools_heapscan runs > _bt_begin_parallel() even if dynamic_shared_memory_type is > DSM_NO

Re: Parallel bt build crashes when DSM_NONE

2018-02-12 Thread Michael Paquier
On Fri, Feb 09, 2018 at 05:06:35PM +0900, Kyotaro HORIGUCHI wrote: > I happend to find that server crashes during regtest when > DSM_NONE is enforced. The attached patch fixes that. > > The cause is the fact that _bt_spools_heapscan runs > _bt_begin_parallel() even if dynamic_shared_memory_type is

Parallel bt build crashes when DSM_NONE

2018-02-09 Thread Kyotaro HORIGUCHI
Hello. I happend to find that server crashes during regtest when DSM_NONE is enforced. The attached patch fixes that. The cause is the fact that _bt_spools_heapscan runs _bt_begin_parallel() even if dynamic_shared_memory_type is DSM_NONE. It is because plan_create_index_workers() is ignoring dyna