Re: Possible SSI bug in heap_update

2021-04-12 Thread Thomas Munro
On Mon, Apr 12, 2021 at 10:36 AM Thomas Munro wrote: > Yeah. Patch attached. Pushed.

Re: Possible SSI bug in heap_update

2021-04-11 Thread Thomas Munro
On Mon, Apr 12, 2021 at 4:54 AM Tom Lane wrote: > While re-reading heap_update() in connection with that PANIC we're > chasing, my attention was drawn to this comment: > > /* > * Note: beyond this point, use oldtup not otid to refer to old tuple. > * otid may very well point at

Possible SSI bug in heap_update

2021-04-11 Thread Tom Lane
While re-reading heap_update() in connection with that PANIC we're chasing, my attention was drawn to this comment: /* * Note: beyond this point, use oldtup not otid to refer to old tuple. * otid may very well point at newtup->t_self, which we will overwrite * with the new