Thank you, pushed
Fabien COELHO wrote:
Patch isn't applyed cleanly anymore.
Indeed. Here is a rebase. All pgbench patches conflict about test cases.
Patch v12, yet another rebase.
--
Teodor Sigaev E-mail: teo...@sigaev.ru
Patch isn't applyed cleanly anymore.
Indeed. Here is a rebase. All pgbench patches conflict about test cases.
Patch v12, yet another rebase.
--
Fabien.diff --git a/doc/src/sgml/ref/pgbench.sgml b/doc/src/sgml/ref/pgbench.sgml
index d52d324..41d9030 100644
--- a/doc/src/sgml/ref/pgbench.sgml
Patch isn't applyed cleanly anymore.
Indeed. Here is a rebase. All pgbench patches conflict about test cases.
--
Fabien.diff --git a/doc/src/sgml/ref/pgbench.sgml b/doc/src/sgml/ref/pgbench.sgml
index f07ddf1..e4582bf 100644
--- a/doc/src/sgml/ref/pgbench.sgml
+++ b/doc/src/sgml/ref/pgbench.s
Patch isn't applyed cleanly anymore.
Fabien COELHO wrote:
But now the documentation is back to its original state of silence on
what base or how many bases might be allowed. Could it just say
"or an unsigned decimal integer value"? Then no one will wonder.
Done in the attached.
Thanks for t
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, failed
Spec compliant: not tested
Documentation:tested, failed
This is a simple patch, includes documentation, includes and pass
But now the documentation is back to its original state of silence on
what base or how many bases might be allowed. Could it just say
"or an unsigned decimal integer value"? Then no one will wonder.
Done in the attached.
Thanks for the reviews.
--
Fabien.diff --git a/doc/src/sgml/ref/pgbench
I'm sorry, I must have missed your reply on the 5th somehow.
On 03/05/18 07:01, Fabien COELHO wrote:
> I must admit that I'm not too happy with the result as well, so I dropped
> the octal/hexadecimal parsing.
That seems perfectly reasonable to me; perfectly adequate to accept only
one base.
But
Hello Chapman,
Here is v9.
It needs s/explicitely/explicitly/ in the docs.
Done.
The parsing of the seed involves matters of taste, I guess: if it were a
signed int, then sscanf's built-in %i would do everything those three
explicit hex/octal/decimal branches do, but there's no unsigned v
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation:tested, passed
The patch 8 works and addresses the things I noticed earlier.
It
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation:not tested
Initial review is the message this is in reply to.
The new status of
10 matches
Mail list logo
