Re: Resetting PGPROC atomics in ProcessInit()

2018-11-12 Thread Amit Kapila
On Fri, Nov 9, 2018 at 10:28 AM Amit Kapila wrote: > > On Thu, Nov 8, 2018 at 4:38 PM Amit Kapila wrote: > > On Sun, Nov 4, 2018 at 6:30 AM Robert Haas wrote: > > > On Sat, Oct 27, 2018 at 6:41 AM Andres Freund wrote: > > Okay, changed the code as per Andres's and your suggestion. Do you > >

Re: Resetting PGPROC atomics in ProcessInit()

2018-11-08 Thread Amit Kapila
On Sun, Nov 4, 2018 at 6:30 AM Robert Haas wrote: > > On Sat, Oct 27, 2018 at 6:41 AM Andres Freund wrote: > > I just noticed, while working on a patch adding things to PGPROC, that > > the group clearning patches for the proc array and clog reset atomics in > > InitProcess(). > > > > I'm not a

Re: Resetting PGPROC atomics in ProcessInit()

2018-11-03 Thread Robert Haas
On Sat, Oct 27, 2018 at 6:41 AM Andres Freund wrote: > I just noticed, while working on a patch adding things to PGPROC, that > the group clearning patches for the proc array and clog reset atomics in > InitProcess(). > > I'm not a big fan of that, because it means that it's not safe to look > at

Re: Resetting PGPROC atomics in ProcessInit()

2018-11-02 Thread Amit Kapila
On Sat, Oct 27, 2018 at 9:42 PM Amit Kapila wrote: > > On Sat, Oct 27, 2018 at 8:52 PM Andres Freund wrote: > > On October 27, 2018 3:36:45 PM GMT+01:00, Amit Kapila > > wrote: > > >On Sat, Oct 27, 2018 at 4:11 PM Andres Freund > > >wrote: > > >> > > >> Hi, > > >> > > >> I just noticed, while

Re: Resetting PGPROC atomics in ProcessInit()

2018-10-27 Thread Amit Kapila
On Sat, Oct 27, 2018 at 8:52 PM Andres Freund wrote: > On October 27, 2018 3:36:45 PM GMT+01:00, Amit Kapila > wrote: > >On Sat, Oct 27, 2018 at 4:11 PM Andres Freund > >wrote: > >> > >> Hi, > >> > >> I just noticed, while working on a patch adding things to PGPROC, > >that > >> the group

Re: Resetting PGPROC atomics in ProcessInit()

2018-10-27 Thread Amit Kapila
On Sat, Oct 27, 2018 at 4:11 PM Andres Freund wrote: > > Hi, > > I just noticed, while working on a patch adding things to PGPROC, that > the group clearning patches for the proc array and clog reset atomics in > InitProcess(). > > I'm not a big fan of that, because it means that it's not safe to

Resetting PGPROC atomics in ProcessInit()

2018-10-27 Thread Andres Freund
Hi, I just noticed, while working on a patch adding things to PGPROC, that the group clearning patches for the proc array and clog reset atomics in InitProcess(). I'm not a big fan of that, because it means that it's not safe to look at the atomics of backends that aren't currently in use. Is