I wrote:
> On 11/14/18, Tom Lane wrote:
>> Alvaro Herrera writes:
>>> Maybe time to compile the ecpg test cases during "make check-world"?
>>
>> I'm dubious that the lexer is a significant part of that, though I could
>> be wrong ...
>
> If it were, it'd be much easier to try a Flex flag other
On 11/14/18, Tom Lane wrote:
> Looks like good stuff, pushed with a small additional amount of work.
Thanks.
>> -Does ECPG still need its own functions for mm_alloc() and
>> mm_strdup(), if we have equivalents in src/common?
>
> The error handling isn't the same, so I don't think we can just
Alvaro Herrera writes:
> On 2018-Nov-13, Tom Lane wrote:
>> More generally, I wonder if it'd be practical to make pgc.l backup-free
>> altogether. I'm not sure that the resulting gain in lexing speed would
>> really be of interest to anyone,
> Maybe time to compile the ecpg test cases during
On 2018-Nov-13, Tom Lane wrote:
> More generally, I wonder if it'd be practical to make pgc.l backup-free
> altogether. I'm not sure that the resulting gain in lexing speed would
> really be of interest to anyone,
Maybe time to compile the ecpg test cases during "make check-world"?
--
Álvaro
John Naylor writes:
> Commit 21c8ee7946 was one of several that sync'd the backend scanner
> with the psql scanner, with the commit message stating "Someday it'd
> be nice to make ecpg's pgc.l more easily diff'able too, but today is
> not that day." Attached is a set of patches to make progress
It seems the pach tester is confused by the addition of the
demonstration diff file. I'm reattaching just the patchset to see if
it turns green.
-John Naylor
From 107e3c8a0b65b0196ea4370a724c8b2a1b0fdf79 Mon Sep 17 00:00:00 2001
From: John Naylor
Date: Sun, 30 Sep 2018 12:51:41 +0700
Subject:
On 9/30/18, Michael Paquier wrote:
> It would be nice to add this patch to the next commit fest:
> https://commitfest.postgresql.org/20/
Done, thanks.
-John Naylor
On Sun, Sep 30, 2018 at 04:32:53PM +0700, John Naylor wrote:
> Commit 21c8ee7946 was one of several that sync'd the backend scanner
> with the psql scanner, with the commit message stating "Someday it'd
> be nice to make ecpg's pgc.l more easily diff'able too, but today is
> not that day."
