Re: Tab completion for \gx

2020-04-01 Thread Vik Fearing
On 4/1/20 5:01 AM, Bruce Momjian wrote:
> 
> Patch applied though PG 10, thanks.

Thanks!
-- 
Vik Fearing




Re: Tab completion for \gx

2020-03-31 Thread Bruce Momjian


Patch applied though PG 10, thanks.

---

On Thu, Mar 26, 2020 at 09:58:50AM -0700, Vik Fearing wrote:
> While reviewing the patch for \gf, I noticed that \gx does not have tab
> completion for its optional filename.  Trivial patch attached.  I would
> also suggest this be backpatched.
> -- 
> Vik Fearing

> diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
> index ae35fa4aa9..7252b6c4e6 100644
> --- a/src/bin/psql/tab-complete.c
> +++ b/src/bin/psql/tab-complete.c
> @@ -3882,7 +3882,7 @@ psql_completion(const char *text, int start, int end)
>   COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_routines, NULL);
>   else if (TailMatchesCS("\\sv*"))
>   COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_views, NULL);
> - else if (TailMatchesCS("\\cd|\\e|\\edit|\\g|\\i|\\include|"
> + else if (TailMatchesCS("\\cd|\\e|\\edit|\\g|\\gx|\\i|\\include|"
>  
> "\\ir|\\include_relative|\\o|\\out|"
>  
> "\\s|\\w|\\write|\\lo_import"))
>   {


-- 
  Bruce Momjian  https://momjian.us
  EnterpriseDB https://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+  Ancient Roman grave inscription +




Tab completion for \gx

2020-03-26 Thread Vik Fearing
While reviewing the patch for \gf, I noticed that \gx does not have tab
completion for its optional filename.  Trivial patch attached.  I would
also suggest this be backpatched.
-- 
Vik Fearing
diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
index ae35fa4aa9..7252b6c4e6 100644
--- a/src/bin/psql/tab-complete.c
+++ b/src/bin/psql/tab-complete.c
@@ -3882,7 +3882,7 @@ psql_completion(const char *text, int start, int end)
 		COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_routines, NULL);
 	else if (TailMatchesCS("\\sv*"))
 		COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_views, NULL);
-	else if (TailMatchesCS("\\cd|\\e|\\edit|\\g|\\i|\\include|"
+	else if (TailMatchesCS("\\cd|\\e|\\edit|\\g|\\gx|\\i|\\include|"
 		   "\\ir|\\include_relative|\\o|\\out|"
 		   "\\s|\\w|\\write|\\lo_import"))
 	{