Re: Typos and inconsistencies in code

2019-10-29 Thread vignesh C
On Wed, Oct 30, 2019 at 6:35 AM Michael Paquier wrote: > > On Tue, Oct 29, 2019 at 05:27:20PM +0530, vignesh C wrote: > > I have attached the updated patch with the fixes. > > The changes in rangetypes_gist.c are not correct, the usual pattern to > add an "s" after the structure name is quite

Re: Typos and inconsistencies in code

2019-10-29 Thread Michael Paquier
On Tue, Oct 29, 2019 at 05:27:20PM +0530, vignesh C wrote: > I have attached the updated patch with the fixes. The changes in rangetypes_gist.c are not correct, the usual pattern to add an "s" after the structure name is quite common when referring to multiple elements. We could perhaps use

Re: Typos and inconsistencies in code

2019-10-29 Thread vignesh C
On Tue, Oct 29, 2019 at 9:19 AM Dilip Kumar wrote: > > Few comments: > 1. > * The act of allocating pages to recycle may have invalidated the > - * results of our previous btree reserch, so repeat it. (We could > + * results of our previous btree search, so repeat it. (We could > * recheck

Re: Typos and inconsistencies in code

2019-10-28 Thread Dilip Kumar
On Mon, Oct 28, 2019 at 11:22 PM vignesh C wrote: > > Hi, > > Please find the attached patch having the fix for the typos and > inconsistencies present in code. > The patch contains the following changes: > 1) attibute -> attribute > 2) efficent -> efficient > 3) becuase -> because > 4) fallthru

Typos and inconsistencies in code

2019-10-28 Thread vignesh C
Hi, Please find the attached patch having the fix for the typos and inconsistencies present in code. The patch contains the following changes: 1) attibute -> attribute 2) efficent -> efficient 3) becuase -> because 4) fallthru -> fall through 5) uncoming -> upcoming 6) ans -> and 7) requrested ->