Re: Using isatty() on WIN32 platform

2017-11-20 Thread Craig Ringer
On 21 November 2017 at 03:53, Tom Lane wrote: > =?UTF-8?Q?Mart=c3=adn_Marqu=c3=a9s?= writes: > > While following suggestions from Arthur Zakirov on a patch for > > pg_basebackup I found that we are using isatty() in multiple places, but > > we don't distinguish the WIN32 code which should use _i

Re: Using isatty() on WIN32 platform

2017-11-20 Thread Tom Lane
=?UTF-8?Q?Mart=c3=adn_Marqu=c3=a9s?= writes: > While following suggestions from Arthur Zakirov on a patch for > pg_basebackup I found that we are using isatty() in multiple places, but > we don't distinguish the WIN32 code which should use _isatty() as per [1]. I dunno, [1] looks like pure pedant

Using isatty() on WIN32 platform

2017-11-20 Thread Martín Marqués
Hi, While following suggestions from Arthur Zakirov on a patch for pg_basebackup I found that we are using isatty() in multiple places, but we don't distinguish the WIN32 code which should use _isatty() as per [1]. It's true that isatty() is still supported by Visual C (else we'd fail to compile)