Re: behave of --create-slot option

2018-06-01 Thread Pavel Stehule
2018-06-01 18:36 GMT+02:00 Euler Taveira : > 2018-06-01 9:00 GMT-03:00 Michael Paquier : > > On Thu, May 31, 2018 at 10:59:04PM -0400, Robert Haas wrote: > >> On Wed, May 30, 2018 at 2:00 PM, Michael Paquier > wrote: > >>> Hm. There could be an argument for improving the user experience here >

Re: behave of --create-slot option

2018-06-01 Thread Michael Paquier
On Thu, May 31, 2018 at 10:59:04PM -0400, Robert Haas wrote: > On Wed, May 30, 2018 at 2:00 PM, Michael Paquier wrote: >> Hm. There could be an argument for improving the user experience here >> so as some cleanup is at least attempted except if --no-clean is defined >> by the caller when

Re: behave of --create-slot option

2018-05-31 Thread Robert Haas
On Wed, May 30, 2018 at 2:00 PM, Michael Paquier wrote: > Hm. There could be an argument for improving the user experience here > so as some cleanup is at least attempted except if --no-clean is defined > by the caller when --create-slot is used. Do we want an open item for > this issue?

Re: behave of --create-slot option

2018-05-30 Thread Michael Paquier
On Tue, May 29, 2018 at 09:21:00PM +0200, Pavel Stehule wrote: > 2018-05-29 16:53 GMT+02:00 Euler Taveira : >> If pg_basebackup failed for some other reason *after* the replication >> slot was created (say, permission problem) then we should try to >> cleanup the old slot. That should be the

Re: behave of --create-slot option

2018-05-29 Thread Pavel Stehule
2018-05-29 16:53 GMT+02:00 Euler Taveira : > 2018-05-29 1:31 GMT-03:00 Pavel Stehule : > > I hope so I understand to motivation for this option - but I see issues: > > > > 1. pg_basebackup can fail from some other reasons, but there is not > special > > status for this issue. > > 2. when I use

Re: behave of --create-slot option

2018-05-29 Thread Euler Taveira
2018-05-29 1:31 GMT-03:00 Pavel Stehule : > I hope so I understand to motivation for this option - but I see issues: > > 1. pg_basebackup can fail from some other reasons, but there is not special > status for this issue. > 2. when I use this option in any script, then I should to remove possibly

Re: behave of --create-slot option

2018-05-28 Thread Pavel Stehule
2018-05-29 6:11 GMT+02:00 Craig Ringer : > On 29 May 2018 at 11:51, Pavel Stehule wrote: > > >> >> I understand so slot should be unique. But same result (unique rep slot) >> can be done, if it does nothing when slot exists already. This behave is >> not idempotent. >> >> Maybe I am search

Re: behave of --create-slot option

2018-05-28 Thread Craig Ringer
On 29 May 2018 at 11:51, Pavel Stehule wrote: > > I understand so slot should be unique. But same result (unique rep slot) > can be done, if it does nothing when slot exists already. This behave is > not idempotent. > > Maybe I am search problem, where it is not. Just, when I see some "create >

Re: behave of --create-slot option

2018-05-28 Thread Pavel Stehule
2018-05-29 3:28 GMT+02:00 Craig Ringer : > On 29 May 2018 at 03:41, Pavel Stehule wrote: > >> Hi >> >> I am writing a article about PostgreSQL 11 features. Now I am looking on >> new option --create-slot option of pg_basebackup command. >> >> I don't understand to use case for this option,

Re: behave of --create-slot option

2018-05-28 Thread Craig Ringer
On 29 May 2018 at 03:41, Pavel Stehule wrote: > Hi > > I am writing a article about PostgreSQL 11 features. Now I am looking on > new option --create-slot option of pg_basebackup command. > > I don't understand to use case for this option, because It fails when > requested slot already exists. I

Re: behave of --create-slot option

2018-05-28 Thread Euler Taveira
2018-05-28 16:41 GMT-03:00 Pavel Stehule : > I am writing a article about PostgreSQL 11 features. Now I am looking on new > option --create-slot option of pg_basebackup command. > > I don't understand to use case for this option, because It fails when > requested slot already exists. I cannot to

behave of --create-slot option

2018-05-28 Thread Pavel Stehule
Hi I am writing a article about PostgreSQL 11 features. Now I am looking on new option --create-slot option of pg_basebackup command. I don't understand to use case for this option, because It fails when requested slot already exists. I cannot to imagine use case for this. If I write some