Re: enable_resultcache confusion

2021-07-15 Thread Bruce Momjian
On Mon, Jul 12, 2021 at 11:47:27AM +1200, David Rowley wrote: > On Mon, 12 Jul 2021 at 03:22, Justin Pryzby wrote: > > |This is useful if only a small percentage of rows is checked on > > |the inner side and is controlled by > |linkend="guc-enable-resultcache"/>. > > You

Re: enable_resultcache confusion

2021-07-13 Thread David Rowley
On Tue, 13 Jul 2021 at 12:01, David Rowley wrote: > I plan on pushing the patch to master and PG14 in 24 hours time. If > anyone is still on the fence or wishes to object to the name, please > let it be known before then. Renaming complete. Result Cache is gone. Welcome Memoize. David

Re: enable_resultcache confusion

2021-07-12 Thread David Rowley
On Tue, 13 Jul 2021 at 01:38, Tom Lane wrote: > > David Rowley writes: > > On Mon, 12 Jul 2021 at 03:22, Justin Pryzby wrote: > >> |This is useful if only a small percentage of rows is checked on > >> |the inner side and is controlled by >> |

Re: enable_resultcache confusion

2021-07-12 Thread Tom Lane
David Rowley writes: > On Mon, 12 Jul 2021 at 03:22, Justin Pryzby wrote: >> |This is useful if only a small percentage of rows is checked on >> |the inner side and is controlled by > |linkend="guc-enable-resultcache"/>. > You might be right there, but I'm not too sure

Re: enable_resultcache confusion

2021-07-11 Thread David Rowley
On Mon, 12 Jul 2021 at 03:22, Justin Pryzby wrote: > |This is useful if only a small percentage of rows is checked on > |the inner side and is controlled by |linkend="guc-enable-resultcache"/>. You might be right there, but I'm not too sure if I changed that that it

Re: enable_resultcache confusion

2021-07-11 Thread Justin Pryzby
On Mon, Jul 12, 2021 at 02:56:58AM +1200, David Rowley wrote: > On Sat, 10 Jul 2021 at 07:30, Robert Haas wrote: > > > > On Fri, Jul 9, 2021 at 11:35 AM David Rowley wrote: > > > I really like that name. > > > > > > I'll wait to see if anyone else wants to voice their opinion before I > > > do

Re: enable_resultcache confusion

2021-07-09 Thread Robert Haas
On Fri, Jul 9, 2021 at 11:35 AM David Rowley wrote: > I really like that name. > > I'll wait to see if anyone else wants to voice their opinion before I > do any renaming work. I like it, too. -- Robert Haas EDB: http://www.enterprisedb.com

Re: enable_resultcache confusion

2021-07-09 Thread David Rowley
On Fri, 9 Jul 2021 at 06:00, Tom Lane wrote: > > Maybe name the plan node type Memoize, and the GUC "enable_memoize"? I really like that name. I'll wait to see if anyone else wants to voice their opinion before I do any renaming work. David

Re: enable_resultcache confusion

2021-07-08 Thread Thomas Munro
On Fri, Jul 9, 2021 at 6:03 AM David G. Johnston wrote: > On Thu, Jul 8, 2021 at 11:00 AM Tom Lane wrote: >> Maybe name the plan node type Memoize, and the GUC "enable_memoize"? > > +1 +1

Re: enable_resultcache confusion

2021-07-08 Thread David G. Johnston
On Thu, Jul 8, 2021 at 11:00 AM Tom Lane wrote: > Maybe name the plan node type Memoize, and the GUC "enable_memoize"? > > +1 David J.

Re: enable_resultcache confusion

2021-07-08 Thread Justin Pryzby
On Thu, Jul 08, 2021 at 12:51:45PM -0400, Bruce Momjian wrote: > Are we going to be forever explaining that enable_resultcache doesn't > cache query results? Do we need a different name? > enable_innerjoin_cache? See also

Re: enable_resultcache confusion

2021-07-08 Thread Daniel Gustafsson
> On 8 Jul 2021, at 19:52, David G. Johnston wrote: > "enable_nodememoization" would work for me Include "node" concatenated with other words risks users reading it as "enable no demomoization", with confusion following. -- Daniel Gustafsson https://vmware.com/

Re: enable_resultcache confusion

2021-07-08 Thread Tom Lane
"David G. Johnston" writes: > "enable_nodememoization" would work for me That seems pretty unreadable. Maybe just "enable_memoization"? Really if we're going to do something here, we can't merely mess with the GUC name. David had expressed a willingness to rename everything about ResultCache

Re: enable_resultcache confusion

2021-07-08 Thread David G. Johnston
On Thu, Jul 8, 2021 at 10:29 AM Robert Haas wrote: > On Thu, Jul 8, 2021 at 12:51 PM Bruce Momjian wrote: > > Are we going to be forever explaining that enable_resultcache doesn't > > cache query results? > > Yes, I can see that causing ongoing confusion. Naming things is really > hard... > > I

Re: enable_resultcache confusion

2021-07-08 Thread Robert Haas
On Thu, Jul 8, 2021 at 12:51 PM Bruce Momjian wrote: > Are we going to be forever explaining that enable_resultcache doesn't > cache query results? Yes, I can see that causing ongoing confusion. Naming things is really hard... -- Robert Haas EDB: http://www.enterprisedb.com

enable_resultcache confusion

2021-07-08 Thread Bruce Momjian
Are we going to be forever explaining that enable_resultcache doesn't cache query results? Do we need a different name? enable_innerjoin_cache? -- Bruce Momjian https://momjian.us EDB https://enterprisedb.com If only the physical world