Re: parse/analyze API refactoring

2022-03-09 Thread Nathan Bossart
On Wed, Mar 09, 2022 at 11:35:32AM +0100, Peter Eisentraut wrote: > I have committed my original patches. I'll leave the above-mentioned topic > as ideas for the future. Sounds good. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com

Re: parse/analyze API refactoring

2022-03-09 Thread Peter Eisentraut
On 28.02.22 19:51, Nathan Bossart wrote: On Mon, Feb 28, 2022 at 07:46:40AM +0100, Peter Eisentraut wrote: You set this commit fest entry to Waiting on Author, but there were no reviews posted and the patch still applies and builds AFAICT, so I don't know what you meant by that. Apologies for

Re: parse/analyze API refactoring

2022-02-28 Thread Nathan Bossart
On Mon, Feb 28, 2022 at 07:46:40AM +0100, Peter Eisentraut wrote: > You set this commit fest entry to Waiting on Author, but there were no > reviews posted and the patch still applies and builds AFAICT, so I don't > know what you meant by that. Apologies for the lack of clarity. I believe my

Re: parse/analyze API refactoring

2022-02-27 Thread Peter Eisentraut
You set this commit fest entry to Waiting on Author, but there were no reviews posted and the patch still applies and builds AFAICT, so I don't know what you meant by that. On 13.01.22 00:49, Bossart, Nathan wrote: On 12/28/21, 8:25 AM, "Peter Eisentraut" wrote: (The "withcb" naming maybe

Re: parse/analyze API refactoring

2022-01-12 Thread Bossart, Nathan
On 12/28/21, 8:25 AM, "Peter Eisentraut" wrote: > (The "withcb" naming maybe isn't great; better ideas welcome.) FWIW I immediately understood that this meant "with callback," so it might be okay. > Not included in this patch set, but food for further thought: The > pg_analyze_and_rewrite_*()

parse/analyze API refactoring

2021-12-28 Thread Peter Eisentraut
I have found some of the parse/analyze API calls confusing one too many times, so here I'm proposing some renaming and refactoring. Notionally, there are three parallel ways to call the parse/analyze phase: with fixed parameters (for example, used by SPI), with variable parameters (for