Re: patch to ensure logical decoding errors early

2018-08-02 Thread Simon Riggs
On 1 August 2018 at 23:11, Alvaro Herrera wrote: > On 2018-Aug-01, Dave Cramer wrote: > >> See attached patch which fixes it, and adds a test for it. > > Pushed, thanks. Thanks -- Simon Riggshttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training

Re: patch to ensure logical decoding errors early

2018-08-01 Thread Alvaro Herrera
On 2018-Aug-01, Dave Cramer wrote: > See attached patch which fixes it, and adds a test for it. Pushed, thanks. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: patch to ensure logical decoding errors early

2018-08-01 Thread Dave Cramer
On 1 August 2018 at 10:13, Petr Jelinek wrote: > Hi, > > On 31/07/18 20:58, Andres Freund wrote> > >> diff --git a/src/backend/replication/logical/logical.c > b/src/backend/replication/logical/logical.c > >> index 3cd4eef..9f883b9 100644 > >> --- a/src/backend/replication/logical/logical.c > >>

Re: patch to ensure logical decoding errors early

2018-08-01 Thread Petr Jelinek
Hi, On 31/07/18 20:58, Andres Freund wrote> >> diff --git a/src/backend/replication/logical/logical.c >> b/src/backend/replication/logical/logical.c >> index 3cd4eef..9f883b9 100644 >> --- a/src/backend/replication/logical/logical.c >> +++ b/src/backend/replication/logical/logical.c >> @@ -143,8

Re: patch to ensure logical decoding errors early

2018-08-01 Thread Dave Cramer
On 31 July 2018 at 14:58, Andres Freund wrote: > Hi, > > On 2018-07-31 14:51:12 -0400, Dave Cramer wrote: > > This patch does 2 things > > > > 1) Ensure that when the slot is created > > with pg_create_physical_replication_slot if the output plugin does not > > exist it will error. > > *logical,

Re: patch to ensure logical decoding errors early

2018-07-31 Thread Andres Freund
Hi, On 2018-07-31 14:51:12 -0400, Dave Cramer wrote: > This patch does 2 things > > 1) Ensure that when the slot is created > with pg_create_physical_replication_slot if the output plugin does not > exist it will error. *logical, I assume? > diff --git

patch to ensure logical decoding errors early

2018-07-31 Thread Dave Cramer
This patch does 2 things 1) Ensure that when the slot is created with pg_create_physical_replication_slot if the output plugin does not exist it will error. 2) Currently when the decoding context is created and the output plugin does not exist the protocol will respond with CopyDone. This patch