Re: pg_upgrade: Error out on too many command-line arguments

Is this issue *really* worth expending test cycles on forevermore? With this argument consistently applied, postgres code coverage is consistently weak, with 25% of the code never executed, and 15% of functions never called. "psql" is abysmal, "libpq" is really weak. It's all a question

Re: pg_upgrade: Error out on too many command-line arguments

Fabien COELHO writes: >> Is this issue *really* worth expending test cycles on forevermore? > With this argument consistently applied, postgres code coverage is > consistently weak, with 25% of the code never executed, and 15% of > functions never called. "psql" is abysmal, "libpq" is really

Re: pg_upgrade: Error out on too many command-line arguments

Hello Tom, Could we maintain coverage by adding a TAP test? See 1 liner attached. Is this issue *really* worth expending test cycles on forevermore? With this argument consistently applied, postgres code coverage is consistently weak, with 25% of the code never executed, and 15% of

Re: pg_upgrade: Error out on too many command-line arguments

Fabien COELHO writes: > Could we maintain coverage by adding a TAP test? See 1 liner attached. Is this issue *really* worth expending test cycles on forevermore? Test cycles are not free, and I see zero reason to think that a check of this sort would ever catch any bugs. Now, if you had a way

Re: pg_upgrade: Error out on too many command-line arguments

Bonjour Michaël, I don't see why not. Perhaps this could be done for pgbench and oid2name as well? This is for pgbench. I did not found a TAP test in pg_upgrade, I do not think that it is worth creating one for that purpose. The "test.sh" script does not seem appropriate for this kind of

Re: pg_upgrade: Error out on too many command-line arguments

On Fri, Aug 30, 2019 at 08:44:28AM +0200, Fabien COELHO wrote: > Could we maintain coverage by adding a TAP test? See 1 liner attached. I don't see why not. Perhaps this could be done for pgbench and oid2name as well? -- Michael signature.asc Description: PGP signature

Re: pg_upgrade: Error out on too many command-line arguments

Hello Peter, On Sun, Aug 25, 2019 at 05:10:47PM +0200, Julien Rouhaud wrote: > I did some searching, and oid2name.c is also missing this. And pgbench, no?   Yes, the patch is slightly different. Thanks, pushed all that together. Great! Could we maintain coverage by adding a

Re: pg_upgrade: Error out on too many command-line arguments

On 2019-08-26 17:45, Ibrar Ahmed wrote: > On Mon, Aug 26, 2019 at 9:46 AM Michael Paquier > wrote: > > On Sun, Aug 25, 2019 at 05:10:47PM +0200, Julien Rouhaud wrote: > > I did some searching, and oid2name.c is also missing this. > > And pgbench, no? > >

Re: pg_upgrade: Error out on too many command-line arguments

On Mon, Aug 26, 2019 at 9:46 AM Michael Paquier wrote: > On Sun, Aug 25, 2019 at 05:10:47PM +0200, Julien Rouhaud wrote: > > I did some searching, and oid2name.c is also missing this. > > And pgbench, no? > Yes, the patch is slightly different. > -- > Michael > -- Ibrar Ahmed

Re: pg_upgrade: Error out on too many command-line arguments

On Sun, Aug 25, 2019 at 05:10:47PM +0200, Julien Rouhaud wrote: > I did some searching, and oid2name.c is also missing this. And pgbench, no? -- Michael signature.asc Description: PGP signature

Re: pg_upgrade: Error out on too many command-line arguments

On Sun, Aug 25, 2019 at 8:39 PM Julien Rouhaud wrote: > On Sun, Aug 25, 2019 at 4:30 PM Tom Lane wrote: > > > > Peter Eisentraut writes: > > > I propose the attached patch to make pg_upgrade error out on too many > > > command-line arguments. This mak

Re: pg_upgrade: Error out on too many command-line arguments

On Sun, Aug 25, 2019 at 4:30 PM Tom Lane wrote: > > Peter Eisentraut writes: > > I propose the attached patch to make pg_upgrade error out on too many > > command-line arguments. This makes it match the behavior of other > > PostgreSQL programs. > > +1 ... are we

Re: pg_upgrade: Error out on too many command-line arguments

Peter Eisentraut writes: > I propose the attached patch to make pg_upgrade error out on too many > command-line arguments. This makes it match the behavior of other > PostgreSQL programs. +1 ... are we missing this anywhere else? regards, tom lane

Re: pg_upgrade: Error out on too many command-line arguments

On Sun, Aug 25, 2019 at 10:52 AM Peter Eisentraut wrote: > > I propose the attached patch to make pg_upgrade error out on too many > command-line arguments. This makes it match the behavior of other > PostgreSQL programs. > > See [0] for an issue related to the lack of this check: +1

pg_upgrade: Error out on too many command-line arguments

I propose the attached patch to make pg_upgrade error out on too many command-line arguments. This makes it match the behavior of other PostgreSQL programs. See [0] for an issue related to the lack of this check: [0]: https://www.postgresql.org/message-id/871sdbzizp.fsf%40jsievers.enova.com