Re: pg_waldump erroneously outputs newline for FPWs, and another minor bug

2019-11-04 Thread Jehan-Guillaume de Rorthais
On Wed, 30 Oct 2019 09:26:21 +0900 Michael Paquier wrote: > On Tue, Oct 29, 2019 at 04:42:07PM -0700, Peter Geoghegan wrote: > > The same commit from Heikki omitted one field from that record, for no > > good reason. I backpatched a bugfix to the output format for nbtree > > page splits a few

Re: pg_waldump erroneously outputs newline for FPWs, and another minor bug

2019-10-30 Thread Andres Freund
Hi, On 2019-10-29 16:33:41 -0700, Andres Freund wrote: > Hi, > > When using -b, --bkp-details pg_waldump outputs an unnecessary newline > for blocks that contain an FPW. > > In --bkp-details block references are output on their own lines, like: > > rmgr: SPGist len (rec/tot): 4348/

Re: pg_waldump erroneously outputs newline for FPWs, and another minor bug

2019-10-29 Thread Michael Paquier
On Tue, Oct 29, 2019 at 04:42:07PM -0700, Peter Geoghegan wrote: > The same commit from Heikki omitted one field from that record, for no > good reason. I backpatched a bugfix to the output format for nbtree > page splits a few weeks ago, fixing that problem. I agree that we > should also

Re: pg_waldump erroneously outputs newline for FPWs, and another minor bug

2019-10-29 Thread Peter Geoghegan
On Tue, Oct 29, 2019 at 4:33 PM Andres Freund wrote: > Does anybody have an opinion about fixing it just in master or also > backpatching it? I guess there could be people having written parsers > for the waldump output? I'm inclined to backpatch. The same commit from Heikki omitted one field

pg_waldump erroneously outputs newline for FPWs, and another minor bug

2019-10-29 Thread Andres Freund
Hi, When using -b, --bkp-details pg_waldump outputs an unnecessary newline for blocks that contain an FPW. In --bkp-details block references are output on their own lines, like: rmgr: SPGist len (rec/tot): 4348/ 4348, tx:980, lsn: 0/01985818, prev 0/01983850, desc: PICKSPLIT