Re: pgoutput incorrectly replaces missing values with NULL since PostgreSQL 15

2023-11-27 Thread Nikhil Benesch
Thank you for turning this around so quickly!

Re: pgoutput incorrectly replaces missing values with NULL since PostgreSQL 15

2023-11-26 Thread Amit Kapila
On Fri, Nov 24, 2023 at 7:23 PM Nikhil Benesch wrote: > > Thank you both for reviewing. The updated patch set LGTM. > Pushed! -- With Regards, Amit Kapila.

Re: pgoutput incorrectly replaces missing values with NULL since PostgreSQL 15

2023-11-24 Thread Nikhil Benesch
Thank you both for reviewing. The updated patch set LGTM. Nikhil On Fri, Nov 24, 2023 at 7:21 AM Zhijie Hou (Fujitsu) wrote: > > On Friday, November 24, 2023 7:47 PM Amit Kapila > wrote: > > > > On Thu, Nov 23, 2023 at 2:33 PM Amit Kapila > > wrote: > > > > > > On Thu, Nov 23, 2023 at 1:10 

RE: pgoutput incorrectly replaces missing values with NULL since PostgreSQL 15

2023-11-24 Thread Zhijie Hou (Fujitsu)
On Friday, November 24, 2023 7:47 PM Amit Kapila wrote: > > On Thu, Nov 23, 2023 at 2:33 PM Amit Kapila > wrote: > > > > On Thu, Nov 23, 2023 at 1:10 PM Nikhil Benesch > wrote: > > > > > > While working on Materialize's streaming logical replication from > > > Postgres [0], my colleagues Sean

Re: pgoutput incorrectly replaces missing values with NULL since PostgreSQL 15

2023-11-24 Thread Amit Kapila
On Thu, Nov 23, 2023 at 2:33 PM Amit Kapila wrote: > > On Thu, Nov 23, 2023 at 1:10 PM Nikhil Benesch > wrote: > > > > While working on Materialize's streaming logical replication from Postgres > > [0], > > my colleagues Sean Loiselle and Petros Angelatos (CC'd) discovered today > > what > >

Re: pgoutput incorrectly replaces missing values with NULL since PostgreSQL 15

2023-11-23 Thread Amit Kapila
On Thu, Nov 23, 2023 at 1:10 PM Nikhil Benesch wrote: > > While working on Materialize's streaming logical replication from Postgres > [0], > my colleagues Sean Loiselle and Petros Angelatos (CC'd) discovered today what > appears to be a correctness bug in pgoutput, introduced in v15. > > The

pgoutput incorrectly replaces missing values with NULL since PostgreSQL 15

2023-11-22 Thread Nikhil Benesch
While working on Materialize's streaming logical replication from Postgres [0], my colleagues Sean Loiselle and Petros Angelatos (CC'd) discovered today what appears to be a correctness bug in pgoutput, introduced in v15. The problem goes like this. A table with REPLICA IDENTITY FULL and some