Re: proposal: enhancing plpgsql debug API - returns text value of variable content

2022-03-31 Thread Pavel Stehule
čt 31. 3. 2022 v 23:12 odesílatel Tom Lane napsal: > Pavel Stehule writes: > > I am sending updated patch > > After studying the list of exposed functions for awhile, it seemed > to me that we should also expose exec_assign_value. The new pointers > allow a plugin to compute a value in

Re: proposal: enhancing plpgsql debug API - returns text value of variable content

2022-03-31 Thread Tom Lane
Pavel Stehule writes: > I am sending updated patch After studying the list of exposed functions for awhile, it seemed to me that we should also expose exec_assign_value. The new pointers allow a plugin to compute a value in Datum+isnull format, but then it can't do much of anything with it:

Re: proposal: enhancing plpgsql debug API - returns text value of variable content

2022-03-31 Thread Pavel Stehule
Hi st 30. 3. 2022 v 21:09 odesílatel Tom Lane napsal: > Greg Stark writes: > > It looks like this is -- like a lot of plpgsql patches -- having > > difficulty catching the attention of reviewers and committers. > > I was hoping that someone with more familiarity with pldebugger > would comment

Re: proposal: enhancing plpgsql debug API - returns text value of variable content

2022-03-30 Thread Tom Lane
Greg Stark writes: > It looks like this is -- like a lot of plpgsql patches -- having > difficulty catching the attention of reviewers and committers. I was hoping that someone with more familiarity with pldebugger would comment on the suitableness of this patch for their desires. But nobody's

Re: proposal: enhancing plpgsql debug API - returns text value of variable content

2022-03-17 Thread Pavel Stehule
Hi čt 17. 3. 2022 v 20:58 odesílatel Greg Stark napsal: > It looks like this is -- like a lot of plpgsql patches -- having > difficulty catching the attention of reviewers and committers. > Aleksander asked for a test and Pavel put quite a bit of work into > adding a good test case. I actually

Re: proposal: enhancing plpgsql debug API - returns text value of variable content

2022-03-17 Thread Greg Stark
It looks like this is -- like a lot of plpgsql patches -- having difficulty catching the attention of reviewers and committers. Aleksander asked for a test and Pavel put quite a bit of work into adding a good test case. I actually like that there's a test because it shows the API can be used

Re: proposal: enhancing plpgsql debug API - returns text value of variable content

2021-08-22 Thread Pavel Stehule
ne 22. 8. 2021 v 19:38 odesílatel Pavel Stehule napsal: > Hi > > st 28. 7. 2021 v 11:01 odesílatel Pavel Stehule > napsal: > >> >> >> pá 23. 7. 2021 v 10:47 odesílatel Pavel Stehule >> napsal: >> >>> >>> >>> pá 23. 7. 2021 v 10:30 odesílatel Aleksander Alekseev < >>> aleksan...@timescale.com>

Re: proposal: enhancing plpgsql debug API - returns text value of variable content

2021-08-22 Thread Pavel Stehule
Hi st 28. 7. 2021 v 11:01 odesílatel Pavel Stehule napsal: > > > pá 23. 7. 2021 v 10:47 odesílatel Pavel Stehule > napsal: > >> >> >> pá 23. 7. 2021 v 10:30 odesílatel Aleksander Alekseev < >> aleksan...@timescale.com> napsal: >> >>> Hi Pavel, >>> >>> > I know it. Attached patch try to fix

Re: proposal: enhancing plpgsql debug API - returns text value of variable content

2021-07-28 Thread Pavel Stehule
pá 23. 7. 2021 v 10:47 odesílatel Pavel Stehule napsal: > > > pá 23. 7. 2021 v 10:30 odesílatel Aleksander Alekseev < > aleksan...@timescale.com> napsal: > >> Hi Pavel, >> >> > I know it. Attached patch try to fix this issue >> > >> > I merged you patch (thank you) >> >> Thanks! I did some more

Re: proposal: enhancing plpgsql debug API - returns text value of variable content

2021-07-23 Thread Pavel Stehule
pá 23. 7. 2021 v 10:30 odesílatel Aleksander Alekseev < aleksan...@timescale.com> napsal: > Hi Pavel, > > > I know it. Attached patch try to fix this issue > > > > I merged you patch (thank you) > > Thanks! I did some more minor changes, mostly in the comments. See the > attached patch. Other

Re: proposal: enhancing plpgsql debug API - returns text value of variable content

2021-07-23 Thread Aleksander Alekseev
Hi Pavel, > I know it. Attached patch try to fix this issue > > I merged you patch (thank you) Thanks! I did some more minor changes, mostly in the comments. See the attached patch. Other than that it looks OK. I think it's Ready for Committer now. -- Best regards, Aleksander Alekseev

Re: proposal: enhancing plpgsql debug API - returns text value of variable content

2021-07-22 Thread Pavel Stehule
čt 22. 7. 2021 v 14:54 odesílatel Aleksander Alekseev < aleksan...@timescale.com> napsal: > Hi Pavel, > > >> I am sending an enhanced patch about the regress test for plpgsql's > debug API. > > Thanks for the test! I noticed some little issues with formatting and > typos. The corrected patch is

Re: proposal: enhancing plpgsql debug API - returns text value of variable content

2021-07-22 Thread Aleksander Alekseev
Hi Pavel, >> I am sending an enhanced patch about the regress test for plpgsql's debug API. Thanks for the test! I noticed some little issues with formatting and typos. The corrected patch is attached. > override CPPFLAGS := $(CPPFLAGS) -I$(top_srcdir)/src/pl/plpgsql/src You probably already

Re: proposal: enhancing plpgsql debug API - returns text value of variable content

2021-07-21 Thread Pavel Stehule
st 21. 7. 2021 v 22:23 odesílatel Pavel Stehule napsal: > Hi > > pá 16. 7. 2021 v 18:40 odesílatel Pavel Stehule > napsal: > >> Hi >> >> pá 16. 7. 2021 v 15:05 odesílatel Aleksander Alekseev < >> aleksan...@timescale.com> napsal: >> >>> Hi Pavel, >>> >>> > I would like to print content of

Re: proposal: enhancing plpgsql debug API - returns text value of variable content

2021-07-21 Thread Pavel Stehule
Hi pá 16. 7. 2021 v 18:40 odesílatel Pavel Stehule napsal: > Hi > > pá 16. 7. 2021 v 15:05 odesílatel Aleksander Alekseev < > aleksan...@timescale.com> napsal: > >> Hi Pavel, >> >> > I would like to print content of variables - and now, I have to go some >> > deeper than I would like. I need to

Re: proposal: enhancing plpgsql debug API - returns text value of variable content

2021-07-16 Thread Pavel Stehule
Hi pá 16. 7. 2021 v 15:05 odesílatel Aleksander Alekseev < aleksan...@timescale.com> napsal: > Hi Pavel, > > > I would like to print content of variables - and now, I have to go some > > deeper than I would like. I need to separate between scalar, row, and > > record variables. PLpgSQL has code

Re: proposal: enhancing plpgsql debug API - returns text value of variable content

2021-07-16 Thread Aleksander Alekseev
Hi Pavel, > I would like to print content of variables - and now, I have to go some > deeper than I would like. I need to separate between scalar, row, and > record variables. PLpgSQL has code for it - but it is private. > [...] The patch seems OK, but I wonder - would it be possible to write a

Re: proposal: enhancing plpgsql debug API - returns text value of variable content

2021-05-31 Thread Pavel Stehule
ne 7. 2. 2021 v 19:09 odesílatel Pavel Stehule napsal: > Hi > > fresh rebase > only rebase Regards Pavel > Regards > > Pavel > diff --git a/src/pl/plpgsql/src/pl_exec.c b/src/pl/plpgsql/src/pl_exec.c index 78b593d12c..1048343c21 100644 --- a/src/pl/plpgsql/src/pl_exec.c +++

Re: proposal: enhancing plpgsql debug API - returns text value of variable content

2021-02-07 Thread Pavel Stehule
Hi fresh rebase Regards Pavel diff --git a/src/pl/plpgsql/src/pl_exec.c b/src/pl/plpgsql/src/pl_exec.c index b4c70aaa7f..1bafd202ff 100644 --- a/src/pl/plpgsql/src/pl_exec.c +++ b/src/pl/plpgsql/src/pl_exec.c @@ -4093,6 +4093,8 @@ plpgsql_estate_setup(PLpgSQL_execstate *estate, {

Re: proposal: enhancing plpgsql debug API - returns text value of variable content

2021-01-08 Thread Pavel Stehule
Hi rebase Regards Pavel diff --git a/src/pl/plpgsql/src/pl_exec.c b/src/pl/plpgsql/src/pl_exec.c index 3a9349b724..208ba181fc 100644 --- a/src/pl/plpgsql/src/pl_exec.c +++ b/src/pl/plpgsql/src/pl_exec.c @@ -4123,6 +4123,8 @@ plpgsql_estate_setup(PLpgSQL_execstate *estate, {

Re: proposal: enhancing plpgsql debug API - returns text value of variable content

2020-08-18 Thread Pavel Stehule
po 17. 8. 2020 v 8:40 odesílatel Pavel Stehule napsal: > Hi > > I am working on tracing support to plpgsql_check > > https://github.com/okbob/plpgsql_check > > I would like to print content of variables - and now, I have to go some > deeper than I would like. I need to separate between scalar,

proposal: enhancing plpgsql debug API - returns text value of variable content

2020-08-17 Thread Pavel Stehule
Hi I am working on tracing support to plpgsql_check https://github.com/okbob/plpgsql_check I would like to print content of variables - and now, I have to go some deeper than I would like. I need to separate between scalar, row, and record variables. PLpgSQL has code for it - but it is private.