Re: slightly misleading Error message in guc.c

Daniel Gustafsson writes: >> On 22 Apr 2024, at 18:04, Tom Lane wrote: >> Seems like a useful change > Agreed. >> ... about like this? > Patch LGTM. Pushed. regards, tom lane

Re: slightly misleading Error message in guc.c

> On 22 Apr 2024, at 18:04, Tom Lane wrote: > Seems like a useful change Agreed. > ... about like this? Patch LGTM. -- Daniel Gustafsson

Re: slightly misleading Error message in guc.c

jian he writes: > set work_mem to '1kB'; > ERROR: 1 kB is outside the valid range for parameter "work_mem" (64 > .. 2147483647) > should it be > ERROR: 1 kB is outside the valid range for parameter "work_mem" (64 > kB .. 2147483647 kB) > ? > since the units for work_mem are { "B", "kB", "MB",

Re: slightly misleading Error message in guc.c

Hi, On Mon, 22 Apr 2024 at 11:44, jian he wrote: > > hi. > minor issue in guc.c. > > set work_mem to '1kB'; > ERROR: 1 kB is outside the valid range for parameter "work_mem" (64 > .. 2147483647) > should it be > ERROR: 1 kB is outside the valid range for parameter "work_mem" (64 > kB ..

slightly misleading Error message in guc.c

hi. minor issue in guc.c. set work_mem to '1kB'; ERROR: 1 kB is outside the valid range for parameter "work_mem" (64 .. 2147483647) should it be ERROR: 1 kB is outside the valid range for parameter "work_mem" (64 kB .. 2147483647 kB) ? since the units for work_mem are { "B", "kB", "MB", "GB",