Re: some SCRAM read_any_attr() confusion

2019-08-21 Thread Peter Eisentraut
On 2019-08-17 14:57, Michael Paquier wrote: > On Sat, Aug 17, 2019 at 10:11:27AM +0200, Peter Eisentraut wrote: >> I was a bit confused by some of the comments around the SCRAM function >> read_any_attr(), used to skip over extensions. >> >> The comment "Returns NULL if there is attribute.",

Re: some SCRAM read_any_attr() confusion

2019-08-17 Thread Michael Paquier
On Sat, Aug 17, 2019 at 10:11:27AM +0200, Peter Eisentraut wrote: > I was a bit confused by some of the comments around the SCRAM function > read_any_attr(), used to skip over extensions. > > The comment "Returns NULL if there is attribute.", besides being > strangely worded, appears to be wrong

some SCRAM read_any_attr() confusion

2019-08-17 Thread Peter Eisentraut
I was a bit confused by some of the comments around the SCRAM function read_any_attr(), used to skip over extensions. The comment "Returns NULL if there is attribute.", besides being strangely worded, appears to be wrong anyway, because the function never returns NULL. This lead me to wonder how