Re: some last patches breaks plan cache

2018-04-05 21:01 GMT+02:00 Peter Eisentraut < peter.eisentr...@2ndquadrant.com>: > On 4/4/18 14:03, Tomas Vondra wrote: > >> If there's really no other way, you could use a PG_TRY block to > >> ensure that the pointer gets reset on the way out. But I question > >> why we've got a design that

Re: some last patches breaks plan cache

On 4/4/18 14:03, Tomas Vondra wrote: >> If there's really no other way, you could use a PG_TRY block to >> ensure that the pointer gets reset on the way out. But I question >> why we've got a design that requires that in the first place. It's >> likely to have more problems than this. > > I

Re: some last patches breaks plan cache

On 04/04/2018 07:54 PM, Tom Lane wrote: > Tomas Vondra writes: >> This should do the trick - I've failed to realize exec_stmt_call may >> exit by calling elog(ERROR) too, in which case the plan pointer was not >> reset. > >> This does fix the failures presented

Re: some last patches breaks plan cache

Tomas Vondra writes: > This should do the trick - I've failed to realize exec_stmt_call may > exit by calling elog(ERROR) too, in which case the plan pointer was not > reset. > This does fix the failures presented here, but I don't think it's the > right solution

Re: some last patches breaks plan cache

On 04/01/2018 10:01 AM, Pavel Stehule wrote: > > > 2018-04-01 1:00 GMT+02:00 Tomas Vondra >: > > > > On 03/31/2018 08:28 PM, Tomas Vondra wrote: > > > > > > On 03/31/2018 07:56 PM, Tomas Vondra wrote: >

Re: some last patches breaks plan cache

2018-04-01 1:00 GMT+02:00 Tomas Vondra : > > > On 03/31/2018 08:28 PM, Tomas Vondra wrote: > > > > > > On 03/31/2018 07:56 PM, Tomas Vondra wrote: > >> On 03/31/2018 07:38 PM, Pavel Stehule wrote: > >>> Hi > >>> > >>> CREATE OR REPLACE PROCEDURE public.proc(a

Re: some last patches breaks plan cache

On 03/31/2018 08:28 PM, Tomas Vondra wrote: > > > On 03/31/2018 07:56 PM, Tomas Vondra wrote: >> On 03/31/2018 07:38 PM, Pavel Stehule wrote: >>> Hi >>> >>> CREATE OR REPLACE PROCEDURE public.proc(a integer, INOUT b integer, c >>> integer) >>>  LANGUAGE plpgsql >>> AS $procedure$ >>> begin >>>

Re: some last patches breaks plan cache

On 03/31/2018 07:56 PM, Tomas Vondra wrote: > On 03/31/2018 07:38 PM, Pavel Stehule wrote: >> Hi >> >> CREATE OR REPLACE PROCEDURE public.proc(a integer, INOUT b integer, c >> integer) >>  LANGUAGE plpgsql >> AS $procedure$ >> begin >>   b := a + c; >> end; >> $procedure$ >> >> CREATE OR REPLACE

Re: some last patches breaks plan cache

On 03/31/2018 07:38 PM, Pavel Stehule wrote: > Hi > > CREATE OR REPLACE PROCEDURE public.proc(a integer, INOUT b integer, c > integer) >  LANGUAGE plpgsql > AS $procedure$ > begin >   b := a + c; > end; > $procedure$ > > CREATE OR REPLACE PROCEDURE public.testproc() >  LANGUAGE plpgsql > AS

some last patches breaks plan cache

Hi CREATE OR REPLACE PROCEDURE public.proc(a integer, INOUT b integer, c integer) LANGUAGE plpgsql AS $procedure$ begin b := a + c; end; $procedure$ CREATE OR REPLACE PROCEDURE public.testproc() LANGUAGE plpgsql AS $procedure$ declare r int; begin call proc(10, r, 20); end; $procedure$