Re: [HACKERS] WIP: default values for function parameters

2008-11-30 Thread Peter Eisentraut
On Thursday 27 November 2008 00:14:19 Pavel Stehule wrote: I am sending actualized versions - I accepted Tom's comments - default expressions are serialised List stored in text field. OK, this is looking pretty good. There is a structural problem that we need to address. With your patch,

Re: [HACKERS] WIP: default values for function parameters

2008-11-30 Thread Pavel Stehule
2008/11/30 Peter Eisentraut [EMAIL PROTECTED]: On Thursday 27 November 2008 00:14:19 Pavel Stehule wrote: I am sending actualized versions - I accepted Tom's comments - default expressions are serialised List stored in text field. OK, this is looking pretty good. There is a structural

Re: [HACKERS] WIP: default values for function parameters

2008-11-30 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: There are two ways to fix this, both having some validity: 1. We create a second version of pg_get_function_arguments() that produces arguments without default values decoration. This is probably the technically sound thing to do. Yes. I think

Re: [HACKERS] WIP: default values for function parameters

2008-11-30 Thread David E. Wheeler
On Nov 30, 2008, at 6:49 PM, Tom Lane wrote: Peter Eisentraut [EMAIL PROTECTED] writes: There are two ways to fix this, both having some validity: 1. We create a second version of pg_get_function_arguments() that produces arguments without default values decoration. This is probably the

Re: [HACKERS] Windowing Function Patch Review - Standard Conformance

2008-11-30 Thread David Rowley
-Original Message- From: Heikki Linnakangas [mailto:[EMAIL PROTECTED] Sent: 26 November 2008 09:09 To: Hitoshi Harada Cc: David Rowley; pgsql-hackers@postgresql.org Subject: Re: Windowing Function Patch Review - Standard Conformance Hitoshi Harada wrote: 2008/11/26 David Rowley

Re: [HACKERS] WIP: default values for function parameters

2008-11-30 Thread Pavel Stehule
2008/11/30 Tom Lane [EMAIL PROTECTED]: Peter Eisentraut [EMAIL PROTECTED] writes: There are two ways to fix this, both having some validity: 1. We create a second version of pg_get_function_arguments() that produces arguments without default values decoration. This is probably the

Re: [HACKERS] Windowing Function Patch Review - Standard Conformance

2008-11-30 Thread David Rowley
I wrote: I was also reading over the standard tonight. I've discovered that the OFFSET in LEAD() and LAG() is optional. It should default to 1 if it is not present. Oracle seems to support this. SQL2008 says: If lead or lag function is specified, then: i) Let VE1 be lead or lag extent

Re: [HACKERS] [COMMITTERS] pgsql: Remove inappropriate memory context switch in

2008-11-30 Thread Tom Lane
Neil Conway [EMAIL PROTECTED] writes: On Sun, Nov 30, 2008 at 1:09 PM, Tom Lane [EMAIL PROTECTED] wrote: Well, dblink is simply calling SRF_RETURN_DONE() when the current context is the multi-call memory context. So I see. We could outlaw that practice, but that risks breaking out-of-tree

[HACKERS] Problem in contrib/tablefunc's crosstab()

2008-11-30 Thread Tom Lane
While fooling with the recent contrib problem http://archives.postgresql.org/pgsql-committers/2008-11/msg00346.php I noticed another way that tablefunc.c is being cavalier about the state when it returns control: the crosstab() function returns with an internal SPI call still active! This is

Re: [HACKERS] Comments to Synchronous replication patch v3

2008-11-30 Thread Fujii Masao
Hi, thanks for the comment! On Sat, Nov 29, 2008 at 1:10 AM, Tom Lane [EMAIL PROTECTED] wrote: Fujii Masao [EMAIL PROTECTED] writes: You export replication_timeout as a PGC_USERSET variable, but it is dangerous. It allows non-superusers to kill servers easily by setting it too low value.

Re: [HACKERS] Simple postgresql.conf wizard

2008-11-30 Thread Greg Smith
On Tue, 18 Nov 2008, Josh Berkus wrote: Regarding the level of default_stats_target, it sounds like people agree that it ought to be raised for the DW use-case, but disagree how much. If that's the case, what if we compromize at 50 for mixed and 100 for DW? That's what I ended up doing.

Re: [HACKERS] Simple postgresql.conf wizard

2008-11-30 Thread Greg Smith
On Sun, 30 Nov 2008, Greg Smith wrote: Memory detection works on recent (=2.5) version of Python for Windows now. I just realized that the provided configuration is really not optimal for Windows users because of the known limitations that prevent larger shared_buffers settings from being

Re: [HACKERS] Server Crash into contrib module ISN into 64bit OS

2008-11-30 Thread Rushabh Lathia
I think we need to create ISBN type ( contrib/isn/isn.sql.in) with flag PASSBYVALUE flag when flag USE_FLOAT8_BYVAL is set. -Regards, Rushabh On Fri, Nov 28, 2008 at 10:29 PM, Tom Lane [EMAIL PROTECTED] wrote: Rushabh Lathia [EMAIL PROTECTED] writes: Following test end up with the server

Re: [HACKERS] Simple postgresql.conf wizard

2008-11-30 Thread Martijn van Oosterhout
On Sun, Nov 30, 2008 at 09:17:37PM -0500, Greg Smith wrote: That's what I ended up doing. The attached version of this script and its data files (I dumped all the useful bits in the current HEAD pg_settings for it to use) now hits all of the initial goals I had for a useful working tool

Re: [HACKERS] Simple postgresql.conf wizard

2008-11-30 Thread Greg Smith
On Mon, 1 Dec 2008, Martijn van Oosterhout wrote: Do you have a check somewhere to see if this exceeds the total SYSV memory allowed by the OS. Otherwise you've just output an unstartable config. The output of /sbin/sysctl should tell you. Something to address that is listed as the first