2009/7/24 Euler Taveira de Oliveira eu...@timbira.com:
Here is my review. The patch applied without problems. The docs and regression
tests are included. Both of them worked as expected. Also, you included a fix
in RN format, do it in another patch.
Well, I updated an error message for RN to
On Fri, Jul 24, 2009 at 2:23 AM, Magnus Hagandermag...@hagander.net wrote:
1) it introduces a dependency for -lpgport when compiling a client
that uses libpq
http://archives.postgresql.org/pgsql-hackers/2009-07/msg01511.php
For other parts of libpgport that are needed, we pull in the
On Tuesday 30 June 2009 06:59:51 Robert Haas wrote:
The attached patch merges all of the logic currently in genbki.sh and
Gen_fmgrtab.{sh,pl} into a single script called gen_catalog.pl. It
then extends that logic to generate all of the Anum_* and Natts_*
constants, as well as the Schema_pg_*
On Sat, Jul 25, 2009 at 02:24, Dave Pagedp...@pgadmin.org wrote:
On Fri, Jul 24, 2009 at 10:53 PM, Stephen Frostsfr...@snowman.net wrote:
Dave,
* Dave Page (dp...@pgadmin.org) wrote:
On Fri, Jul 24, 2009 at 10:35 PM, Stephen Frostsfr...@snowman.net wrote:
Do you need access to a Win64 box?
On Sat, Jul 25, 2009 at 9:18 AM, Magnus Hagandermag...@hagander.net wrote:
IIRC, there is no 64-bit support in VC++2005 Express. There is a
64-bit compiler in the SDK though, that can probably be made to work
with it. I think the official support for this (SDK compiler
integrated with VC++
On Sat, Jul 25, 2009 at 10:35, Dave Pagedp...@pgadmin.org wrote:
On Sat, Jul 25, 2009 at 9:18 AM, Magnus Hagandermag...@hagander.net wrote:
IIRC, there is no 64-bit support in VC++2005 Express. There is a
64-bit compiler in the SDK though, that can probably be made to work
with it. I think
Joshua Tolley wrote:
Am I the only one that gets this on make check, with this version (from
src/test/regress/log/initdb.log):
selecting default shared_buffers ... 32MB
creating configuration files ... ok
creating template1 database in
On Sat, Jul 25, 2009 at 3:21 AM, Peter Eisentrautpete...@gmx.net wrote:
On Tuesday 30 June 2009 06:59:51 Robert Haas wrote:
The attached patch merges all of the logic currently in genbki.sh and
Gen_fmgrtab.{sh,pl} into a single script called gen_catalog.pl. It
then extends that logic to
On Sat, Jul 25, 2009 at 10:43:05AM +0900, KaiGai Kohei wrote:
Sam Mason wrote:
This would seem to imply that all user defined trusted code has to
perform its own permission checks. How is MAC any different from DAC in
the presence of code such as:
CREATE OR REPLACE FUNCTION show_customers
Sam Mason wrote:
On Sat, Jul 25, 2009 at 10:43:05AM +0900, KaiGai Kohei wrote:
Sam Mason wrote:
This would seem to imply that all user defined trusted code has to
perform its own permission checks. How is MAC any different from DAC in
the presence of code such as:
CREATE OR REPLACE FUNCTION
When you run a file with psql -1/--single-transaction, and a command fails,
you get bombarded with
ERROR: current transaction is aborted, commands ignored until end of
transaction block
for the rest of the file.
Shouldn't -1 imply ON_ERROR_STOP or some variant by default?
--
Sent via
On Saturday, July 25, 2009, Peter Eisentraut pete...@gmx.net wrote:
When you run a file with psql -1/--single-transaction, and a command fails,
you get bombarded with
ERROR: current transaction is aborted, commands ignored until end of
transaction block
for the rest of the file.
That
On Sat, Jul 25, 2009 at 9:06 AM, Magnus Hagandermag...@hagander.net wrote:
On Saturday, July 25, 2009, Peter Eisentraut pete...@gmx.net wrote:
When you run a file with psql -1/--single-transaction, and a command fails,
you get bombarded with
ERROR: current transaction is aborted, commands
On Fri, Jul 24, 2009 at 11:40 PM, Pavel Stehulepavel.steh...@gmail.com wrote:
Hello
I have one idea, that should simplify string to char array
transformation. The base is idea: between every char is empty string,
so empty string is regular separator for string_to_array function.
This behave
2009/7/25 Merlin Moncure mmonc...@gmail.com:
On Fri, Jul 24, 2009 at 11:40 PM, Pavel Stehulepavel.steh...@gmail.com
wrote:
Hello
I have one idea, that should simplify string to char array
transformation. The base is idea: between every char is empty string,
so empty string is regular
Robert Haas robertmh...@gmail.com writes:
On Sat, Jul 25, 2009 at 3:21 AM, Peter Eisentrautpete...@gmx.net wrote:
I think a less invasive change would be to include anum.h into all the
catalog/pg_*.h headers, so that the external interface stays the same.
Gah. I wish a toplevel make would
Sam Mason s...@samason.me.uk writes:
Yes, that seems reasonable. The fact that you're still talking about
confined users is slightly worrying and would seem to imply that
there is still a superuser/normal user divide--it's probably just a
terminology thing though.
There had better still be
Robert Haas robertmh...@gmail.com writes:
On Fri, Jul 24, 2009 at 7:21 PM, Tom Lanet...@sss.pgh.pa.us wrote:
I think you should just submit this with the code that uses it, so we
can evaluate whether the overall concept is a good one or not.
This was split out from Synch Rep based on my
On Jul 25, 2009, at 11:06 AM, Tom Lane wrote:
Sam Mason s...@samason.me.uk writes:
Yes, that seems reasonable. The fact that you're still talking about
confined users is slightly worrying and would seem to imply that
there is still a superuser/normal user divide--it's probably just a
David E. Wheeler da...@kineticode.com wrote:
So when it gets to that second row in the first cursor, it doesn't
know it's a row with NULLs as opposed to an empty row.
there ought to be an easy way to tell the difference. :-(
I would have thought that the correct thing is to check
On Fri, 2009-07-24 at 15:47 -0700, David E. Wheeler wrote:
WHILE (NOT rec_have IS NULL AND rec_have IS DISTINCT FROM NULL)
OR (NOT rec_want IS NULL AND rec_want IS DISTINCT FROM NULL)
I don't think you want the NOT x IS NULL part at all -- that will
evaluate to false when x =
Sam Mason s...@samason.me.uk wrote:
On Fri, Jul 24, 2009 at 12:30:39PM -0500, Kevin Grittner wrote:
In this dichotomy a NULL is most definitely a value and with my
current experience I don't understand the distinction you're trying
to draw.
There can be a place where a value *could* go
Am 25.07.2009 um 15:00 schrieb Peter Eisentraut:
When you run a file with psql -1/--single-transaction, and a command
fails,
you get bombarded with
ERROR: current transaction is aborted, commands ignored until end of
transaction block
for the rest of the file.
Shouldn't -1 imply
Pavel Stehule pavel.steh...@gmail.com writes:
I have one idea, that should simplify string to char array
transformation. The base is idea: between every char is empty string,
so empty string is regular separator for string_to_array function.
There already is a definition for what
m...@postgresql.org (Magnus Hagander) writes:
Log Message:
---
Reserve the shared memory region during backend startup on Windows, so
that memory allocated by starting third party DLLs doesn't end up
conflicting with it.
I am wondering why failure of the various TerminateProcess
2009/7/25 Tom Lane t...@sss.pgh.pa.us:
Pavel Stehule pavel.steh...@gmail.com writes:
I have one idea, that should simplify string to char array
transformation. The base is idea: between every char is empty string,
so empty string is regular separator for string_to_array function.
There
Pavel Stehule pavel.steh...@gmail.com writes:
2009/7/25 Tom Lane t...@sss.pgh.pa.us:
There already is a definition for what string_to_array does with an
empty field separator, and that is not it.
I thing, so nobody use empty separator in string_to_array, because it
does nothing useful.
Hello,
fixed patch attached + more regress tests.
Regards
Pavel Stehule
2009/7/23 Pavel Stehule pavel.steh...@gmail.com:
2009/7/23 Bernd Helmle maili...@oopsware.de:
--On Donnerstag, März 05, 2009 08:41:28 +0100 Pavel Stehule
pavel.steh...@gmail.com wrote:
Hello
I did some cleaning on
On Sun, Jul 5, 2009 at 7:23 PM, Greg Starkst...@mit.edu wrote:
Here's a copy of the merge-append patch that I sent months ago merged up to
head. I haven't really added any additional functionality since then.
Can you provide some more details about the objective of this patch? Or a
link to
On Sat, Jul 25, 2009 at 11:14:19AM +0200, Petr Jelinek wrote:
Joshua Tolley wrote:
Am I the only one that gets this on make check, with this version (from
src/test/regress/log/initdb.log):
selecting default shared_buffers ... 32MB
creating configuration files ... ok
creating template1
On Sat, Jul 25, 2009 at 8:12 PM, Jaime
Casanovajcasa...@systemguards.com.ec wrote:
i was trying to test this one but i can't find a query that produces a
diferent plan than in 8.4.0, attached my current test just in case...
what kind of query is this intended to help?
You may have to disable
Joshua Tolley wrote:
I figured as much. I can't seem to get past this, despite a make distclean.
Suggestions, anyone?
try a fresh checkout and reapply the patch?
cheers
andrew
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
On Sat, Jul 25, 2009 at 2:26 PM, Greg Starkst...@mit.edu wrote:
more complex examples would trigger it naturally such as:
select * from partitioned_table where active order by indexed_column
(with an index on indexed_column where active)
or
select * from partitioned_table where
On Sat, Jul 25, 2009 at 09:50:08PM +0900, KaiGai Kohei wrote:
Sorry for using the undefined terminology.
I think this is the largest missing part of the docs at the moment;
there is a whole new world of definitions that need to be understood
before the SE-PG stuff is understandable/usable by
On Sat, Jul 25, 2009 at 10:56 AM, Tom Lanet...@sss.pgh.pa.us wrote:
Robert Haas robertmh...@gmail.com writes:
On Sat, Jul 25, 2009 at 3:21 AM, Peter Eisentrautpete...@gmx.net wrote:
I think a less invasive change would be to include anum.h into all the
catalog/pg_*.h headers, so that the
On Sat, Jul 25, 2009 at 11:06:37AM -0400, Tom Lane wrote:
There had better still be superusers. Or do you want the correctness
of your backups to depend on whether your SELinux policy is correct?
I thought the whole point of MAC was that superusers don't exist any
more--at least not with the
On Sat, Jul 25, 2009 at 4:27 PM, Sam Masons...@samason.me.uk wrote:
On Sat, Jul 25, 2009 at 11:06:37AM -0400, Tom Lane wrote:
There had better still be superusers. Or do you want the correctness
of your backups to depend on whether your SELinux policy is correct?
I thought the whole point of
--On Samstag, Juli 25, 2009 16:00:18 +0300 Peter Eisentraut
pete...@gmx.net wrote:
When you run a file with psql -1/--single-transaction, and a command
fails, you get bombarded with
ERROR: current transaction is aborted, commands ignored until end of
transaction block
for the rest of the
On Mon, Apr 20, 2009 at 8:45 AM, Pavel Stehulepavel.steh...@gmail.com wrote:
2009/4/18 Tom Lane t...@sss.pgh.pa.us:
Pavel Stehule pavel.steh...@gmail.com writes:
2009/4/11 Tom Lane t...@sss.pgh.pa.us:
No, I was complaining that a hook right there is useless and expensive.
transformExpr() is
On Wed, Jun 24, 2009 at 4:51 AM, Boszormenyi Zoltanz...@cybertec.at wrote:
Hi,
attached is our latest patch extending ECPG:
haven't tested this nor reviewed the code in detail, just some little questions:
1) This is in /src/interfaces/ecpg/ecpglib/sqlda.c, and doesn't seems
something we want
Robert Haas robertmh...@gmail.com writes:
On Sat, Jul 25, 2009 at 10:56 AM, Tom Lanet...@sss.pgh.pa.us wrote:
I didn't realize this change was intending to throw all the Anum_
constants into a single header file. I am strongly against that
on namespace pollution grounds,
I don't really
On Sat, Jul 25, 2009 at 4:38 PM, Jaime
Casanovajcasa...@systemguards.com.ec wrote:
On Wed, Jun 24, 2009 at 4:51 AM, Boszormenyi Zoltanz...@cybertec.at wrote:
Hi,
attached is our latest patch extending ECPG:
haven't tested this nor reviewed the code in detail, just some little
questions:
On Sat, Jul 25, 2009 at 11:41 AM, Tom Lanet...@sss.pgh.pa.us wrote:
Robert Haas robertmh...@gmail.com writes:
On Fri, Jul 24, 2009 at 7:21 PM, Tom Lanet...@sss.pgh.pa.us wrote:
I think you should just submit this with the code that uses it, so we
can evaluate whether the overall concept is a
On Tue, Jul 21, 2009 at 2:37 AM, Pavan Deolaseepavan.deola...@gmail.com wrote:
On Tue, Jul 21, 2009 at 10:38 AM, Robert Haasrobertmh...@gmail.com wrote:
Pavan, are you planning to respond to Alex's comments and/or update this
patch?
Yes, I will. Hopefully by end of this week.
Since it has
On Sat, Jul 25, 2009 at 9:17 PM, Robert Haasrobertmh...@gmail.com wrote:
Of course, fixing the Anum and
Natts declarations does not come close to fixing this problem: for
catalogs that are initialized with any data at bootstrap time, the
DATA() lines are a much bigger issue, but fixing that is
Robert Haas robertmh...@gmail.com writes:
I think we should apply the same criteria to this that we
have to some other patches that have been rejected (like the
extensible-rmgr patch Simon submitted for CommitFest 2008-11), namely,
requiring that the extension mechanism be submitted together
Greg Stark gsst...@mit.edu writes:
Move a lot of those DATA lines to SQL initdb scripts. Virtually all of
pg_proc, pg_operator, pg_opclass, pg_opfamily, pg_cast, etc can be
initialized using SQL. Hardly any of the records in there are needed
for bootstrapping.
It's easy to make that claim,
[ dept. of second thoughts ]
I wrote:
It's easy to make that claim, much less easy to actually do it.
Reflecting on this a bit more ... it seems to me that it's not the right
thing to set the goal as try to get rid of as many DATA statements as
possible. The right way to think about this is to
On Jul 25, 2009, at 9:24 AM, Jeff Davis wrote:
I don't think you want the NOT x IS NULL part at all -- that will
evaluate to false when x = rec(NULL,NULL). I think you just want the
x
IS DISTINCT FROM NULL part, right? Will that work?
Nope, infinite loop when because `ROW(null, null)` and
On Jul 25, 2009, at 9:42 AM, Kevin Grittner wrote:
I know that Codd was insistent that any relation (which included the
result of any query) which could contain duplicate rows should be
called a corrupted relation. (In fact, in one of his books I think
he averaged a comment on this point about
On Sat, Jul 25, 2009 at 03:50:06PM -0400, Andrew Dunstan wrote:
Joshua Tolley wrote:
I figured as much. I can't seem to get past this, despite a make distclean.
Suggestions, anyone?
try a fresh checkout and reapply the patch?
[ a couple git clean, git reset, make clean, etc. commands
On Sat, Jul 25, 2009 at 04:39:29PM -0400, Robert Haas wrote:
On Sat, Jul 25, 2009 at 4:27 PM, Sam Masons...@samason.me.uk wrote:
I thought the whole point of MAC was that superusers don't exist any
more--at least not with the power they currently do.
It's been billed that way, but it's not
On Sat, Jul 25, 2009 at 7:45 PM, Joshua Tolleyeggyk...@gmail.com wrote:
that I wouldn't know what I was talking about. In the meantime, I think this
one is ready to be marked as ... something else. Ready for committer?
Sounds right to me.
...Robert
--
Sent via pgsql-hackers mailing list
On Sun, Jul 19, 2009 at 06:13:32PM +0200, Petr Jelinek wrote:
while writing some basic docs I found bug in dependency handling when
doing SET on object type that already had some default privileges.
Attached patch fixes it, it also fixes thinko in parser (DROPing GRANT
OPTION behaves
On Sat, Jul 25, 2009 at 11:42:04AM -0500, Kevin Grittner wrote:
Sam Mason s...@samason.me.uk wrote:
In this dichotomy a NULL is most definitely a value and with my
current experience I don't understand the distinction you're trying
to draw.
There can be a place where a value *could* go
On Sat, Jul 25, 2009 at 8:39 PM, Joshua Tolleyeggyk...@gmail.com wrote:
On Sun, Jul 19, 2009 at 06:13:32PM +0200, Petr Jelinek wrote:
while writing some basic docs I found bug in dependency handling when
doing SET on object type that already had some default privileges.
Attached patch fixes
On Sat, Jul 25, 2009 at 08:41:12PM -0400, Robert Haas wrote:
On Sat, Jul 25, 2009 at 8:39 PM, Joshua Tolleyeggyk...@gmail.com wrote:
On Sun, Jul 19, 2009 at 06:13:32PM +0200, Petr Jelinek wrote:
while writing some basic docs I found bug in dependency handling when
doing SET on object type
All,
A few hours ago I assigned a reviewer to the last patch for this
CommitFest which still lacked one, with the exception of Heikki's
index-only quals patch, which I'm not sure can be reviewed at this
point because it depends on the indexam API changes patch, which is
still up in the air. One
On Sat, Jul 25, 2009 at 6:40 PM, Tom Lanet...@sss.pgh.pa.us wrote:
I'm not nearly as excited about migrating all or even most of, say,
the pg_proc DATA lines into SQL. That simply isn't going to buy very
much in maintainability --- a patch that wants to add a new property
to all the functions
Hi Sergey,
On Tuesday 14 July 2009 21:35:28 Sergey V. Karpov wrote:
attached is a simple patch that extends the functionality of dict_xsyn
extended synonym dictionary (from contrib) by adding the following
configuration option:
- mode option controls the current dictionary mode of operation.
Sam Mason wrote:
On Sat, Jul 25, 2009 at 09:50:08PM +0900, KaiGai Kohei wrote:
Sorry for using the undefined terminology.
I think this is the largest missing part of the docs at the moment;
there is a whole new world of definitions that need to be understood
before the SE-PG stuff is
On Sat, Jul 25, 2009 at 11:27 PM, KaiGai Koheikai...@kaigai.gr.jp wrote:
| Access control is conceptually to decide a set of allowed (or denied)
| actions between a certain subject (such as a database client) and an
| object (such as a table), and to apply the decision on user's requests.
| At
Hello
2009/7/25 Robert Haas robertmh...@gmail.com:
On Mon, Apr 20, 2009 at 8:45 AM, Pavel Stehulepavel.steh...@gmail.com wrote:
2009/4/18 Tom Lane t...@sss.pgh.pa.us:
Pavel Stehule pavel.steh...@gmail.com writes:
2009/4/11 Tom Lane t...@sss.pgh.pa.us:
No, I was complaining that a hook right
Robert Haas wrote:
On Sat, Jul 25, 2009 at 11:27 PM, KaiGai Koheikai...@kaigai.gr.jp wrote:
| Access control is conceptually to decide a set of allowed (or denied)
| actions between a certain subject (such as a database client) and an
| object (such as a table), and to apply the decision on
On Sat, Jul 25, 2009 at 7:49 PM, Sam Masons...@samason.me.uk wrote:
On Sat, Jul 25, 2009 at 04:39:29PM -0400, Robert Haas wrote:
On Sat, Jul 25, 2009 at 4:27 PM, Sam Masons...@samason.me.uk wrote:
I thought the whole point of MAC was that superusers don't exist any
more--at least not with
On Sat, Jul 25, 2009 at 11:38 PM, Pavel Stehulepavel.steh...@gmail.com wrote:
Hello
2009/7/25 Robert Haas robertmh...@gmail.com:
On Mon, Apr 20, 2009 at 8:45 AM, Pavel Stehulepavel.steh...@gmail.com
wrote:
2009/4/18 Tom Lane t...@sss.pgh.pa.us:
Pavel Stehule pavel.steh...@gmail.com writes:
Hi,
I sending a little bit modified version - I removed my forgotten
comment in gram.y
Regards
Pavel
2009/7/25 Pavel Stehule pavel.steh...@gmail.com:
Hello,
fixed patch attached + more regress tests.
Regards
Pavel Stehule
2009/7/23 Pavel Stehule pavel.steh...@gmail.com:
2009/7/23
Sam Mason wrote:
On Sat, Jul 25, 2009 at 04:39:29PM -0400, Robert Haas wrote:
On Sat, Jul 25, 2009 at 4:27 PM, Sam Masons...@samason.me.uk wrote:
I thought the whole point of MAC was that superusers don't exist any
more--at least not with the power they currently do.
It's been billed that
Robert Haas wrote:
If superusers DON'T exist, that would be making the opposite
statement, namely, that there isn't ANY WAY to get a backup that you
can be sure DOES contain all of the objects.
The traditional approach would be to maintain multiple physically
separate databases; in this setup
69 matches
Mail list logo
