Re: [HACKERS] Rejecting weak passwords

2009-09-29 Thread Albe Laurenz
Tom Lane wrote: pgAdmin MD5's the passwords if you use the GUI to change them, or when add a user. It doesn't make any attempt to parse the SQL if you enter it yourself in the query tool though (nor is it going to). No, I wouldn't expect it to go that far. My point is just that

Re: [HACKERS] Small patch for README

2009-09-29 Thread Heikki Linnakangas
Devrim GÜNDÜZ wrote: ! Ruby - http://pqxx.org/development/libpqxx/ I see no mention of Ruby on that page. Was that supposed to point somewhere else? -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] [PATCH] DefaultACLs

2009-09-29 Thread Petr Jelinek
Tom Lane napsal(a): I thought we were trying to keep this solution as simple as possible. It's meant to be a simple feature for simple use cases. I know we all love making stuff as ornate and complex as possible around here, but that kind of defeats the purpose of having DefaultACLs, as well as

Re: [HACKERS] [PATCH] DefaultACLs

2009-09-29 Thread Petr Jelinek
Stephen Frost napsal(a): * Robert Haas (robertmh...@gmail.com) wrote: One potential trouble spot is that presumably the built-in default privileges (eg, PUBLIC EXECUTE for functions) would *not* cumulate with user-specified defaults. Why not? How would you have a default that

Re: [HACKERS] pg_hba.conf: samehost and samenet [REVIEW]

2009-09-29 Thread Dave Page
On Mon, Sep 28, 2009 at 10:10 PM, Stef Walter stef-l...@memberwebs.com wrote:  * Win32 using win_wsa2.dll I assume you mean ws2_32.dll? -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] [PATCH] DefaultACLs

2009-09-29 Thread Petr Jelinek
Tom Lane napsal(a): Especially since we're doing GRANT ALL ON at the same time. That's another patch that has an *excellent* chance of getting rejected on pretty much the same grounds. I don't really see how this applies to GRANT ON ALL. You don't have to predict future there so if

Re: [HACKERS] Small patch for README

2009-09-29 Thread Devrim GÜNDÜZ
On Tue, 2009-09-29 at 09:54 +0300, Heikki Linnakangas wrote: Devrim GÜNDÜZ wrote: ! Ruby - http://pqxx.org/development/libpqxx/ I see no mention of Ruby on that page. Was that supposed to point somewhere else? Copy-paste is evil. It should be: http://rubyforge.org/projects/ruby-pg

Re: [HACKERS] Small patch for README

2009-09-29 Thread Heikki Linnakangas
Devrim GÜNDÜZ wrote: On Tue, 2009-09-29 at 09:54 +0300, Heikki Linnakangas wrote: Devrim GÜNDÜZ wrote: ! Ruby - http://pqxx.org/development/libpqxx/ I see no mention of Ruby on that page. Was that supposed to point somewhere else? Copy-paste is evil. It should be:

Re: [HACKERS] [PATCH] Reworks for Access Control facilities (r2311)

2009-09-29 Thread Stephen Frost
* KaiGai Kohei (kai...@ak.jp.nec.com) wrote: Could you post any review comments, even if it is not comprehensive yet? In general, you don't need to preface your comments with 'MEMO:'. I would encourage removing that. You might use 'FIXME:' instead, if it is something which needs to be

Re: [HACKERS] [PATCH] Reworks for Access Control facilities (r2311)

2009-09-29 Thread KaiGai Kohei
Stephen, thanks for your comments. Stephen Frost wrote: * KaiGai Kohei (kai...@ak.jp.nec.com) wrote: Could you post any review comments, even if it is not comprehensive yet? In general, you don't need to preface your comments with 'MEMO:'. I would encourage removing that. You might use

Re: [HACKERS] TODO item: Allow more complex user/database default GUC settings

2009-09-29 Thread Bernd Helmle
--On 28. September 2009 19:02:34 -0400 Alvaro Herrera alvhe...@commandprompt.com wrote: Seems Alvaro forgot to include pg_db_role_setting.h, it doesn't compile anymore with this error: Here they are. I'll see if i can get to it tonight. I'm currently travelling, so it could be delayed

Re: [HACKERS] Rejecting weak passwords

2009-09-29 Thread Peter Eisentraut
On Mon, 2009-09-28 at 15:59 -0700, Joshua D. Drake wrote: On Mon, 2009-09-28 at 15:52 -0700, Josh Berkus wrote: It takes about 32 hours to brute force all passwords from [a-zA-Z0-9] of up to 8 chars in length. That would be a reason to limit the number of failed connection attempts

Re: [HACKERS] Small patch for README

2009-09-29 Thread Magnus Hagander
2009/9/29 Heikki Linnakangas heikki.linnakan...@enterprisedb.com: Devrim GÜNDÜZ wrote: On Tue, 2009-09-29 at 09:54 +0300, Heikki Linnakangas wrote: Devrim GÜNDÜZ wrote: ! Ruby - http://pqxx.org/development/libpqxx/ I see no mention of Ruby on that page. Was that supposed to point somewhere

Re: [HACKERS] Rejecting weak passwords

2009-09-29 Thread Gurjeet Singh
On Tue, Sep 29, 2009 at 4:49 AM, Tom Lane t...@sss.pgh.pa.us wrote: Josh Berkus j...@agliodbs.com writes: Hmmm, that would be a useful, easy (I think) security feature: add a GUC for failed_logins_allowed. And the counts would be tracked and enforced where? Combining this with other

Re: [HACKERS] [PATCH] DefaultACLs

2009-09-29 Thread Robert Haas
On Mon, Sep 28, 2009 at 11:47 PM, Stephen Frost sfr...@snowman.net wrote: * Robert Haas (robertmh...@gmail.com) wrote: One potential trouble spot is that presumably the built-in default privileges (eg, PUBLIC EXECUTE for functions) would *not* cumulate with user-specified defaults. Why

Re: [HACKERS] [PATCH] Reworks for Access Control facilities (r2311)

2009-09-29 Thread Robert Haas
On Tue, Sep 29, 2009 at 6:54 AM, Stephen Frost sfr...@snowman.net wrote: * KaiGai Kohei (kai...@ak.jp.nec.com) wrote: Could you post any review comments, even if it is not comprehensive yet? In general, you don't need to preface your comments with 'MEMO:'.  I would encourage removing that.  

Re: [HACKERS] Rejecting weak passwords

2009-09-29 Thread Tom Lane
Albe Laurenz laurenz.a...@wien.gv.at writes: I thought about it some more, and I think that a password checking hook might still be somewhat useful even for MD5-encrypted passwords; the function could guess and exclude at least that dreadful all-too-frequent case of username = password. True.

Re: [HACKERS] [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server

2009-09-29 Thread Jim Cox
On Tue, Sep 29, 2009 at 12:00 AM, Alvaro Herrera alvhe...@commandprompt.com wrote: Jim Cox escribió: Attached s/b a patch for the 8.5 TODO Add comments to output indicating version of pg_dump and of the database server (pg_dump/pg_restore section, 9.2). Hmm, what happens if you do a

Re: [HACKERS] pg_hba.conf: samehost and samenet [REVIEW]

2009-09-29 Thread Stef Walter
Dave Page wrote: On Mon, Sep 28, 2009 at 10:10 PM, Stef Walter stef-l...@memberwebs.com wrote: * Win32 using win_wsa2.dll I assume you mean ws2_32.dll? Yes. I get dyslexic around windows DLLs. :) Stef -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Rejecting weak passwords

2009-09-29 Thread Robert Haas
On Tue, Sep 29, 2009 at 9:48 AM, Tom Lane t...@sss.pgh.pa.us wrote: Albe Laurenz laurenz.a...@wien.gv.at writes: I thought about it some more, and I think that a password checking hook might still be somewhat useful even for MD5-encrypted passwords; the function could guess and exclude at

Re: [HACKERS] Unicode UTF-8 table formatting for psql text output

2009-09-29 Thread Peter Eisentraut
On Mon, 2009-09-28 at 20:49 -0700, Brad T. Sliger wrote: During this review I found that `gmake check` will fail when LANG=en_US.UTF-8 in the environment. In this case the patched psql produces UTF8 line art and the tests expect ASCII line art. pg_regress clears LC_ALL by default,

Re: [HACKERS] Rejecting weak passwords

2009-09-29 Thread Andrew Dunstan
Robert Haas wrote: On Tue, Sep 29, 2009 at 9:48 AM, Tom Lane t...@sss.pgh.pa.us wrote: Albe Laurenz laurenz.a...@wien.gv.at writes: I thought about it some more, and I think that a password checking hook might still be somewhat useful even for MD5-encrypted passwords; the function

Re: [HACKERS] Rejecting weak passwords

2009-09-29 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: But how much value is there in that? This whole thing seems like a dead end to me. No matter how long you're willing to wait, putting the checking on the client side will let you far more validation for the same price. No doubt, but ... The value

Re: [HACKERS] [PATCH] DefaultACLs

2009-09-29 Thread Petr Jelinek
Robert Haas napsal(a): On Mon, Sep 28, 2009 at 11:47 PM, Stephen Frost sfr...@snowman.net wrote: * Robert Haas (robertmh...@gmail.com) wrote: One potential trouble spot is that presumably the built-in default privileges (eg, PUBLIC EXECUTE for functions) would *not* cumulate with

Re: [HACKERS] Rejecting weak passwords

2009-09-29 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: Why do we need to answer that question? If all we do is provide a hook, the cost is very low, and the decision on value is left to whoever is deploying some module to use the hook. Right. As long as it's just a hook, it's not enough work to justify

Re: [HACKERS] [PATCH] DefaultACLs

2009-09-29 Thread Tom Lane
Petr Jelinek pjmo...@pjmodos.net writes: That's how it works now actually, the problem is that when you grant something in the chain you can't revoke it anywhere else in the chain when you are merging privileges as you proposed. To allow that, you have to have some notion of a priority order

Re: [HACKERS] navigation menu for documents

2009-09-29 Thread Alvaro Herrera
Did this go anywhere? Richard Huxton wrote: OK, if you untar the attached in the docs dir there are a three separate sets of changes in it. It all functions, but consider it a discussion point rather than a patch. Presumably we'd need to discuss a patch over on the docs mailing-list. 1.

Re: [HACKERS] Using results from INSERT ... RETURNING

2009-09-29 Thread Alvaro Herrera
Marko Tiikkaja escribió: Robert Haas wrote: So I think we should at a minimum ask the patch author to (1) fix the explain bugs I found and (2) update the README, as well as (3) revert needless whitespace changes - there are a couple in execMain.c, from the looks of it. In the attached

Re: [HACKERS] [PATCH] DefaultACLs

2009-09-29 Thread Robert Haas
On Tue, Sep 29, 2009 at 11:05 AM, Tom Lane t...@sss.pgh.pa.us wrote: Petr Jelinek pjmo...@pjmodos.net writes: That's how it works now actually, the problem is that when you grant something in the chain you can't revoke it anywhere else in the chain when you are merging privileges as you

Re: [HACKERS] navigation menu for documents

2009-09-29 Thread Andrew Dunstan
Alvaro Herrera wrote: Did this go anywhere? Well, it was sorta nice but what Richard sent wasn't really what I want, at least, which is more along the lines of the menu David Wheeler uses for the Bricolage API docs. cheers andrew -- Sent via pgsql-hackers mailing list

Re: [HACKERS] [PATCH] DefaultACLs

2009-09-29 Thread Petr Jelinek
Tom Lane napsal(a): Petr Jelinek pjmo...@pjmodos.net writes: That's how it works now actually, the problem is that when you grant something in the chain you can't revoke it anywhere else in the chain when you are merging privileges as you proposed. To allow that, you have to have

Re: [HACKERS] Using results from INSERT ... RETURNING

2009-09-29 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: BTW what was the conclusion of the idea about having three separate nodes Insert, Delete, Update instead of a single Dml node? If we stick with a single node type then I'd suggest calling it something like ModifyTable.

Re: [HACKERS] navigation menu for documents

2009-09-29 Thread Richard Huxton
Andrew Dunstan wrote: Alvaro Herrera wrote: Did this go anywhere? Well, it was sorta nice but what Richard sent wasn't really what I want, at least, which is more along the lines of the menu David Wheeler uses for the Bricolage API docs. Well, if we nail down the details I'm happy to

Re: [HACKERS] Unicode UTF-8 table formatting for psql text output

2009-09-29 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On Mon, 2009-09-28 at 20:49 -0700, Brad T. Sliger wrote: pg_regress clears LC_ALL by default, but does not clear LANG by default. Please find attached a patch that causes pg_regress to also clear LANG by default. It probably doesn't matter much, but

Re: [HACKERS] [PATCH] DefaultACLs

2009-09-29 Thread Josh Berkus
Tom, Hmm ... interesting proposal. Simple to understand and simple to implement, which are both to the good. I'm not clear though on whether this behavior would be useful in practice. Any comments from those who've been asking for default ACLs? I'd be fine with it. My goals here are to

[HACKERS] Postgres server goes in recovery mode repeteadly

2009-09-29 Thread kunal sharma
Hi , We are using Postgres 8.4 and its been found going into recovery mode couple of times. The server process seems to fork another child process which is another postgres server running under same data directory and after some time it goes away while the old server is still running.

Re: [HACKERS] Postgres server goes in recovery mode repeteadly

2009-09-29 Thread Andrew Dunstan
kunal sharma wrote: Hi , We are using Postgres 8.4 and its been found going into recovery mode couple of times. The server process seems to fork another child process which is another postgres server running under same data directory and after some time it goes away while the old

Re: [HACKERS] [ADMIN] Postgres server goes in recovery mode repeteadly

2009-09-29 Thread Tom Lane
kunal sharma ksharma.li...@gmail.com writes: We are using Postgres 8.4 and its been found going into recovery 8.4.what? (If not 8.4.1, an update would be the first thing to try.) Checking the logs I found that theres a segmentation fault , Sep 26 05:39:54 pace kernel:

Re: [HACKERS] Using results from INSERT ... RETURNING

2009-09-29 Thread Robert Haas
On Tue, Sep 29, 2009 at 11:29 AM, Alvaro Herrera alvhe...@commandprompt.com wrote: Marko Tiikkaja escribió: Robert Haas wrote: So I think we should at a minimum ask the patch author to (1) fix the explain bugs I found and (2) update the README, as well as (3) revert needless whitespace

Re: [HACKERS] Postgres server goes in recovery mode repeteadly

2009-09-29 Thread kunal sharma
gdb backtrce- (gdb) bt full #0 0x2ad6d7b8c2b3 in __select_nocancel () from /lib64/libc.so.6 No symbol table info available. #1 0x005a39bc in ServerLoop () at postmaster.c:1304 timeout = {tv_sec = 55, tv_usec = 352000} rmask = {fds_bits = {24, 0 repeats 15 times}}

Re: [HACKERS] Using results from INSERT ... RETURNING

2009-09-29 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Tue, Sep 29, 2009 at 11:29 AM, Alvaro Herrera alvhe...@commandprompt.com wrote: BTW what was the conclusion of the idea about having three separate nodes Insert, Delete, Update instead of a single Dml node? It wasn't obvious from reading the patch

Re: [HACKERS] navigation menu for documents

2009-09-29 Thread David E. Wheeler
On Sep 29, 2009, at 8:55 AM, Richard Huxton wrote: For the browser, does the following match what you're after, Andrew? - clicking chapter title opens the browser panel - panel stays open until you click close icon - panel contains collapsable tree of chapter/section headings Alternatively,

Re: [HACKERS] Rejecting weak passwords

2009-09-29 Thread Mark Mielke
On 09/29/2009 09:07 AM, Gurjeet Singh wrote: On Tue, Sep 29, 2009 at 4:49 AM, Tom Lane t...@sss.pgh.pa.us mailto:t...@sss.pgh.pa.us wrote: Josh Berkus j...@agliodbs.com mailto:j...@agliodbs.com writes: Hmmm, that would be a useful, easy (I think) security feature: add a GUC

Re: [ADMIN] [HACKERS] Postgres server goes in recovery mode repeteadly

2009-09-29 Thread Tom Lane
kunal sharma ksharma.li...@gmail.com writes: gdb backtrce- (gdb) bt full #0 0x2ad6d7b8c2b3 in __select_nocancel () from /lib64/libc.so.6 No symbol table info available. #1 0x005a39bc in ServerLoop () at postmaster.c:1304 timeout = {tv_sec = 55, tv_usec = 352000} I

Re: [HACKERS] Rejecting weak passwords

2009-09-29 Thread Josh Berkus
Mark, I read Josh's original suggestion to eventually evolve to if a particular user account from a particular IP address uses the wrong password more than N times in T minutes, than the IP address is locked out for U minutes. This is the *only* way of significantly reducing the ability of a

Re: [HACKERS] Unicode UTF-8 table formatting for psql text output

2009-09-29 Thread Roger Leigh
On Tue, Sep 29, 2009 at 12:01:30PM -0400, Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: On Mon, 2009-09-28 at 20:49 -0700, Brad T. Sliger wrote: pg_regress clears LC_ALL by default, but does not clear LANG by default. Please find attached a patch that causes pg_regress to

Re: [HACKERS] [PATCH] Reworks for Access Control facilities (r2311)

2009-09-29 Thread Stephen Frost
* KaiGai Kohei (kai...@kaigai.gr.jp) wrote: Stephen Frost wrote: You might also provide a specific example of where and why this check matters. I'm not entirely convinced it's necessary or makes sense, to be honest.. By the default, it is 100% correct to omit checks here. But it can

Re: [HACKERS] Unicode UTF-8 table formatting for psql text output

2009-09-29 Thread Tom Lane
Roger Leigh rle...@codelibre.net writes: In Debian, we do have plans to introduce a C.UTF-8 locale, Egad, isn't that a contradiction in terms? C locale means POSIX behavior and nothing but. regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Unicode UTF-8 table formatting for psql text output

2009-09-29 Thread Roger Leigh
On Tue, Sep 29, 2009 at 01:41:27PM -0400, Tom Lane wrote: Roger Leigh rle...@codelibre.net writes: In Debian, we do have plans to introduce a C.UTF-8 locale, Egad, isn't that a contradiction in terms? Not entirely! C locale means POSIX behavior and nothing but. Indeed it does. However,

Re: [HACKERS] CREATE LIKE INCLUDING COMMENTS and STORAGES

2009-09-29 Thread Alvaro Herrera
Itagaki Takahiro escribió: I removed hunks by sql_help.c and fix a typo in documentation. An updated patch attached. Hmm, so it works to specify LIKE t1 INCLUDING COMMENTS EXCLUDING COMMENTS? -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL

Re: [HACKERS] Rejecting weak passwords

2009-09-29 Thread Mark Mielke
On 09/29/2009 12:54 PM, Josh Berkus wrote: I read Josh's original suggestion to eventually evolve to if a particular user account from a particular IP address uses the wrong password more than N times in T minutes, than the IP address is locked out for U minutes. This is the *only* way of

Re: [HACKERS] Unicode UTF-8 table formatting for psql text output

2009-09-29 Thread Peter Eisentraut
On Tue, 2009-09-29 at 12:01 -0400, Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: On Mon, 2009-09-28 at 20:49 -0700, Brad T. Sliger wrote: pg_regress clears LC_ALL by default, but does not clear LANG by default. Please find attached a patch that causes pg_regress to also clear

Re: [HACKERS] patch: Review handling of MOVE and FETCH (ToDo)

2009-09-29 Thread Tom Lane
Pavel Stehule pavel.steh...@gmail.com writes: I am sending actualised patch as per John comment. Applied with minor fixes (mostly around MOVE ALL). regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] patch: Review handling of MOVE and FETCH (ToDo)

2009-09-29 Thread Pavel Stehule
2009/9/29 Tom Lane t...@sss.pgh.pa.us: Pavel Stehule pavel.steh...@gmail.com writes: I am sending actualised patch as per John comment. Applied with minor fixes (mostly around MOVE ALL). thank you Pavel                        regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] navigation menu for documents

2009-09-29 Thread Peter Eisentraut
On Fri, 2009-07-17 at 13:58 +0100, Richard Huxton wrote: 2. Titles on navigation links. Run ./STYLING/title_links.pl and it should add title attributes to the navigation links. This means hovering over the top links gives the title of the page they will go to. Presumably we could do this

Re: [HACKERS] Unicode UTF-8 table formatting for psql text output

2009-09-29 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On Tue, 2009-09-29 at 12:01 -0400, Tom Lane wrote: The bigger question is exactly how we expect this stuff to interact with pg_regress' --no-locale switch. We already do clear all these variables when --no-locale is specified. I am wondering just what

Re: [HACKERS] Unicode UTF-8 table formatting for psql text output

2009-09-29 Thread Tom Lane
Roger Leigh rle...@codelibre.net writes: C locale means POSIX behavior and nothing but. Indeed it does. However, making LC_CTYPE be UTF-8 rather than ASCII is both possible and still strictly conforming to the letter of the standard. There would be some collation and other restrictions

Re: [HACKERS] pg_hba.conf: samehost and samenet [REVIEW]

2009-09-29 Thread Robert Haas
On Mon, Sep 28, 2009 at 4:04 PM, Stef Walter stef-l...@memberwebs.com wrote: Robert Haas wrote: So is this one Ready for Committer? Here we go, I think this one is ready. In addition to previous patches, it does:  * Use some techniques from postfix for getting interface addresses.  

Re: [HACKERS] pg_hba.conf: samehost and samenet [REVIEW]

2009-09-29 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Mon, Sep 28, 2009 at 4:04 PM, Stef Walter stef-l...@memberwebs.com wrote:  * Tested on Solaris, FreeBSD, Linux and Windows. As far as I can tell   this should also work on Mac OS, HPUX and AIX, and probably others. This look ready to you, too? If

Re: [HACKERS] Unicode UTF-8 table formatting for psql text output

2009-09-29 Thread Robert Haas
On Tue, Sep 29, 2009 at 4:28 PM, Tom Lane t...@sss.pgh.pa.us wrote: Peter Eisentraut pete...@gmx.net writes: On Tue, 2009-09-29 at 12:01 -0400, Tom Lane wrote: The bigger question is exactly how we expect this stuff to interact with pg_regress' --no-locale switch.  We already do clear all

Re: [HACKERS] Unicode UTF-8 table formatting for psql text output

2009-09-29 Thread Alvaro Herrera
Robert Haas escribió: On Tue, Sep 29, 2009 at 4:28 PM, Tom Lane t...@sss.pgh.pa.us wrote: Peter Eisentraut pete...@gmx.net writes: On Tue, 2009-09-29 at 12:01 -0400, Tom Lane wrote: The bigger question is exactly how we expect this stuff to interact with pg_regress' --no-locale switch.  

Re: [HACKERS] Unicode UTF-8 table formatting for psql text output

2009-09-29 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Robert Haas escribió: This seems to mean that we can't apply this patch, since failing the regression tests is not an acceptable behavior. Does the patch pass regression tests in normal conditions? If you consider that normal means LANG=C in

Re: [HACKERS] Unicode UTF-8 table formatting for psql text output

2009-09-29 Thread Andrew Dunstan
Alvaro Herrera wrote: Does the patch pass regression tests in normal conditions? If it does, I see no reason to reject it. If it fails in --locale only, and even then only when the given locale is UTF8, which IIRC it's a seldom-used case, we can see about fixing that separately.

Re: [HACKERS] Unicode UTF-8 table formatting for psql text output

2009-09-29 Thread Alvaro Herrera
Tom Lane escribió: Alvaro Herrera alvhe...@commandprompt.com writes: Robert Haas escribi�: This seems to mean that we can't apply this patch, since failing the regression tests is not an acceptable behavior. Does the patch pass regression tests in normal conditions? If you consider

Re: [HACKERS] latest hstore patch

2009-09-29 Thread Tom Lane
[ starting to look at this now... ] Andrew Gierth and...@tao11.riddles.org.uk writes: David == David E Wheeler da...@kineticode.com writes: David * More name stuff: Why `hstore_to_list` rather than David `hstore_to_array`? And I'm not sure about `hstore_to_matrix` David for the

Re: [HACKERS] latest hstore patch

2009-09-29 Thread Andrew Gierth
Tom == Tom Lane t...@sss.pgh.pa.us writes: David * More name stuff: Why `hstore_to_list` rather than David `hstore_to_array`? And I'm not sure about `hstore_to_matrix` David for the 2-dimensional array. I guess that's better than David `hstore_to_multidimensional_array` would be. ;-) I

Re: [HACKERS] latest hstore patch

2009-09-29 Thread Josh Berkus
I don't feel particularly strongly about the name (I've also intentionally held off on updating the pgfoundry version of the code until this is settled so no-one else should care either). Well, since we already have string_to_array, hstore_to_array would be consistent. -- Josh Berkus

Re: [HACKERS] latest hstore patch

2009-09-29 Thread David E. Wheeler
On Sep 29, 2009, at 4:11 PM, Andrew Gierth wrote: I don't feel particularly strongly about the name (I've also intentionally held off on updating the pgfoundry version of the code until this is settled so no-one else should care either). I'm down with hstore_to_array() and hstore_to_matrix().

Re: [HACKERS] latest hstore patch

2009-09-29 Thread Andrew Gierth
David == David E Wheeler da...@kineticode.com writes: I don't feel particularly strongly about the name (I've also intentionally held off on updating the pgfoundry version of the code until this is settled so no-one else should care either). David I'm down with hstore_to_array() and

Re: [HACKERS] latest hstore patch

2009-09-29 Thread David E. Wheeler
On Sep 29, 2009, at 5:00 PM, Andrew Gierth wrote: David Sure. But I realized that I forgot to ask for David array_to_hstore() and matrix_to_hstore(). :-) Would love to David have those, too. Not sure about the operators… hstore(text[]) (which is also present as an explicit cast) covers both of

Re: [HACKERS] Lock Wait Statistics (next commitfest)

2009-09-29 Thread Jeff Janes
On Mon, Sep 28, 2009 at 12:14 AM, Jaime Casanova jcasa...@systemguards.com.ec wrote: On Sat, Aug 8, 2009 at 7:47 PM, Mark Kirkwood mar...@paradise.net.nz wrote: Patch with max(wait time). Still TODO - amalgamate individual transaction lock waits - redo (rather ugly) temporary

[HACKERS] CommitFest 2009-09, two weeks on

2009-09-29 Thread Robert Haas
It's now been two weeks since we started this CommitFest, so it seems like a good time to review where we are. Here are my thoughts, for what that's worth. Our overall rate of progress is significantly slower than it was last time around. At a similar point in the July CommitFest, 19 patches

Re: [HACKERS] [PATCH] Reworks for Access Control facilities (r2311)

2009-09-29 Thread KaiGai Kohei
Stephen Frost wrote: * KaiGai Kohei (kai...@kaigai.gr.jp) wrote: Stephen Frost wrote: You might also provide a specific example of where and why this check matters. I'm not entirely convinced it's necessary or makes sense, to be honest.. By the default, it is 100% correct to omit checks

Re: [HACKERS] [PATCH] Reworks for Access Control facilities (r2311)

2009-09-29 Thread KaiGai Kohei
I don't find the comment regarding what happened with FindConversion to be nearly descriptive enough. Can you elaborate on why the check wasn't necessary and has now been removed? If it really isn't needed, why have that function at all?