Re: [HACKERS] Unicode UTF-8 table formatting for psql text output

2009-11-23 Thread Peter Eisentraut
On sön, 2009-11-22 at 00:23 -0500, Tom Lane wrote: Roger Leigh rle...@codelibre.net writes: Attached is an updated patch with a couple of tweaks to ensure output is formatted and spaced correctly when border=0, which was off in the last patch. Applied wih minor editorialization.

[HACKERS] named generic constraints [feature request]

2009-11-23 Thread Caleb Cushing
So last time I checked this wasn't possible (at least not that anyone has told me). I'd like to be able to create constraints that aren't tied to a specific table/column. I think that the syntax would look something like this CREATE CONSTRAINT empty CHECK (VALUE = '\0' ); this should allow us

Re: [HACKERS] named generic constraints [feature request]

2009-11-23 Thread Pavel Stehule
Hello do you know domains? It is very similar to your proposal. http://www.postgresql.org/docs/8.2/static/sql-createdomain.html Regards Pavel Stehule 2009/11/23 Caleb Cushing xenoterrac...@gmail.com: So last time I checked this wasn't possible (at least not that anyone has told me). I'd like

Re: [HACKERS] [GENERAL] Updating column on row update

2009-11-23 Thread Thom Brown
2009/11/23 Tom Lane t...@sss.pgh.pa.us CREATE OR REPLACE has got far safer semantics from the viewpoint of a script that wants to bull through without having any actual error handling (which is more or less the scenario we are arguing here, no?) After successful execution of the command you

Re: [HACKERS] Partitioning option for COPY

2009-11-23 Thread Simon Riggs
On Wed, 2009-11-11 at 19:53 -0500, Emmanuel Cecchet wrote: Hi, I have extracted the partitioning option for COPY (removed the error logging part) from the previous patch. We can use an INSERT trigger to route tuples into partitions even now. Why do you need an additional router

Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove -w (--ignore-all-space) option from pg_regress's diff

2009-11-23 Thread Magnus Hagander
On Mon, Nov 23, 2009 at 06:58, Andrew Dunstan and...@dunslane.net wrote: Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: Tom Lane wrote: Remove -w (--ignore-all-space) option from pg_regress's diff calls. Looks like this has broken on Windows due to different line

Re: [HACKERS] forget patch win32.mak.

2009-11-23 Thread Magnus Hagander
Thanks, applied! //Magnus 2009/11/23 Hiroshi Saito z-sa...@guitar.ocn.ne.jp: Hi. Only for CVS-HEAD, not need backpatch. I checked REL8_4_STABLE is this. == nmake -f win32.mak ...snip Microsoft (R) Manifest Tool version 5.2.3790.2076 Copyright (c) Microsoft Corporation 2005. All rights

[HACKERS] Red-black tree for GIN

2009-11-23 Thread Teodor Sigaev
Hi there, attached is a patch, which contains implementation of a red-black tree, a self-balanced implementation of binary tree. The main goal of this patch is to improve creation time of GIN index in the corner cases. While creation, GIN collects data in memory in binary tree until it reach

[HACKERS] point_ops for GiST

2009-11-23 Thread Teodor Sigaev
Hi! patch implements operator class for GiST over points. Supported operations: pointpoint pointpoint point ^ point point ^ point point ~= point point @ box box @ point point @ polygon polygon @ point point @ circle circle @ point -- Teodor Sigaev

Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove -w (--ignore-all-space) option from pg_regress's diff

2009-11-23 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: On Mon, Nov 23, 2009 at 06:58, Andrew Dunstan and...@dunslane.net wrote: They might not be using the same CVS programs, though. It appears that Windows CVS (which, for example, red_bat uses) translates line endings to CRLF, which is why it passed the

Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove -w (--ignore-all-space) option from pg_regress's diff

2009-11-23 Thread Magnus Hagander
On Mon, Nov 23, 2009 at 15:23, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: On Mon, Nov 23, 2009 at 06:58, Andrew Dunstan and...@dunslane.net wrote: They might not be using the same CVS programs, though. It appears that Windows CVS (which, for example, red_bat

Re: [HACKERS] Unicode UTF-8 table formatting for psql text output

2009-11-23 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: What is the plan behind keeping the old format? Are we going to remove it after one release if no one complains, or are we seriously expecting that someone has code that actually parses this? Plan? Do we need a plan? The extra support consists of

Re: [HACKERS] [GENERAL] Updating column on row update

2009-11-23 Thread Robert Haas
On Sun, Nov 22, 2009 at 11:38 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Sun, Nov 22, 2009 at 6:51 PM, Tom Lane t...@sss.pgh.pa.us wrote: CREATE IF NOT EXISTS has been proposed and rejected before, more than once.  Please see the archives. Search for

Re: [HACKERS] [GENERAL] Updating column on row update

2009-11-23 Thread Tom Lane
Thom Brown thombr...@gmail.com writes: As for having plpgsql installed by default, are there any security implications? Well, that's pretty much exactly the question --- are there? It would certainly make it easier for someone to exploit any other security weakness they might find. I believe

Re: [HACKERS] Partitioning option for COPY

2009-11-23 Thread Emmanuel Cecchet
Simon, I think you should read the thread and the patch before making any false statements like you did in your email. 1. The patch does not use any trigger for routing. 2. This is just an option for COPY that is useful for loading operations in the datawarehouse world. It is not meant to

Re: [HACKERS] Partitioning option for COPY

2009-11-23 Thread Robert Haas
On Mon, Nov 23, 2009 at 9:39 AM, Emmanuel Cecchet m...@asterdata.com wrote: I think you should read the thread and the patch before making any false statements like you did in your email. 1. The patch does not use any trigger for routing. Whoa, whoa! I don't think that Simon said that it

Re: [HACKERS] [GENERAL] Updating column on row update

2009-11-23 Thread Thom Brown
2009/11/23 Tom Lane t...@sss.pgh.pa.us Thom Brown thombr...@gmail.com writes: As for having plpgsql installed by default, are there any security implications? Well, that's pretty much exactly the question --- are there? It would certainly make it easier for someone to exploit any other

Re: [HACKERS] [GENERAL] Updating column on row update

2009-11-23 Thread Andrew Gierth
Tom == Tom Lane t...@sss.pgh.pa.us writes: Thom Brown thombr...@gmail.com writes: As for having plpgsql installed by default, are there any security implications? Tom Well, that's pretty much exactly the question --- are there? It Tom would certainly make it easier for someone to

Re: [HACKERS] Partitioning option for COPY

2009-11-23 Thread Emmanuel Cecchet
Robert Haas wrote: On Mon, Nov 23, 2009 at 9:39 AM, Emmanuel Cecchet m...@asterdata.com wrote: I think you should read the thread and the patch before making any false statements like you did in your email. 1. The patch does not use any trigger for routing. Whoa, whoa! I don't think

Re: [HACKERS] [GENERAL] Updating column on row update

2009-11-23 Thread Andrew Dunstan
Tom Lane wrote: Thom Brown thombr...@gmail.com writes: As for having plpgsql installed by default, are there any security implications? Well, that's pretty much exactly the question --- are there? It would certainly make it easier for someone to exploit any other security weakness

Re: [HACKERS] Partitioning option for COPY

2009-11-23 Thread Simon Riggs
On Mon, 2009-11-23 at 09:39 -0500, Emmanuel Cecchet wrote: I think you should read the thread and the patch I did read the thread and patch in full before posting. My opinions are given to help you and the community towards a desirable common goal. I was unaware you were developing these

Re: [HACKERS] Partitioning option for COPY

2009-11-23 Thread Simon Riggs
On Mon, 2009-11-23 at 09:39 -0500, Emmanuel Cecchet wrote: I think you should read the thread and the patch I did read the thread and patch in full before posting. My opinions are given to help you and the community towards a desirable common goal. I was unaware you were developing these

Re: [HACKERS] [GENERAL] Updating column on row update

2009-11-23 Thread Tom Lane
Andrew Gierth and...@tao11.riddles.org.uk writes: Tom == Tom Lane t...@sss.pgh.pa.us writes: Tom Well, that's pretty much exactly the question --- are there? It Tom would certainly make it easier for someone to exploit any other Tom security weakness they might find. Loops in plain SQL

Re: [HACKERS] Partitioning option for COPY

2009-11-23 Thread Emmanuel Cecchet
Simon Riggs wrote: I was unaware you were developing these ideas and so was unable to provide comments until now. The first patch was published to this list on September 10 (almost 2.5 months ago) along with the wiki page describing the problem and the solution. What should I have done to

Re: [HACKERS] Partitioning option for COPY

2009-11-23 Thread Simon Riggs
On Mon, 2009-11-23 at 10:24 -0500, Emmanuel Cecchet wrote: I think there is a misunderstanding between what Simon wants ('Anyway, I want data routing, as is the intention of this patch.') and what this patch is about. This patch is just supposed to load tuples in a hierarchy of tables as

Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove -w (--ignore-all-space) option from pg_regress's diff

2009-11-23 Thread Andrew Dunstan
Tom Lane wrote: Magnus Hagander mag...@hagander.net writes: On Mon, Nov 23, 2009 at 06:58, Andrew Dunstan and...@dunslane.net wrote: They might not be using the same CVS programs, though. It appears that Windows CVS (which, for example, red_bat uses) translates line endings to CRLF,

Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove -w (--ignore-all-space) option from pg_regress's diff

2009-11-23 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: Tom Lane wrote: I'm thinking that the most appropriate fix is to have pg_regress continue to use -w, but only on Windows. Well, the filter could be as simple as something like this in the Makefile for the mingw case: perl -spi.bak -e

Re: [HACKERS] Partitioning option for COPY

2009-11-23 Thread Simon Riggs
On Mon, 2009-11-23 at 10:43 -0500, Emmanuel Cecchet wrote: Simon Riggs wrote: I was unaware you were developing these ideas and so was unable to provide comments until now. The first patch was published to this list on September 10 (almost 2.5 months ago) along with the wiki page

Re: [HACKERS] point_ops for GiST

2009-11-23 Thread Greg Stark
2009/11/23 Teodor Sigaev teo...@sigaev.ru: point   @ box point   @ polygon point   @ circle I've always wondered why we didn't have these -- greg -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Partitioning option for COPY

2009-11-23 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: Anyway, I want data routing, as is the intention of this patch. I just don't think this patch is a useful way to do it. It is too narrow in its scope and potentially buggy in its approach to developing a cache and using trigger-like stuff. FWIW, I

Re: [HACKERS] Partitioning option for COPY

2009-11-23 Thread Greg Smith
Simon Riggs wrote: ...Read my detailed comments in response to Kedar's patch and post comments on that thread to say you didn't agree with that proposal and that you were thinking of another way entirely. Useful background here is: http://wiki.postgresql.org/wiki/Table_partitioning

Re: [HACKERS] Partitioning option for COPY

2009-11-23 Thread Simon Riggs
On Mon, 2009-11-23 at 12:23 -0500, Greg Smith wrote: What would probably be helpful here is to take the mess of raw data above and turn it into a simpler partitioning roadmap. Thanks for summarising. I briefly tried to do that on the thread for Itagaki-san's patch. That's a first stab at

Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove -w (--ignore-all-space) option from pg_regress's diff

2009-11-23 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: Tom Lane wrote: I'm thinking that the most appropriate fix is to have pg_regress continue to use -w, but only on Windows. Well, the filter could be as simple as something like this in the Makefile for the mingw

[HACKERS] KNNGiST for knn-search

2009-11-23 Thread Teodor Sigaev
Hi there, http://www.sigaev.ru/misc/knngist-0.11.tar.gz we'd like to present contrib module for CVS HEAD, which contains implementation of knn (k nearest neighbourhood) search in PostgreSQL, see README.knngist for details. KNNGiST is an extension of existing GiST, which inherits most of their

Re: [HACKERS] named generic constraints [feature request]

2009-11-23 Thread Caleb Cushing
On Mon, Nov 23, 2009 at 4:17 AM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello do you know domains? It is very similar to your proposal. obviously since I cited it. constraint cannot be  part of  expression. why not? NOT NULL is a contraint, UNIQUE is a contstraint. CREATE OR

Re: [HACKERS] [GENERAL] Updating column on row update

2009-11-23 Thread Andrew Gierth
Tom == Tom Lane t...@sss.pgh.pa.us writes: Loops in plain SQL are no problem: see generate_series. The last time we discussed this I demonstrated reasonably straightforward SQL examples of how to do things like password-cracking (and that was long before we had CTEs, so it would be even

Re: [HACKERS] EXPLAIN BUFFERS

2009-11-23 Thread Jeff Janes
On Thu, Oct 15, 2009 at 3:29 AM, Itagaki Takahiro itagaki.takah...@oss.ntt.co.jp wrote: Robert Haas robertmh...@gmail.com wrote: In this case, I think that the auto_explain changes out to be part of the same patch as the core EXPLAIN changes Here is a rewritten patch to add EXPLAIN

Re: [HACKERS] named generic constraints [feature request]

2009-11-23 Thread Pavel Stehule
2009/11/23 Caleb Cushing xenoterrac...@gmail.com: On Mon, Nov 23, 2009 at 4:17 AM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello do you know domains? It is very similar to your proposal. obviously since I cited it. constraint cannot be  part of  expression. why not? NOT NULL is a

[HACKERS] arrays as input parameters in plperl

2009-11-23 Thread Alexey Klyukin
Hi, I'd like to improve the way PL/Perl handles arrays as function input parameters. In PL/Perl arrays are passed as plain text strings, and getting a value of an array element requires additional perl code to parse that string. I'd like to make this easier by converting each postgresq array

Re: [HACKERS] named generic constraints [feature request]

2009-11-23 Thread Peter Eisentraut
On mån, 2009-11-23 at 12:50 -0500, Caleb Cushing wrote: and domains only seem right if it's something, like a zip code, that has a very specific set of rules, that is in reality it's own type. A domain is not really its own type, it's a domain over its base type. Hence the name. where

[HACKERS] [PATCH 0/4] COPY to a UDF: COPY ... TO FUNCTION ...

2009-11-23 Thread Daniel Farina
I have extended COPY to support using a UDF as a target instead of the normal 'file' or STDOUT targets. This dovetails nicely with a couple of extensions I have also written for dblink for the purposes of enabling direct cross-node bulk loading and replication. Please peruse the patches (the

[HACKERS] [PATCH 3/4] Add dblink functions for use with COPY ... TO FUNCTION ...

2009-11-23 Thread Daniel Farina
This patch enables dblink to be used for the purpose of efficient bulk-loading via COPY and libpq in combination with the COPY TO FUNCTION patch. The following functions were added to accomplish this: dblink_connection_reset: useful when handling errors and one just wants to restore a connection

[HACKERS] [PATCH 2/4] Add tests for COPY ... TO FUNCTION ...

2009-11-23 Thread Daniel Farina
Signed-off-by: Daniel Farina dfar...@truviso.com --- src/test/regress/input/copy.source | 38 +++ src/test/regress/output/copy.source | 69 +++ src/test/regress/regress.c | 56 3 files changed, 163

[HACKERS] [PATCH 1/4] Add COPY ... TO FUNCTION ... support

2009-11-23 Thread Daniel Farina
This relatively small change enables all sort of new and shiny evil by allowing specification of a function to COPY that accepts each produced row's content in turn. The function must accept a single INTERNAL-type argument, which is actually of the type StringInfo. Patch highlights: - Grammar

Re: [HACKERS] magic block in doc functions

2009-11-23 Thread Peter Eisentraut
On ons, 2009-11-18 at 01:39 -0200, Euler Taveira de Oliveira wrote: I noticed that some example functions don't contain the magic block and that leads to error while loading those examples in 8.2 or later. Attached is a patch that adds it. I also add some missing header file. Don't have a

[HACKERS] [PATCH 4/4] Add tests to dblink covering use of COPY TO FUNCTION

2009-11-23 Thread Daniel Farina
Signed-off-by: Daniel Farina dfar...@truviso.com --- contrib/dblink/expected/dblink.out | 272 contrib/dblink/sql/dblink.sql | 112 +++ 2 files changed, 384 insertions(+), 0 deletions(-) diff --git a/contrib/dblink/expected/dblink.out

Re: [HACKERS] [PATCH 4/4] Add tests to dblink covering use of COPY TO FUNCTION

2009-11-23 Thread Robert Haas
On Mon, Nov 23, 2009 at 4:34 PM, Daniel Farina dfar...@truviso.com wrote: Signed-off-by: Daniel Farina dfar...@truviso.com Thanks for the patch. You may want to take a look at this: http://wiki.postgresql.org/wiki/Submitting_a_Patch I'm fuzzy on what problem this is attempting to solve... as

Re: [HACKERS] [PATCH 4/4] Add tests to dblink covering use of COPY TO FUNCTION

2009-11-23 Thread Greg Smith
Robert Haas wrote: I'm fuzzy on what problem this is attempting to solve... as mentioned in the above guidelines, it's usually good to start with some design discussions before writing/submitting code. This has been through some heavy design discussions with a few PG hackers you know and some

Re: [HACKERS] [PATCH 4/4] Add tests to dblink covering use of COPY TO FUNCTION

2009-11-23 Thread Daniel Farina
On Mon, Nov 23, 2009 at 2:16 PM, Robert Haas robertmh...@gmail.com wrote: On Mon, Nov 23, 2009 at 4:34 PM, Daniel Farina dfar...@truviso.com wrote: Signed-off-by: Daniel Farina dfar...@truviso.com Thanks for the patch.  You may want to take a look at this:

Re: [HACKERS] [PATCH 4/4] Add tests to dblink covering use of COPY TO FUNCTION

2009-11-23 Thread Andrew Dunstan
Greg Smith wrote: Robert Haas wrote: I'm fuzzy on what problem this is attempting to solve... as mentioned in the above guidelines, it's usually good to start with some design discussions before writing/submitting code. This has been through some heavy design discussions with a few PG

Re: [HACKERS] [PATCH 4/4] Add tests to dblink covering use of COPY TO FUNCTION

2009-11-23 Thread Daniel Farina
On Mon, Nov 23, 2009 at 3:46 PM, Andrew Dunstan and...@dunslane.net wrote: I recently found myself trying to push data through dblink() and ended up writing code to make a call to the target to call a function which called back to the source to select the data and insert it. The speedup was

Re: [HACKERS] [PATCH 4/4] Add tests to dblink covering use of COPY TO FUNCTION

2009-11-23 Thread Daniel Farina
On Mon, Nov 23, 2009 at 4:03 PM, Daniel Farina dfar...@truviso.com wrote: Yes.  Take a look at the tests introduced to core PostgeSQL (see patch 2), where instead of returning a text[] I return just a single text of the verbatim output of the copy.  You could imagine making that an SRF

Re: [HACKERS] [PATCH 4/4] Add tests to dblink covering use of COPY TO FUNCTION

2009-11-23 Thread Tom Lane
Greg Smith g...@2ndquadrant.com writes: Robert Haas wrote: I'm fuzzy on what problem this is attempting to solve... as mentioned in the above guidelines, it's usually good to start with some design discussions before writing/submitting code. This has been through some heavy design

Re: [HACKERS] [PATCH 4/4] Add tests to dblink covering use of COPY TO FUNCTION

2009-11-23 Thread Daniel Farina
On Mon, Nov 23, 2009 at 4:20 PM, Tom Lane t...@sss.pgh.pa.us wrote: pgsql-hackers had some preliminary discussions a couple months back on refactoring COPY to allow things like this --- see the thread starting here: http://archives.postgresql.org/pgsql-hackers/2009-09/msg00486.php While I

Re: [HACKERS] WIP: log query in auto-explain

2009-11-23 Thread Itagaki Takahiro
Andrew Dunstan and...@dunslane.net wrote: Basically it includes the text of the query being explained in the explain output. I expected the query text is printed in STATEMENT section. Do you mean the query should be merged into LOG section? Are there any situation where STATEMENT section

Re: [HACKERS] [GENERAL] Updating column on row update

2009-11-23 Thread Craig Ringer
On 23/11/2009 11:35 PM, Tom Lane wrote: Andrew Gierth and...@tao11.riddles.org.uk writes: Tom == Tom Lane t...@sss.pgh.pa.us writes: Tom Well, that's pretty much exactly the question --- are there? It Tom would certainly make it easier for someone to exploit any other Tom security

Re: [HACKERS] TRIGGER with WHEN clause

2009-11-23 Thread Itagaki Takahiro
Tom Lane t...@sss.pgh.pa.us wrote: [ TRIGGER WHEN patch ] Applied with assorted revisions. AFAICT the system column issue is only a problem for NEW references in BEFORE triggers --- those columns do read correctly in OLD, and all the time in AFTER triggers. I revised the parsing logic to

Re: [HACKERS] Hot standby and removing VACUUM FULL

2009-11-23 Thread Itagaki Takahiro
Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: So I guess what I'm asking is: Does anyone see any show-stoppers in removing VACUUM FULL, and does anyone want to step up to the plate and promise to do it before release? I'm working on New VACUUM FULL patch, that shrinks tables

Re: [HACKERS] EXPLAIN BUFFERS

2009-11-23 Thread Itagaki Takahiro
Jeff Janes jeff.ja...@gmail.com wrote: Just a quick note: this patch does not apply cleanly to HEAD due to the subsequent removal from explain.c of the near-by lines: Thanks for reporting. The attached patch is rebased to current CVS. Regards, --- ITAGAKI Takahiro NTT Open Source Software

Re: [HACKERS] [PATCH 4/4] Add tests to dblink covering use of COPY TO FUNCTION

2009-11-23 Thread Greg Smith
Tom Lane wrote: Those discussions don't have a lot of credibility if they didn't take place on the public mailing lists. You know how people complain about how new contributors are treated here? Throwing out comments like this, that come off as belittling to other people's work, doesn't

Re: [HACKERS] named generic constraints [feature request]

2009-11-23 Thread Caleb Cushing
CREATE OR REPLACE FUNCTION emptystr(text) RETURNS bool AS $$  SELECT $1 ''; -- it is SQL not C $$ LANGUAGE sql; CREATE TABLE users(  username TEXT CHECK (NOT emptystr(username)), although I'm not going to continue discussing the request. this code as the opposite desired effect. it should

Re: [HACKERS] [PATCH 4/4] Add tests to dblink covering use of COPY TO FUNCTION

2009-11-23 Thread Andrew Dunstan
Greg Smith wrote: I haven't heard anything from Andrew about ragged CVS import either. I think that ultimately those features are useful, but just exceed what the existing code could be hacked to handle cleanly. The patch is attached for your edification/amusement. I have backpatched it

[HACKERS] SE-PgSQL patch review

2009-11-23 Thread Itagaki Takahiro
I'm reviewing SE-PgSQL patch and have some comments. https://commitfest.postgresql.org/action/patch_view?id=212 Forgive me, but I'm a novice of SELinux. Some of the comments and question might be nonsense. Patch overview The patch itself is large (13K), but more than half of it are

Re: [HACKERS] WIP: log query in auto-explain

2009-11-23 Thread Andrew Dunstan
Itagaki Takahiro wrote: Andrew Dunstan and...@dunslane.net wrote: Basically it includes the text of the query being explained in the explain output. I expected the query text is printed in STATEMENT section. Do you mean the query should be merged into LOG section? Are there any

Re: [HACKERS] WIP: log query in auto-explain

2009-11-23 Thread Itagaki Takahiro
Andrew Dunstan and...@dunslane.net wrote: I mean it should be in the Explain output: explain xmlns=http://www.postgresql.org/2009/explain; Query-TextSELECT '' AS zero, BOOLTBL1.* A number of users (including me) badly want to be able to extract the explain output from the log

Re: [HACKERS] named generic constraints [feature request]

2009-11-23 Thread Josh Berkus
Caleb, I can understand why you want this. However, it would be tricky to implement because of data typing, and is fairly easily worked around using either domains or functions. So I don't think anyone is going to want to add it to the TODO list, sorry. Of course, Postgres is fully hackable if

Re: [HACKERS] Partitioning option for COPY

2009-11-23 Thread Itagaki Takahiro
Tom Lane t...@sss.pgh.pa.us wrote: What we need first is an explicit representation of partitioning, and then to build routing code on top of that. I haven't looked at Itagaki-san's syntax patch at all, but I think it's at least starting in a sensible place. I have the following

Re: [HACKERS] named generic constraints [feature request]

2009-11-23 Thread Pavel Stehule
2009/11/24 Caleb Cushing xenoterrac...@gmail.com: CREATE OR REPLACE FUNCTION emptystr(text) RETURNS bool AS $$  SELECT $1 ''; -- it is SQL not C $$ LANGUAGE sql; CREATE TABLE users(  username TEXT CHECK (NOT emptystr(username)), although I'm not going to continue discussing the request.

Re: [HACKERS] SE-PgSQL patch review

2009-11-23 Thread KaiGai Kohei
Itagaki Takahiro wrote: I'm reviewing SE-PgSQL patch and have some comments. https://commitfest.postgresql.org/action/patch_view?id=212 Forgive me, but I'm a novice of SELinux. Some of the comments and question might be nonsense. Itagaki-san, thanks for your volunteering so much!

Re: [HACKERS] Partitioning option for COPY

2009-11-23 Thread Nikhil Sontakke
Hi, What would probably be helpful here is to take the mess of raw data above and turn it into a simpler partitioning roadmap. Thanks for summarising. Yeah, excellent summary Greg. As you rightly pointed out, partitioning needs a broad roadmap so that the community can contribute in unison.

Re: [HACKERS] SE-PgSQL patch review

2009-11-23 Thread KaiGai Kohei
* Can we use error messages that looks like existing privilege errors? ERRCODE_INSUFFICIENT_PRIVILEGE: = permission denied to rename database Here is a point that we should provide users a hint which enables to make clear the reason of access violations. So, I think we should

Re: [HACKERS] Hot standby and removing VACUUM FULL

2009-11-23 Thread Heikki Linnakangas
Itagaki Takahiro wrote: VACUUM FULL is still reserved for system catalogs in my patch because we cannot modify relfilenodes for the catalog tables. Do you have solutions for it? Tom had an idea on that: http://archives.postgresql.org/message-id/19750.1252094...@sss.pgh.pa.us -- Heikki

Re: [HACKERS] Hot standby and removing VACUUM FULL

2009-11-23 Thread Heikki Linnakangas
Greg Smith wrote: Heikki Linnakangas wrote: So I guess what I'm asking is: Does anyone see any show-stoppers in removing VACUUM FULL Here's the disclaimers attached to the new VACUUM REPLACE implementation from Itagaki: We still need traditional VACUUM FULL behavior for system catalog

Re: [HACKERS] KNNGiST for knn-search

2009-11-23 Thread Heikki Linnakangas
Teodor Sigaev wrote: we'd like to present contrib module for CVS HEAD, which contains implementation of knn (k nearest neighbourhood) search in PostgreSQL, see README.knngist for details. Cool! Old way: SELECT coordinates, (coordinates - '5.0,5.0'::point) AS dist FROM spots order by dist

Re: [HACKERS] Hot standby and removing VACUUM FULL

2009-11-23 Thread Hannu Krosing
On Tue, 2009-11-24 at 09:24 +0200, Heikki Linnakangas wrote: Greg Smith wrote: Heikki Linnakangas wrote: So I guess what I'm asking is: Does anyone see any show-stoppers in removing VACUUM FULL Here's the disclaimers attached to the new VACUUM REPLACE implementation from Itagaki: