Josh Berkus j...@agliodbs.com wrote:
pg_stop_backup() doesn't complete until all the WAL segments
needed to restore from the backup are archived. If
archive_command is failing, that never happens.
OK, so we need a way out of that cycle if the user is issuing
pg_stop_backup because they
On Wed, 2010-02-24 at 11:55 -0800, Joshua D. Drake wrote:
On Wed, 2010-02-24 at 19:02 +, Simon Riggs wrote:
On Wed, 2010-02-24 at 10:17 -0800, Joshua D. Drake wrote:
You make the mistake of assuming that someone that can develop has no
solution experience. That is exactly how I fund
Josh Berkus j...@agliodbs.com writes:
pg_stop_backup() doesn't complete until all the WAL segments needed to
restore from the backup are archived. If archive_command is failing,
that never happens.
OK, so we need a way out of that cycle if the user is issuing
pg_stop_backup because they
On Feb 24, 2010, at 12:47 PM, Tom Lane wrote:
OK, so we need a way out of that cycle if the user is issuing
pg_stop_backup because they *already know* that archive_command is
failing. Right now, there's no way out other than a fast shutdown,
which is a bit user-hostile.
The
Josh Berkus wrote:
pg_stop_backup() doesn't complete until all the WAL segments needed to
restore from the backup are archived. If archive_command is failing,
that never happens.
OK, so we need a way out of that cycle if the user is issuing
pg_stop_backup because they *already know* that
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes:
Josh Berkus wrote:
OK, so we need a way out of that cycle if the user is issuing
pg_stop_backup because they *already know* that archive_command is
failing. Right now, there's no way out other than a fast shutdown,
Sure there
I should have added that (on the slave) all pg_xlog/ files have timeline 1
like: 000100E200C0
On Wed, February 24, 2010 20:40, Erikruary 24, 2010 20:40, Er Rijkers wrote:
I have two 9.0devel machines (*not* alpha but cvs as of 2010.02.19 22.48).
One primary, one slave.
In an
Simon Riggs wrote:
On Tue, 2010-02-23 at 10:00 +0100, Stefan Kaltenbrunner wrote:
While playing with SR/HS in a more complex datacenter environment I
immediatly hit the need to being able to specify the ipaddress(or
interface) that the backend(or libpq) uses to connect to the master.
There
There is a failure report here that seems worthy of notice:
http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=baijidt=2010-02-23%2023:00:03
Everything is fine except that the session running the triggers test
went completely bonkers: the first few commands are okay, and then
after that
Greg,
I expect for your particular bad situation, you can replace the
archive_command with a corrected one, use pg_ctl reload to send a
SIGHUP to make that fix active, and escape from this. That's the only
right way out of this situation. You can't just abort a backup someone
has asked for
On Wed, Feb 24, 2010 at 8:15 PM, Richard Huxton d...@archonet.com wrote:
If that all works, re-run the installer and you should be able to re-install
the adminpack etc. over the top of your now working installation.
That won't work. If the installer finds the existing data directory
(which it
With plperl.on_init allowing the loading of modules, might there be some
merit (and little cost) in allowing the same style of function-mapping
as with C functions?
CREATE FUNCTION add_one(integer) RETURNS integer
AS 'DIRECTORY/funcs', 'add_one'
LANGUAGE C STRICT;
CREATE FUNCTION
Stefan Kaltenbrunner ste...@kaltenbrunner.cc writes:
Simon Riggs wrote:
Not for 9.0, though sounds like a welcome change.
yeah - any objections if I add it to the TODO for now?
None, it seems like a reasonable future feature.
regards, tom lane
--
Sent via
Josh Berkus wrote:
So I'm seeing pg_abort_backup(), which also produces a
markers which prevent the backup from loading, as an improvement on
current UI.
Starting with 9.0, if recovery doesn't see a end-of-backup record, it
will refuse to start up. In earlier versions we had a similar
You also need to avoid scanning the same tuple twice. That's not a
problem for VACUUM, but it is for full index scans.
Heikki,
Actually the logic, which i have explained earlier is to avoid
scanning tuples twice.
Gokul.
I haven't thought about whether this is sufficient but if it is then
an initial useful thing to add would be to use it for queries where we
have a qual that can be checked using the index key even though we
can't do a range scan. For example if you have a btree index on
a,b,c and you have a
Josh Berkus j...@agliodbs.com writes:
Thing is, if archive_command is failing, then the backup is useless
regardless until it's fixed. And sending the archives to /dev/null (the
fix you're essentially recommending above) doesn't make the backup any
more useful. So I'm seeing
On Wed, 2010-02-24 at 13:30 -0800, Josh Berkus wrote:
So I'm seeing pg_abort_backup(), which also produces a
markers which prevent the backup from loading, as an improvement on
current UI.
Since Kevin suggested this in his first post and I agreed with that in
the first paragraph of my first
Simon Riggs si...@2ndquadrant.com writes:
Please test the following patch to see if it meets your needs and check
the wordings used in the docs.
What exactly will that function accomplish, given the assumption that
the user already tried pg_stop_backup?
regards, tom
Tom, Simon,
* emit a NOTICE as soon as pg_stop_backup's actual work is done and
it's starting to wait for the archiver (or maybe after it's waited
for a few seconds, but much less than the present 60).
* extend the existing WARNING (and the NOTICE too if we elect to have
one) with a HINT
Josh Berkus wrote:
Thing is, if archive_command is failing, then the backup is useless
regardless until it's fixed. And sending the archives to /dev/null (the
fix you're essentially recommending above) doesn't make the backup any
more useful.
That's not what I said to do first. If it's
That's not what I said to do first. If it's possible to fix your
archive_command, and it never returned bad I'm saying success but I
didn't really do the right thing information to the server--it just
failed--this situation is completely recoverable with no damage to the
backup. Just fix
Josh Berkus j...@agliodbs.com writes:
Tom, Simon,
* emit a NOTICE as soon as pg_stop_backup's actual work is done and
it's starting to wait for the archiver (or maybe after it's waited
for a few seconds, but much less than the present 60).
* extend the existing WARNING (and the NOTICE too
On Feb 24, 2010, at 3:24 PM, Tom Lane wrote:
If you like the concept, then the next question is exactly how to phrase
the messages. All we have at the moment is the inside-the-delay-loop
warning:
ereport(WARNING,
(errmsg(pg_stop_backup still waiting for archive to complete
If you like the concept, then the next question is exactly how to phrase
the messages. All we have at the moment is the inside-the-delay-loop
warning:
ereport(WARNING,
(errmsg(pg_stop_backup still waiting for archive to complete (%d
seconds elapsed),
On Wed, Feb 24, 2010 at 4:35 PM, Richard Huxton d...@archonet.com wrote:
With plperl.on_init allowing the loading of modules, might there be some
merit (and little cost) in allowing the same style of function-mapping as
with C functions?
CREATE FUNCTION add_one(integer) RETURNS integer
On Wed, 2010-02-24 at 16:52 -0500, Tom Lane wrote:
Before you could enter pg_abort_backup you'd have to control-C out of
the pg_stop_backup call, and that action already accomplishes the only
thing pg_abort_backup could do for you.
Agreed. I was responding to perceived user need.
So what I
On Wed, 2010-02-24 at 14:20 -0800, Josh Berkus wrote:
Since Kevin suggested this in his first post and I agreed with that in
the first paragraph of my first post, I think you've wasted a lot of
time here going in circles. 42 posts, more than a dozen people. I
think
Please tone down the
Simon Riggs si...@2ndquadrant.com writes:
On Wed, 2010-02-24 at 16:52 -0500, Tom Lane wrote:
* emit a NOTICE as soon as pg_stop_backup's actual work is done and
it's starting to wait for the archiver (or maybe after it's waited
for a few seconds, but much less than the present 60).
Pointless
On Wed, Feb 24, 2010 at 14:35, Richard Huxton d...@archonet.com wrote:
With plperl.on_init allowing the loading of modules, might there be some
merit (and little cost) in allowing the same style of function-mapping as
with C functions?
CREATE FUNCTION add_one(integer) RETURNS integer
AS
On Wed, 2010-02-24 at 23:57 +, Simon Riggs wrote:
* emit a NOTICE as soon as pg_stop_backup's actual work is done and
it's starting to wait for the archiver (or maybe after it's waited
for a few seconds, but much less than the present 60).
Pointless really. Nobody runs backups in
On Wed, February 24, 2010 20:40, Erik Rijkers wrote:
pg_last_xlog_receive_location | pg_xlogfile_name_offset
---+---
E2/C012AD90 | (00E200C0,1224080)
(1 row)
These zero-timeline filenames
Robert Haas robertmh...@gmail.com wrote:
I'm pretty sure it's the same as this:
https://commitfest.postgresql.org/action/patch_view?id=263
Yes, (2) are resolved with the patch with a different implementation.
(2) is fixed by RegisterXactCallback(AtEOXact_dblink). However, there
might be
On Wed, 2010-02-24 at 19:08 -0500, Tom Lane wrote:
Simon Riggs si...@2ndquadrant.com writes:
On Wed, 2010-02-24 at 16:52 -0500, Tom Lane wrote:
* emit a NOTICE as soon as pg_stop_backup's actual work is done and
it's starting to wait for the archiver (or maybe after it's waited
for a few
Bruce Momjian br...@momjian.us wrote:
What happened to this patch?
It was rejected because SQL standard always requires an user mapping.
I agree about the decision, too.
---
Itagaki Takahiro wrote:
contrib/dblink in
On Thu, Feb 25, 2010 at 9:31 AM, Erik Rijkers e...@xs4all.nl wrote:
On Wed, February 24, 2010 20:40, Erik Rijkers wrote:
pg_last_xlog_receive_location | pg_xlogfile_name_offset
---+---
E2/C012AD90 |
Tom Lane wrote:
The value of the HINT I think would be to make them (a) not afraid to
hit control-C and (b) aware of the fact that their archiver has got
a problem.
Agreed on both points. Patch attached that implements something similar
to Josh's wording, tweaking the original warning too.
On 2/24/10 5:36 PM, Greg Smith wrote:
gsmith=# select pg_stop_backup();
NOTICE: pg_stop_backup cleanup done, waiting for required segments to
archive
WARNING: pg_stop_backup still waiting for all required segments to
archive (60 seconds elapsed)
HINT: Confirm your archive_command is
Josh Berkus j...@agliodbs.com writes:
On 2/24/10 5:36 PM, Greg Smith wrote:
gsmith=# select pg_stop_backup();
NOTICE: pg_stop_backup cleanup done, waiting for required segments to
archive
WARNING: pg_stop_backup still waiting for all required segments to
archive (60 seconds elapsed)
HINT:
On Wed, Feb 24, 2010 at 08:52:28PM -0500, Tom Lane wrote:
Josh Berkus j...@agliodbs.com writes:
On 2/24/10 5:36 PM, Greg Smith wrote:
gsmith=# select pg_stop_backup();
NOTICE: pg_stop_backup cleanup done, waiting for required segments to
archive
WARNING: pg_stop_backup still waiting
Tom Lane wrote:
The one thing I'm undecided about is whether we want the immediate
NOTICE, as opposed to dialing down the time till the first WARNING
to something like 5 or 10 seconds. I think the main argument for the
latter approach would be to avoid log-spam in normal operation
I though
On 2/24/10 5:58 PM, Greg Smith wrote:
I though about that for a minute, but didn't think pg_stop_backup is a
common enough operation that anyone will complain that it's a little
more verbose in its logging now. I know when I was new to this, I used
to wonder just what it was busy doing just
On Thu, Feb 25, 2010 at 10:52 AM, Tom Lane t...@sss.pgh.pa.us wrote:
The one thing I'm undecided about is whether we want the immediate
NOTICE, as opposed to dialing down the time till the first WARNING
to something like 5 or 10 seconds. I think the main argument for the
latter approach would
I don't want that immediate NOTICE message, which sounds like a noise.
Delaying it or changing the log level to DEBUG work for me.
Problem is that a new user won't be seeing DEBUG messages by default.
This issue is all about new user experience.
Alternatively, we could move the time of the
Greg Smith g...@2ndquadrant.com writes:
Tom Lane wrote:
The value of the HINT I think would be to make them (a) not afraid to
hit control-C and (b) aware of the fact that their archiver has got
a problem.
Agreed on both points. Patch attached that implements something similar
to Josh's
On Thu, Feb 25, 2010 at 5:29 AM, Heikki Linnakangas
heikki.linnakan...@enterprisedb.com wrote:
Hmm, interesting corner case. That assertion is checking that the
streaming starting point is initialized correctly, but 0/0 is actually a
valid value when you start streaming from the very first WAL
On Tue, Feb 23, 2010 at 4:08 PM, Heikki Linnakangas
heikki.linnakan...@enterprisedb.com wrote:
So it's not the TLI of the first record in the file, isn't it?
Hmm, or is it the TLI of the last record? Not sure. Anyway, if there's a
TLI switch in the current WAL file, curFileTLI doesn't always
On Wed, Feb 24, 2010 at 7:56 AM, Simon Riggs si...@2ndquadrant.com wrote:
On Thu, 2010-01-28 at 10:28 +0200, Heikki Linnakangas wrote:
Fujii Masao wrote:
In relation to the functions added recently, I found an annoying problem;
pg_xlogfile_name(pg_last_xlog_receive/replay_location()) might
The WAL record of the heap insert/update/delete contains a flag
indicating that the visibility map needs to be updated too. Thus no need
for a separate WAL record.
Heikki,
Have you considered these cases?
a) The current WAL architecture makes sure that the WAL Log is written
before
Fujii Masao wrote:
And we need to remove the following code from XLogSend(). This code is
useless now since the initial CopyData message is guaranteed to arrive
at the primary before doing XLogSend().
/*
* Invalid position means that we have not yet received the initial
* CopyData
On Thu, Feb 25, 2010 at 3:16 AM, Gokulakannan Somasundaram
gokul...@gmail.com wrote:
I haven't thought about whether this is sufficient but if it is then
an initial useful thing to add would be to use it for queries where we
have a qual that can be checked using the index key even though we
Gokulakannan Somasundaram wrote:
a) The current WAL architecture makes sure that the WAL Log is written
before the actual page flush( i believe ). But you are changing that
architecture for Visibility maps. Visibility map might get flushed out
before the corresponding WAL gets written.
Yes.
101 - 152 of 152 matches
Mail list logo
