Re: [HACKERS] SELECT constant; takes 15x longer on 9.0?

2010-04-07 Thread Pavel Stehule
2010/4/7 Greg Smith g...@2ndquadrant.com: Merlin Moncure wrote: On Tue, Apr 6, 2010 at 3:58 PM, Tom Lane t...@sss.pgh.pa.us wrote: Greg has the right idea: show debug_assertions. why not the entire set of configure options? Given that the standard way to find those is pg_config,

Re: pending patch: Re: [HACKERS] Streaming replication and pg_xlogfile_name()

2010-04-07 Thread Heikki Linnakangas
Fujii Masao wrote: On Tue, Apr 6, 2010 at 11:48 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Fujii Masao wrote: On Tue, Apr 6, 2010 at 8:02 PM, Fujii Masao masao.fu...@gmail.com wrote: Should we throw an error in pg_xlogfile_name() if called during recovery? It's not

Re: [HACKERS] Set LC_COLLATE to de_DE_phoneb

2010-04-07 Thread Takahiro Itagaki
Frank Jagusch fr...@jagusch-online.de wrote: The german phone book order has the windows language setting de_DE_phoneb an the value 00010407 in the registry. Unfortunately I was not able to find a corresponding string for the LC_COLLATE setting. I cannot find any resources for de_DE_phoneb

Re: [HACKERS] fallback_application_name and pgbench

2010-04-07 Thread Takahiro Itagaki
Fujii Masao masao.fu...@gmail.com wrote: By default, the application_name of pgbench is [unknown]. But I think that pgbench should use fallback_application_name as psql, pg_dump, etc does. Is it worth creating the patch? If we will take care of fallback_application_name for contrib modules,

Re: [HACKERS] fallback_application_name and pgbench

2010-04-07 Thread Magnus Hagander
On Wed, Apr 7, 2010 at 10:21, Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp wrote: Fujii Masao masao.fu...@gmail.com wrote: By default, the application_name of pgbench is [unknown]. But I think that pgbench should use fallback_application_name as psql, pg_dump, etc does. Is it worth

Re: [HACKERS] fallback_application_name and pgbench

2010-04-07 Thread Dave Page
On Wed, Apr 7, 2010 at 10:16 AM, Magnus Hagander mag...@hagander.net wrote: Uh, why fallback_application_name? Isn't this the *exact* usecase where application_name should be used? At least for the two apps - fallback_app_name might be correct for dblink. And yes, I think it's a good idea to

Re: [HACKERS] Streaming replication and a disk full in primary

2010-04-07 Thread Heikki Linnakangas
This task has been languishing for a long time, so I took a shot at it. I took the approach I suggested before, keeping a variable in shared memory to track the latest removed WAL segment. After walsender has read a bunch of WAL records from a WAL file, it checks that what it read is after the

Re: [HACKERS] [COMMITTERS] pgsql: Forbid using pg_xlogfile_name() and pg_xlogfile_name_offset()

2010-04-07 Thread Heikki Linnakangas
(moving to pgsql-hackers) Simon Riggs wrote: On Wed, 2010-04-07 at 06:12 +, Heikki Linnakangas wrote: Log Message: --- Forbid using pg_xlogfile_name() and pg_xlogfile_name_offset() during recovery. We might want to relax this in the future, but ThisTimeLineID isn't currently

Re: [HACKERS] [BUGS] BUG #5394: invalid declspec for PG_MODULE_MAGIC

2010-04-07 Thread Magnus Hagander
On Tue, Apr 6, 2010 at 21:55, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: On Mon, Mar 29, 2010 at 11:47 AM, Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp wrote: A patch attached. The name of PGMODULEEXPORT might be arguable. I agree with this in

Re: [HACKERS] Win32 timezone matching

2010-04-07 Thread Magnus Hagander
On Wed, Apr 7, 2010 at 00:48, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: On Wed, Apr 7, 2010 at 00:02, Tom Lane t...@sss.pgh.pa.us wrote: Oh, another thought here: what is the effect of the combination of this with your other proposal to add more timezones

[HACKERS] Thoughts on pg_hba.conf rejection

2010-04-07 Thread Simon Riggs
When there is a specific reject rule, why does the server say FATAL: no pg_hba.conf entry That sounds like an administrative error, rather than a specific decision on the part of an admin to reject the connection. Suggested message would be FATAL: connection rejected for host xxx, user ,

Re: [HACKERS] Quoting in recovery.conf

2010-04-07 Thread Heikki Linnakangas
Fujii Masao wrote: On Wed, Apr 7, 2010 at 1:48 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Ok, here's what I came up with. Looks OK to me. Committed. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list

[HACKERS] Re: [COMMITTERS] pgsql: Forbid using pg_xlogfile_name() and pg_xlogfile_name_offset()

2010-04-07 Thread Simon Riggs
On Wed, 2010-04-07 at 13:23 +0300, Heikki Linnakangas wrote: (moving to pgsql-hackers) Simon Riggs wrote: On Wed, 2010-04-07 at 06:12 +, Heikki Linnakangas wrote: Log Message: --- Forbid using pg_xlogfile_name() and pg_xlogfile_name_offset() during recovery. We might want

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-07 Thread Robert Haas
On Tue, Apr 6, 2010 at 3:14 PM, Simon Riggs si...@2ndquadrant.com wrote: On Tue, 2010-04-06 at 11:06 -0400, Robert Haas wrote:     * Redefine smart shutdown in standby mode? Drop. Too big a change at this point. We have a working patch for this - I want to commit it.  I don't think

Re: [HACKERS] fallback_application_name and pgbench

2010-04-07 Thread Robert Haas
On Wed, Apr 7, 2010 at 5:30 AM, Dave Page dp...@pgadmin.org wrote: On Wed, Apr 7, 2010 at 10:16 AM, Magnus Hagander mag...@hagander.net wrote: Uh, why fallback_application_name? Isn't this the *exact* usecase where application_name should be used? At least for the two apps - fallback_app_name

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-07 Thread Simon Riggs
On Wed, 2010-04-07 at 07:40 -0400, Robert Haas wrote: On Tue, Apr 6, 2010 at 3:14 PM, Simon Riggs si...@2ndquadrant.com wrote: On Tue, 2010-04-06 at 11:06 -0400, Robert Haas wrote: * Redefine smart shutdown in standby mode? Drop. Too big a change at this point. We have a

[HACKERS] system table/view and sequence

2010-04-07 Thread Olivier Baheux
i'm trying to find where are stored sequence definition (increment,minvalue,maxvalue,start,cache) in system tables. Atm I found everything exept sequence. Thanks in advance. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Thoughts on pg_hba.conf rejection

2010-04-07 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: When there is a specific reject rule, why does the server say FATAL: no pg_hba.conf entry It's intentional. We try to expose the minimum amount of knowledge about the contents of pg_hba.conf to potential attackers. regards,

Re: [HACKERS] Thoughts on pg_hba.conf rejection

2010-04-07 Thread Jaime Casanova
On Wed, Apr 7, 2010 at 10:46 AM, Tom Lane t...@sss.pgh.pa.us wrote: Simon Riggs si...@2ndquadrant.com writes: When there is a specific reject rule, why does the server say FATAL:  no pg_hba.conf entry It's intentional.  We try to expose the minimum amount of knowledge about the contents of

Re: [HACKERS] Thoughts on pg_hba.conf rejection

2010-04-07 Thread Tom Lane
Jaime Casanova jcasa...@systemguards.com.ec writes: On Wed, Apr 7, 2010 at 10:46 AM, Tom Lane t...@sss.pgh.pa.us wrote: It's intentional.  We try to expose the minimum amount of knowledge about the contents of pg_hba.conf to potential attackers. i just tried it in CVS and in 8.4 and when i

Re: [HACKERS] system table/view and sequence

2010-04-07 Thread Nicolas Barbier
2010/4/7 Olivier Baheux olivierbah...@gmail.com: i'm trying to find where are stored sequence definition (increment,minvalue,maxvalue,start,cache) in system tables. Atm I found everything exept sequence. It's in the sequence itself (which can be accessed like a table). The fact that this

Re: [HACKERS] Win32 timezone matching

2010-04-07 Thread Stefan Kaltenbrunner
Magnus Hagander wrote: On Wed, Apr 7, 2010 at 00:48, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: On Wed, Apr 7, 2010 at 00:02, Tom Lane t...@sss.pgh.pa.us wrote: Oh, another thought here: what is the effect of the combination of this with your other proposal

Re: [HACKERS] Win32 timezone matching

2010-04-07 Thread Tom Lane
Stefan Kaltenbrunner ste...@kaltenbrunner.cc writes: hmm all that code makes me wonder a bit about a more general issue - is the fallback to GMT if we fail to actually make sense of the right imezone to use actually a good idea? What alternative are you proposing? Failing to start the

Re: [HACKERS] Win32 timezone matching

2010-04-07 Thread Stefan Kaltenbrunner
Tom Lane wrote: Stefan Kaltenbrunner ste...@kaltenbrunner.cc writes: hmm all that code makes me wonder a bit about a more general issue - is the fallback to GMT if we fail to actually make sense of the right imezone to use actually a good idea? What alternative are you proposing? Failing to

Re: [HACKERS] Thoughts on pg_hba.conf rejection

2010-04-07 Thread Josh Berkus
Clearly needs to be secure. Does the second message give any information to a would-be hacker than the first? I don't think so, but it certainly helps an admin work out if they've missed something. I think this question needs a bona fide network security geek to decide, rather than us

Re: [HACKERS] Win32 timezone matching

2010-04-07 Thread Robert Haas
On Wed, Apr 7, 2010 at 12:20 PM, Stefan Kaltenbrunner ste...@kaltenbrunner.cc wrote: Tom Lane wrote: Stefan Kaltenbrunner ste...@kaltenbrunner.cc writes: hmm all that code makes me wonder a bit about a more general issue - is the fallback to GMT if we fail to actually make sense of the right

Re: [HACKERS] Thoughts on pg_hba.conf rejection

2010-04-07 Thread Robert Haas
On Wed, Apr 7, 2010 at 10:46 AM, Tom Lane t...@sss.pgh.pa.us wrote: Simon Riggs si...@2ndquadrant.com writes: When there is a specific reject rule, why does the server say FATAL:  no pg_hba.conf entry It's intentional.  We try to expose the minimum amount of knowledge about the contents of

Re: [HACKERS] Win32 timezone matching

2010-04-07 Thread Magnus Hagander
On Wed, Apr 7, 2010 at 7:04 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, Apr 7, 2010 at 12:20 PM, Stefan Kaltenbrunner ste...@kaltenbrunner.cc wrote: Tom Lane wrote: Stefan Kaltenbrunner ste...@kaltenbrunner.cc writes: hmm all that code makes me wonder a bit about a more general

Re: [HACKERS] Streaming replication and a disk full in primary

2010-04-07 Thread Robert Haas
On Wed, Apr 7, 2010 at 6:02 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: This task has been languishing for a long time, so I took a shot at it. I took the approach I suggested before, keeping a variable in shared memory to track the latest removed WAL segment. After

[HACKERS] Default libpq application name

2010-04-07 Thread Bruce Momjian
I just emailed Dave Page and it seems we don't set a default application name in libpq. Should we do: extern char *argv[]; and reference argv[0] in libpq to set a default application name? -- Bruce Momjian br...@momjian.ushttp://momjian.us EnterpriseDB

Re: [HACKERS] Default libpq application name

2010-04-07 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: I just emailed Dave Page and it seems we don't set a default application name in libpq. Should we do: extern char *argv[]; and reference argv[0] in libpq to set a default application name? No. This is not portable and it's not a good idea even if

Re: [HACKERS] Win32 timezone matching

2010-04-07 Thread Stefan Kaltenbrunner
Magnus Hagander wrote: On Wed, Apr 7, 2010 at 7:04 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, Apr 7, 2010 at 12:20 PM, Stefan Kaltenbrunner ste...@kaltenbrunner.cc wrote: Tom Lane wrote: Stefan Kaltenbrunner ste...@kaltenbrunner.cc writes: hmm all that code makes me wonder a bit

Re: [HACKERS] Win32 timezone matching

2010-04-07 Thread Tom Lane
Stefan Kaltenbrunner ste...@kaltenbrunner.cc writes: yeah that is one aspect - and in talking to the OP he would have prefered the database not starting up at all, logging an error and a hint on setting a fixed timezone in the conf. Well, you started from the statement that this was an

Re: [HACKERS] Win32 timezone matching

2010-04-07 Thread Tom Lane
I wrote: ereport(LOG, (errmsg(could not determine system time zone, defaulting to \%s\, GMT), BTW, does anyone remember the reason for making GMT nonlocalizable in these messages? It seems more straightforward to do (errmsg(could not determine system

[HACKERS] Enhancing phonetic search support for more languages - GSoC 2010

2010-04-07 Thread Dhiraj Lohiya
Hello I am Dhiraj Lohiya, Computer Science undergraduate from BITS Pilani. I wanted to propose idea to improvise upon the *phonetic search support, *initially for some Indian languages like Hindi and Marathi with a framework for extending it to other languages easily by contributing the rules in

[HACKERS] FM suffix in to_char Y/YY/YYY still screwy

2010-04-07 Thread Tom Lane
I thought we'd fixed this ... regression=# select to_char('2009-01-01'::date, 'YY'); to_char - 09 (1 row) regression=# select to_char('2009-01-01'::date, 'FMYY'); to_char - 09 (1 row) Not a lot of zero suppression happening there :-(. I believe the correct fix is to

Re: [HACKERS] Enhancing phonetic search support for more languages - GSoC 2010

2010-04-07 Thread Josh Berkus
Dhiraj, For instance, if many users(above a threshold set by us) insert some search string for which no wanted search result is retrieved, we could track what he finally selects and then accordingly append/modify our set of phonetic rules based on the phonetic mismatch amongst the query

Re: [HACKERS] Enhancing phonetic search support for more languages - GSoC 2010

2010-04-07 Thread Robert Haas
On Wed, Apr 7, 2010 at 4:24 PM, Dhiraj Lohiya lohiya.dhi...@gmail.com wrote: For instance, if many users(above a threshold set by us) insert some search string for which no wanted search result is retrieved, we could track what he finally selects and then accordingly append/modify our set of

[HACKERS] Re: [ADMIN] Compile Problem for Alpha 5 in /src/backend/utils/error/elog.c

2010-04-07 Thread Alvaro Herrera
Kiswono Prayogo escribió: Just reporting that Alpha 4 was working just fine.. http://pastebin.com/ri2gXJDN but Alpha 5 didn't: Yeah, known packaging bug. Please remove src/Makefile.custom and try again (notice the -Werror that shouldn't be there) elog.c:1698: error: ignoring return value

Re: [HACKERS] [ADMIN] Compile Problem for Alpha 5 in /src/backend/utils/error/elog.c

2010-04-07 Thread Kiswono Prayogo
oic, thanks ^^ -- Regards, Kiswono P GB -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Set LC_COLLATE to de_DE_phoneb

2010-04-07 Thread Takahiro Itagaki
Frank Jagusch fr...@jagusch-online.de wrote: de_DE_phoneb is the name of an alternative sorting in german (only a few languages have alternate sorting). You may find some information when you search the MSDN for de_DE_phoneb, i.e. http://msdn.microsoft.com/en-en/library/ms404373.aspx These

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-07 Thread Robert Haas
On Wed, Apr 7, 2010 at 8:17 AM, Simon Riggs si...@2ndquadrant.com wrote: OK, that looks a lot less risky than I had understood from discussions. The main thing for me is it doesn't interfere with Startup or WalReceiver, so assuming it works I've got no objections. Thanks for chasing this down,

Re: [HACKERS] Remaining Streaming Replication Open Items

2010-04-07 Thread Robert Haas
On Tue, Apr 6, 2010 at 4:09 PM, Simon Riggs si...@2ndquadrant.com wrote: On Tue, 2010-04-06 at 10:09 +0300, Heikki Linnakangas wrote:     *  Walsender and dblink are not interruptible on win32. - related thread I'd actually be happy to just leave it for 9.0, but it seems like consensus

[HACKERS] Re: [COMMITTERS] pgsql: Forbid using pg_xlogfile_name() and pg_xlogfile_name_offset()

2010-04-07 Thread Fujii Masao
On Wed, Apr 7, 2010 at 7:23 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: This commit is a stop-gap solution until we figure out what exactly to do about that. Masao-san wrote a patch that included the TLI in the string returned by pg_last_xlog_receive/replay_location() (see

Re: [HACKERS] Enhancing phonetic search support for more languages - GSoC 2010

2010-04-07 Thread Dhiraj Lohiya
I'm also curious why you chose to focus on the extremely imprecise soundex instead of the more discriminating metaphone. The main reason to choose soundex over metaphone/double metaphone is for Indian languages, soundex itself with some customizations works pretty well. Use of Double Metaphone

Re: [HACKERS] FM suffix in to_char Y/YY/YYY still screwy

2010-04-07 Thread Brendan Jurd
On 8 April 2010 06:46, Tom Lane t...@sss.pgh.pa.us wrote: Not a lot of zero suppression happening there :-(. I believe the correct fix is to reduce the year mod 100 (or 10 or 1000) before feeding it to snprintf, rather than playing games with printing only part of the result string as the

[HACKERS] A maze of twisty mailing lists all the same

2010-04-07 Thread Greg Stark
I've often said in the past that we have too many mailing lists with overlapping and vague charters. I submit the following thread as evidence that this causes real problems. http://archives.postgresql.org/message-id/g2o4b46b5f01004010610ib8625426uae6ee90ac1435...@mail.gmail.com Because the

Re: [HACKERS] A maze of twisty mailing lists all the same

2010-04-07 Thread Jaime Casanova
On Thu, Apr 8, 2010 at 1:11 AM, Greg Stark st...@mit.edu wrote: Likewise I don't think we should have pgsql-performance or pgsql-sql or pgsql-novice -- any thread appropriate for any of these would be better served by sending it to pgsql-general anyways (with the +1 -- Atentamente, Jaime

[HACKERS] Oddly indented raw_expression_tree_walker

2010-04-07 Thread Takahiro Itagaki
I found raw_expression_tree_walker() is oddly indented in 8.4 and HEAD. I expected pgindent would fix those clutter, but it could not. Should we cleanup it manually, or leave it as-is? Also, should we backport such kind of cleanups to previous releases? Index: src/backend/nodes/nodeFuncs.c