On 11.12.2012 08:07, Kyotaro HORIGUCHI wrote:
The cause is that CheckRecoveryConsistency() is called before rm_redo(),
as Horiguchi-san suggested upthead. Imagine the case where
minRecoveryPoint is set to the location of the XLOG_SMGR_TRUNCATE
record. When restarting the server with that
On Sun, Dec 9, 2012 at 8:11 AM, Tomas Vondra t...@fuzzy.cz wrote:
On 20.11.2012 08:22, Jeevan Chalke wrote:
Hi,
On Tue, Nov 20, 2012 at 12:08 AM, Tomas Vondra t...@fuzzy.cz
mailto:t...@fuzzy.cz wrote:
On 19.11.2012 11:59, Jeevan Chalke wrote:
Hi,
I gone
On Tue, Dec 11, 2012 at 6:59 AM, Josh Kupershmidt schmi...@gmail.com wrote:
Would it be crazy to add an already_freed flag to the pg_result
struct which PQclear() would set, or some equivalent safety mechanism,
to avoid this hassle for users?
Such mechanism already exist - you just need to set
On Tuesday, December 11, 2012 5:25 AM Jaime Casanova wrote:
On Fri, Nov 23, 2012 at 4:56 AM, Amit Kapila amit.kap...@huawei.com
wrote:
On Thursday, November 22, 2012 10:09 PM Fujii Masao wrote:
Is it helpful to output the notice message like 'Run pg_reload_conf()
or
restart the server
Hello
Sometimes I had a problems with identification custom exceptions in
plpgsql, because we skip collecting context
/*
* error context callback to let us supply a call-stack traceback
*/
static void
plpgsql_exec_error_callback(void *arg)
{
PLpgSQL_execstate *estate =
On 11 December 2012 10:39, Marko Kreen mark...@gmail.com wrote:
On Tue, Dec 11, 2012 at 6:59 AM, Josh Kupershmidt schmi...@gmail.com wrote:
Would it be crazy to add an already_freed flag to the pg_result
struct which PQclear() would set, or some equivalent safety mechanism,
to avoid this
2012-12-11 12:45 keltezéssel, Simon Riggs írta:
On 11 December 2012 10:39, Marko Kreen mark...@gmail.com wrote:
On Tue, Dec 11, 2012 at 6:59 AM, Josh Kupershmidt schmi...@gmail.com wrote:
Would it be crazy to add an already_freed flag to the pg_result
struct which PQclear() would set, or some
On Tue, Dec 11, 2012 at 5:18 AM, Boszormenyi Zoltan z...@cybertec.at wrote:
2012-12-11 12:45 keltezéssel, Simon Riggs írta:
On 11 December 2012 10:39, Marko Kreen mark...@gmail.com wrote:
On Tue, Dec 11, 2012 at 6:59 AM, Josh Kupershmidt schmi...@gmail.com
wrote:
Would it be crazy to add
Hello
2012/12/10 Peter Geoghegan pe...@2ndquadrant.com:
So, I took a look at this, and made some more changes.
I have a hard time seeing the utility of some fields that were in this
patch, and so they have been removed from this revision.
Consider, for example:
+ constraint_table text,
Hello
2012/12/10 Peter Geoghegan pe...@2ndquadrant.com:
On 10 December 2012 20:52, David Johnston pol...@yahoo.com wrote:
Just skimming this topic but if these enhanced error fields are going to be
used by software, and we have 99% adherence to a standard, then my first
reaction is why not
On Tue, Dec 11, 2012 at 12:43 PM, Josh Kupershmidt schmi...@gmail.com wrote:
Ah, well. I guess using a macro like:
#define SafeClear(res) do {PQclear(res); res = NULL;} while (0);
will suffice for me.
Psycopg uses:
#define IFCLEARPGRES(pgres) if (pgres) {PQclear(pgres); pgres = NULL;}
--
I've been molding this patch for a while now, here's what I have this
far (also available in my git repository).
The biggest change is in the error reporting. A stand-alone program that
wants to use xlogreader.c no longer has to provide a full-blown
replacement for ereport(). The only thing
Hi,
with 9.2.2 I can see harmless cosmetic defect while dumping/restoring
database with postgis extension.
Steps to reproduce:
- create new database;
- CREATE EXTENSION IF NOT EXISTS postgis WITH SCHEMA public;
- backup it;
- create new database and restore it from this new backup.
It
On 2012-12-11 15:55:35 +0200, Heikki Linnakangas wrote:
I've been molding this patch for a while now, here's what I have this far
(also available in my git repository).
On a very quick this looks good. I will try to rebase the decoding stuff
and read a bit around in the course of that...
The
On 2012-12-11 16:34:35 +0200, Gražvydas Valeika wrote:
with 9.2.2 I can see harmless cosmetic defect while dumping/restoring
database with postgis extension.
Steps to reproduce:
- create new database;
- CREATE EXTENSION IF NOT EXISTS postgis WITH SCHEMA public;
- backup it;
- create new
On Tue, Dec 11, 2012 at 6:14 PM, Heikki Linnakangas
hlinnakan...@vmware.com wrote:
On 11.12.2012 08:07, Kyotaro HORIGUCHI wrote:
The cause is that CheckRecoveryConsistency() is called before rm_redo(),
as Horiguchi-san suggested upthead. Imagine the case where
minRecoveryPoint is set to the
On Sat, Dec 8, 2012 at 08:59:00AM -0500, Phil Sorber wrote:
On Sat, Dec 8, 2012 at 7:50 AM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Fri, Dec 7, 2012 at 12:56 PM, Phil Sorber p...@omniti.com wrote:
Something I was just thinking about while testing this again. I
mentioned the
Now it works in most of the cases, here is one more point about the patch.
* In case we have hstore--1.3.sql file and want to install that file, but
failed because of default_full_version.
No default_full_version specified
---
postgres=# CREATE
On 11 December 2012 12:18, Boszormenyi Zoltan z...@cybertec.at wrote:
Such mechanism already exist - you just need to set
your PGresult pointer to NULL after each PQclear().
So why doesn't PQclear() do that?
Because then PQclear() would need a ** not a *. Do you want its
interface changed
On Mon, Dec 10, 2012 at 08:04:55PM -0500, Robert Haas wrote:
You know, I hadn't been taking that option terribly seriously, but
maybe we ought to reconsider it. It would certainly be simpler, and
as you point out, it's not really any worse from an MVCC point of view
than anything else we do.
Amit Kapila amit.kap...@huawei.com writes:
On Tuesday, December 11, 2012 5:25 AM Jaime Casanova wrote:
can we at least send the source file in the error message when a
parameter has a wrong value?
suppose you do: SET PERSISTENT shared_preload_libraries TO
'some_nonexisting_lib';
when you
On 2012-12-11 15:44:39 +0100, Andres Freund wrote:
On 2012-12-11 15:55:35 +0200, Heikki Linnakangas wrote:
* It's pretty ugly that to use the rm_desc functions, you have to provide
dummy implementations of a bunch of backend functions, including pfree() and
timestamptz_to_str(). Should find
On 2012-12-11 16:43:12 +0100, Andres Freund wrote:
On 2012-12-11 15:44:39 +0100, Andres Freund wrote:
On 2012-12-11 15:55:35 +0200, Heikki Linnakangas wrote:
* It's pretty ugly that to use the rm_desc functions, you have to provide
dummy implementations of a bunch of backend functions,
On 11.12.2012 17:04, Fujii Masao wrote:
On Tue, Dec 11, 2012 at 6:14 PM, Heikki Linnakangas
hlinnakan...@vmware.com wrote:
On 11.12.2012 08:07, Kyotaro HORIGUCHI wrote:
The cause is that CheckRecoveryConsistency() is called before rm_redo(),
as Horiguchi-san suggested upthead. Imagine the
On 11.12.2012 17:04, Fujii Masao wrote:
The patch looks good. I confirmed that the PANIC error didn't happen,
with the patch.
Ok, committed, and also moved the CheckRecoveryConsistency call. Please
take a look to double-check that I didn't miss anything.
- Heikki
--
Sent via pgsql-hackers
On 12/9/2012 2:37 PM, Kevin Grittner wrote:
Jan Wieck wrote:
Based on the discussion and what I feel is a consensus I have
created an updated patch that has no GUC at all. The hard coded
parameters in include/postmaster/autovacuum.h are
AUTOVACUUM_TRUNCATE_LOCK_CHECK_INTERVAL 20 /* ms */
Pavel Stehule pavel.steh...@gmail.com writes:
/* if we are doing RAISE, don't report its location */
if (estate-err_text == raise_skip_msg)
return;
It is some what we want?
My recollection is that that special case was added because people
complained about the
Hi Josh,
I've signed up to review this patch.
I configured with assertions, built, and tested using
the attached script. It seems to do what it's supposed
to and the code looks ok to me.
The docs build. The text is reasonable.
I also diffed the output of the attached script with
the output
On 2012-12-11 15:55:35 +0200, Heikki Linnakangas wrote:
I've been molding this patch for a while now, here's what I have this far
(also available in my git repository).
The biggest change is in the error reporting. A stand-alone program that
wants to use xlogreader.c no longer has to provide
2012/12/11 Tom Lane t...@sss.pgh.pa.us:
Pavel Stehule pavel.steh...@gmail.com writes:
/* if we are doing RAISE, don't report its location */
if (estate-err_text == raise_skip_msg)
return;
It is some what we want?
My recollection is that that special case was
On Tue, Dec 4, 2012 at 12:10 PM, Pavan Deolasee
pavan.deola...@gmail.com wrote:
Hmm. Yeah, I do not have guts to prove that either. I'll probably write up a
comment for your consideration to explain why we don't trust PD_ALL_VISIBLE
in Hot standby for seq scans, but still trust VM for
On Tue, Dec 11, 2012 at 1:46 PM, Karl O. Pinc k...@meme.com wrote:
Yes, the current pg_restore silently
ignores multiple --table arguments, and seems to use the last
one. You are introducing a backwards incompatible
change here. I don't know what to do about it, other
than perhaps to have
On Tue, Dec 11, 2012 at 9:44 AM, Andres Freund and...@2ndquadrant.com wrote:
* How about we move pg_xlogdump to contrib? It doesn't feel like the kind of
essential tool that deserves to be in src/bin.
contrib would be fine, but I think src/bin is better. There have been
quite some bugs by now
On Fri, Dec 7, 2012 at 04:49:19PM -0500, Bruce Momjian wrote:
On Fri, Dec 7, 2012 at 10:38:39PM +0100, Andres Freund wrote:
On 2012-12-07 16:30:36 -0500, Bruce Momjian wrote:
On Fri, Dec 7, 2012 at 04:21:48PM -0500, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
On
On 2012-12-11 15:12:37 -0500, Bruce Momjian wrote:
On Fri, Dec 7, 2012 at 04:49:19PM -0500, Bruce Momjian wrote:
On Fri, Dec 7, 2012 at 10:38:39PM +0100, Andres Freund wrote:
On 2012-12-07 16:30:36 -0500, Bruce Momjian wrote:
On Fri, Dec 7, 2012 at 04:21:48PM -0500, Tom Lane wrote:
On Mon, Dec 10, 2012 at 5:18 PM, Peter Eisentraut pete...@gmx.net wrote:
On 12/8/12 9:40 AM, Tom Lane wrote:
I'm tempted to propose that REINDEX CONCURRENTLY simply not try to
preserve the index name exactly. Something like adding or removing
trailing underscores would probably serve to
On Tue, Dec 11, 2012 at 09:19:34PM +0100, Andres Freund wrote:
Only 9.2 :(. Before that there was no DROP INDEX CONCURRENTLY and in 9.3
there's an actual indislive field and indisready is always set to false
there if indislive is false.
But I see no problem using !indisvalid ||
On 2012-12-11 15:23:52 -0500, Robert Haas wrote:
On Mon, Dec 10, 2012 at 5:18 PM, Peter Eisentraut pete...@gmx.net wrote:
On 12/8/12 9:40 AM, Tom Lane wrote:
I'm tempted to propose that REINDEX CONCURRENTLY simply not try to
preserve the index name exactly. Something like adding or
Jan Wieck wrote:
Cleaned up all of those.
Applied with trivial editing, mostly from a pgindent run against
modified files.
-Kevin
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
2012/12/11 Robert Haas robertmh...@gmail.com:
On Mon, Dec 3, 2012 at 9:59 AM, Kohei KaiGai kai...@kaigai.gr.jp wrote:
As we discussed before, it is hard to determine which attributes shall
be informed to extension via object_access_hook, so the proposed
post-alter hook (that allows to compare
Pavel Stehule pavel.steh...@gmail.com writes:
Some flag of RAISE statement can be solution, but I don't like it.
Probably you would to change behave for all RAISE statements in
function - not individually for one or second. And when you debug some
application, you probably invite any solution
Hi,
I don't remember that we fixed that case, I did attach a patch in the
previous email, what do you think?
Dimitri Fontaine dimi...@2ndquadrant.fr writes:
Tom Lane t...@sss.pgh.pa.us writes:
Or maybe we should disable event triggers altogether in standalone mode?
Would something as simple
Robert Haas robertmh...@gmail.com writes:
I think I'm with Heikki on this one. Dumping xlog data is useful, but
it's really for developers and troubleshooters, not something we
expect people to do on a regular basis, so contrib seems appropriate.
There are two downsides for contrib rather
Dimitri Fontaine dimi...@2ndquadrant.fr writes:
Robert Haas robertmh...@gmail.com writes:
I think I'm with Heikki on this one. Dumping xlog data is useful, but
it's really for developers and troubleshooters, not something we
expect people to do on a regular basis, so contrib seems
Andres Freund and...@2ndquadrant.com writes:
pg_restore: [archiver (db)] Error from TOC entry 3874; 2618 396850 RULE
geometry_columns_delete postgres
pg_restore: [archiver (db)] could not execute query: ERROR: rule
geometry_columns_delete for relation geometry_columns already exists
Tom Lane t...@sss.pgh.pa.us writes:
User trust, maybe, but the maintenance argument seems bogus.
We ship contrib on the same release schedule as core.
I meant maintenance as in updating the code when it needs to be, I'm not
sure contrib systematically receives the same careness as core. I have
On 11 December 2012 22:24, Tom Lane t...@sss.pgh.pa.us wrote:
TBH, I don't believe that ordinary users will need this tool at all,
ever, and thus I don't want it in src/bin/. From a packaging standpoint
it will be a lot easier if it's in contrib ... otherwise I'll probably
have to invent some
Peter Geoghegan pe...@2ndquadrant.com writes:
Perhaps people who live in countries with less bandwidth care about
these things more.
The day they will need it is not the day the bandwidth will magically
increase, is all I'm saying. Better have that around just in case you
get WAL corruption
Hi,
When initiating a new logical replication slot I want to provide a
'SET TRANSACTION SNAPSHOT'able snapshot which can be used to setup a new
replica. I have some questions arround this where I could use some input
on.
First, some basics around how this currently works:
Test the other side:
On 11/23/12 5:57 AM, Amit kapila wrote:
Let us try to see by example:
Total RAM - 22G
Database size - 16G
...
Case -2 (Shared Buffers - 10G)
a. Load all the files in OS buffers. In best case OS buffers can contain10-12G
data as OS has 12G of memory available.
b. Try to load all in Shared
On 2012-12-11 22:52:09 +, Peter Geoghegan wrote:
On 11 December 2012 22:24, Tom Lane t...@sss.pgh.pa.us wrote:
TBH, I don't believe that ordinary users will need this tool at all,
ever, and thus I don't want it in src/bin/. From a packaging standpoint
it will be a lot easier if it's in
Dimitri Fontaine dimi...@2ndquadrant.fr writes:
I don't remember that we fixed that case, I did attach a patch in the
previous email, what do you think?
Yeah, I had forgotten about that loose end, but we definitely need
something of the sort. Committed with additional documentation.
(I put
I'm sure I've had a stroke or something in the middle of the night and just
didn't notice, but I'm able to reproduce the following on three different
hosts on both 9.2.1 and 9.2.2. As far as I know the only difference between
these queries is whitespace since I just up-arrowed them in psql and
David Gould da...@sonic.net writes:
I'm sure I've had a stroke or something in the middle of the night and just
didn't notice, but I'm able to reproduce the following on three different
hosts on both 9.2.1 and 9.2.2. As far as I know the only difference between
these queries is whitespace
On 11/20/12 8:02 PM, Craig Ringer wrote:
On 11/20/2012 04:48 PM, Pavel Stehule wrote:
I don't like to see current hstore in core - It doesn't support
nesting, it doesn't support different datatypes, it is not well
supported by plpgsql
... or by many client libraries, though converting
On Tue, Dec 11, 2012 at 6:01 PM, David Gould da...@sonic.net wrote:
I'm sure I've had a stroke or something in the middle of the night and just
didn't notice, but I'm able to reproduce the following on three different
hosts on both 9.2.1 and 9.2.2. As far as I know the only difference between
On Tue, Dec 11, 2012 at 6:52 PM, Andres Freund and...@2ndquadrant.com wrote:
One problem I see is that while exporting a snapshot solves the
visibility issues of the table's contents it does not protect against
schema changes. I am not sure whether thats a problem.
If somebody runs a CLUSTER
On Tue, 11 Dec 2012 18:58:58 -0700
Josh Kupershmidt schmi...@gmail.com wrote:
On Tue, Dec 11, 2012 at 6:01 PM, David Gould da...@sonic.net wrote:
I'm sure I've had a stroke or something in the middle of the night and just
didn't notice, but I'm able to reproduce the following on three
Joachim Wieland j...@mcknight.de writes:
On Tue, Dec 11, 2012 at 6:52 PM, Andres Freund and...@2ndquadrant.com wrote:
One problem I see is that while exporting a snapshot solves the
visibility issues of the table's contents it does not protect against
schema changes. I am not sure whether
On 12-12-11 06:52 PM, Andres Freund wrote:
Hi,
Problem 1:
One problem I see is that while exporting a snapshot solves the
visibility issues of the table's contents it does not protect against
schema changes. I am not sure whether thats a problem.
If somebody runs a CLUSTER or something
On Tue, Dec 11, 2012 at 11:46 AM, Karl O. Pinc k...@meme.com wrote:
Hi Josh,
I've signed up to review this patch.
Thanks!
I configured with assertions, built, and tested using
the attached script. It seems to do what it's supposed
to and the code looks ok to me.
The docs build. The
Heikki Linnakangas wrote:
Andres Freund's xlogreader patch contains a change to move the
declarations of SQL-callable functions in xlogfuncs.c to a new
header file, xlog_fn.h. The purpose is to allow xlog_internal.h to
be included in a frontend program, as the PG_FUNCTION_ARGS and Datum
used
Hi all
There's an issue with MSVC builds on Windows where clean.bat deletes
src\include\utils\fmgroids.h (as it should) but build.pl doesn't
re-create it reliably.
It's created fine on the first build because Gen_fmgrtab.pl is called if
src\backend\utils\fmgrtab.c is missing, which it is on
2012/12/11 Tom Lane t...@sss.pgh.pa.us:
Pavel Stehule pavel.steh...@gmail.com writes:
Some flag of RAISE statement can be solution, but I don't like it.
Probably you would to change behave for all RAISE statements in
function - not individually for one or second. And when you debug some
64 matches
Mail list logo
