Re: [HACKERS] Re: Proposal for Allow postgresql.conf values to be changed via SQL [review]

2013-01-21 Thread Andrew Dunstan
On 01/21/2013 02:17 AM, Magnus Hagander wrote: On Jan 21, 2013 3:06 AM, Craig Ringer cr...@2ndquadrant.com mailto:cr...@2ndquadrant.com wrote: On 01/21/2013 10:03 AM, Craig Ringer wrote: On 01/19/2013 04:08 AM, Boszormenyi Zoltan wrote: However, I am not sure whether Cygwin provides

Re: [HACKERS] standby, pg_basebackup and last xlog file

2013-01-21 Thread Heikki Linnakangas
On 21.01.2013 09:14, Миша Тюрин wrote: Is there any reason why pg_basebackup has limitation in an online backup from the standby: The backup history file is not created in the database cluster backed up. ? WAL archiving isn't active in a standby, so even if it created a backup history

Re: [HACKERS] [PATCH] Fix NULL checking in check_TSCurrentConfig()

2013-01-21 Thread Xi Wang
On 1/20/13 10:35 PM, Tom Lane wrote: Great catch, will commit. (But first I'm looking through commit 2594cf0e to see if I made the same mistake anywhere else :-(.) How did you find that, coverity or some such tool? Thanks for reviewing the patch. It was found using a homemade static

Re: [HACKERS] Removing PD_ALL_VISIBLE

2013-01-21 Thread Jeff Davis
On Mon, 2013-01-21 at 12:49 +0530, Pavan Deolasee wrote: At the minimum your patch will need to have one additional buffer pinned for every K 8192 * 8 heap pages. I assume it's the same K I referred to when responding to Robert: the max number of heap buffers we read before we unpin and repin

Re: [HACKERS] Visual Studio 2012 RC

2013-01-21 Thread Craig Ringer
On 01/01/2013 10:54 AM, Noah Misch wrote: On Mon, Oct 15, 2012 at 07:53:51AM -0400, Noah Misch wrote: The only matter still requiring attention is a fix for IsoLocaleName(). Following off-list coordination with Brar, I went about finishing up this patch. The above problem proved deeper than

Re: [HACKERS] Removing PD_ALL_VISIBLE

2013-01-21 Thread Heikki Linnakangas
On 21.01.2013 11:10, Jeff Davis wrote: That confuses me. The testing was to show it didn't hurt other workloads (like scans or inserts/updates/deletes); so the best possible result is that they don't show signs either way. I went back to look at the initial test results that demonstrated that

Re: [HACKERS] parallel pg_dump

2013-01-21 Thread Craig Ringer
On 12/09/2012 04:05 AM, Bruce Momjian wrote: FYI, I will be posting pg_upgrade performance numbers using Unix processes. I will try to get the Windows code working but will also need help. I'm interested ... or at least willing to help ... re the Windows side. Let me know if I can be of any

Re: [HACKERS] More subtle issues with cascading replication over timeline switches

2013-01-21 Thread Heikki Linnakangas
On 19.01.2013 14:26, Amit kapila wrote: On Friday, January 18, 2013 5:27 PM Heikki Linnakangas wrote: Indeed, looking at the pg_xlog, it's not there (I did a couple of extra timeline switches: ~/pgsql.master$ ls -l data-master/pg_xlog/ total 131084 -rw--- 1 heikki heikki 16777216 Jan

Re: [HACKERS] Visual Studio 2012 RC

2013-01-21 Thread Noah Misch
On Mon, Jan 21, 2013 at 05:32:37PM +0800, Craig Ringer wrote: On 01/01/2013 10:54 AM, Noah Misch wrote: Tester warning: if you currently have some form of VS2010 installed, including the compilers of Windows SDK 7.1, beware of this problem:

Re: [HACKERS] Visual Studio 2012 RC

2013-01-21 Thread Craig Ringer
On 01/21/2013 07:23 PM, Noah Misch wrote: What fun. Thanks for working that out. It's made even more fun by Microsoft's answer to how do I silent-install the VS 2012 SP1 compiler update - you don't. Yeah, it's great. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] Re: Proposal for Allow postgresql.conf values to be changed via SQL [review]

2013-01-21 Thread Magnus Hagander
On Mon, Jan 21, 2013 at 9:01 AM, Andrew Dunstan and...@dunslane.net wrote: On 01/21/2013 02:17 AM, Magnus Hagander wrote: On Jan 21, 2013 3:06 AM, Craig Ringer cr...@2ndquadrant.com mailto:cr...@2ndquadrant.com wrote: On 01/21/2013 10:03 AM, Craig Ringer wrote: On 01/19/2013 04:08

Re: [HACKERS] Visual Studio 2012 RC

2013-01-21 Thread Andrew Dunstan
On 01/21/2013 04:32 AM, Craig Ringer wrote: On 01/01/2013 10:54 AM, Noah Misch wrote: On Mon, Oct 15, 2012 at 07:53:51AM -0400, Noah Misch wrote: The only matter still requiring attention is a fix for IsoLocaleName(). Following off-list coordination with Brar, I went about finishing up this

Re: Review of pg_basebackup and pg_receivexlog to use non-blocking socket communication, was: Re: [HACKERS] Re: [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown

2013-01-21 Thread Magnus Hagander
On Fri, Jan 18, 2013 at 7:50 AM, Amit Kapila amit.kap...@huawei.com wrote: On Wednesday, January 16, 2013 4:02 PM Heikki Linnakangas wrote: On 07.01.2013 16:23, Boszormenyi Zoltan wrote: Since my other patch against pg_basebackup is now committed, this patch doesn't apply cleanly, patch

Re: [HACKERS] parallel pg_dump

2013-01-21 Thread Craig Ringer
On 01/21/2013 06:02 PM, Craig Ringer wrote: On 12/09/2012 04:05 AM, Bruce Momjian wrote: FYI, I will be posting pg_upgrade performance numbers using Unix processes. I will try to get the Windows code working but will also need help. I'm interested ... or at least willing to help ... re the

Re: [HACKERS] Re: Proposal for Allow postgresql.conf values to be changed via SQL [review]

2013-01-21 Thread Andrew Dunstan
On 01/21/2013 07:05 AM, Magnus Hagander wrote: No, I only use the client. But then I support plenty of things I don't use. Oh, I somehow thought you were. And yes, we all support things we don't use - but it certainly helps if there is *someone* out there who uses it. Having a buildfarm animal

Re: [HACKERS] Making testing on Windows easier

2013-01-21 Thread Noah Misch
On Mon, Jan 21, 2013 at 10:01:29AM +0800, Craig Ringer wrote: I've found EC2 to be unusably slow for Windows builds, with a medium instance taking an hour and a half to do a simple build and vcregress check. They're also restrictive in disk space terms, so you land up needing to add a second

Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-21 Thread Tom Lane
Pavan Deolasee pavan.deola...@gmail.com writes: On Sun, Jan 20, 2013 at 4:29 AM, Tom Lane t...@sss.pgh.pa.us wrote: As submitted, this broke pg_dump for dumping from pre-8.0 servers. (7.4 didn't accept commas in SET TRANSACTION syntax, and versions before that didn't have the READ ONLY option

Re: [HACKERS] Making testing on Windows easier

2013-01-21 Thread Craig Ringer
On 01/21/2013 08:55 PM, Noah Misch wrote: On Mon, Jan 21, 2013 at 10:01:29AM +0800, Craig Ringer wrote: I've found EC2 to be unusably slow for Windows builds, with a medium instance taking an hour and a half to do a simple build and vcregress check. They're also restrictive in disk space

Re: [HACKERS] gistchoose vs. bloat

2013-01-21 Thread Tom Lane
Jeff Davis pg...@j-davis.com writes: On Mon, 2013-01-21 at 00:48 -0500, Tom Lane wrote: I looked at this patch. ISTM we should not have the option at all but just do it always. I cannot believe that always-go-left is ever a preferable strategy in the long run; the resulting imbalance in the

Re: [HACKERS] Visual Studio 2012 RC

2013-01-21 Thread Craig Ringer
On 01/21/2013 08:44 PM, Andrew Dunstan wrote: On 01/21/2013 04:32 AM, Craig Ringer wrote: On 01/01/2013 10:54 AM, Noah Misch wrote: On Mon, Oct 15, 2012 at 07:53:51AM -0400, Noah Misch wrote: The only matter still requiring attention is a fix for IsoLocaleName(). Following off-list

[HACKERS] Re: Doc patch making firm recommendation for setting the value of commit_delay

2013-01-21 Thread Noah Misch
On Mon, Jan 21, 2013 at 12:23:21AM +, Peter Geoghegan wrote: On 19 January 2013 20:38, Noah Misch n...@leadboat.com wrote: staticloud.com seems to be gone. Would you repost these? I've pushed these to a git repo, hosted on github.

Re: [HACKERS] Making testing on Windows easier

2013-01-21 Thread Dave Page
On Mon, Jan 21, 2013 at 1:00 PM, Craig Ringer cr...@2ndquadrant.com wrote: On 01/21/2013 08:55 PM, Noah Misch wrote: On Mon, Jan 21, 2013 at 10:01:29AM +0800, Craig Ringer wrote: I've found EC2 to be unusably slow for Windows builds, with a medium instance taking an hour and a half to do a

Re: [HACKERS] gistchoose vs. bloat

2013-01-21 Thread Heikki Linnakangas
On 21.01.2013 15:06, Tom Lane wrote: Jeff Davispg...@j-davis.com writes: On Mon, 2013-01-21 at 00:48 -0500, Tom Lane wrote: I looked at this patch. ISTM we should not have the option at all but just do it always. I cannot believe that always-go-left is ever a preferable strategy in the long

Re: [HACKERS] Making testing on Windows easier

2013-01-21 Thread Andrew Dunstan
On 01/21/2013 08:11 AM, Dave Page wrote: I was never able to determine why the Windows instances were so much slower than the corresponding Linux instance of the same type. Full vs. para-virtualisation perhaps? No, Windows builds just are slower. For some time the buildfarm has been

Re: [HACKERS] Making testing on Windows easier

2013-01-21 Thread Dave Page
On Mon, Jan 21, 2013 at 1:59 PM, Andrew Dunstan and...@dunslane.net wrote: On 01/21/2013 08:11 AM, Dave Page wrote: I was never able to determine why the Windows instances were so much slower than the corresponding Linux instance of the same type. Full vs. para-virtualisation perhaps?

Re: [HACKERS] Making testing on Windows easier

2013-01-21 Thread Magnus Hagander
On Mon, Jan 21, 2013 at 3:03 PM, Dave Page dp...@pgadmin.org wrote: On Mon, Jan 21, 2013 at 1:59 PM, Andrew Dunstan and...@dunslane.net wrote: On 01/21/2013 08:11 AM, Dave Page wrote: I was never able to determine why the Windows instances were so much slower than the corresponding Linux

Re: [HACKERS] More subtle issues with cascading replication over timeline switches

2013-01-21 Thread Heikki Linnakangas
On 18.01.2013 13:57, Heikki Linnakangas wrote: When a standby starts up, and catches up with the master through the archive, it copies the target timeline's history file from the archive to pg_xlog. That's enough for that standby's purposes, but if there is a cascading standby or pg_receivexlog

Re: [HACKERS] pg_upgrade and system() return value

2013-01-21 Thread Bruce Momjian
On Sun, Jan 20, 2013 at 11:14:47AM -0500, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Can someone comment on the attached patch? pg_upgrade was testing if system() returned a non-zero value, while I am thinking I should be adjusting system()'s return value with WEXITSTATUS().

Re: [HACKERS] Doc patch making firm recommendation for setting the value of commit_delay

2013-01-21 Thread Peter Geoghegan
On 21 January 2013 13:10, Noah Misch n...@leadboat.com wrote: What filesystem did you use for testing? Would you also provide /proc/cpuinfo or a rough description of the system's CPUs? Unfortunately, I don't have access to that server at the moment. It's under Greg Smith's control. I believe

Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-21 Thread Robert Haas
On Mon, Jan 21, 2013 at 8:00 AM, Tom Lane t...@sss.pgh.pa.us wrote: Pavan Deolasee pavan.deola...@gmail.com writes: On Sun, Jan 20, 2013 at 4:29 AM, Tom Lane t...@sss.pgh.pa.us wrote: As submitted, this broke pg_dump for dumping from pre-8.0 servers. (7.4 didn't accept commas in SET

Re: [HACKERS] ALTER command reworks

2013-01-21 Thread Alvaro Herrera
Tom Lane escribió: Kohei KaiGai kai...@kaigai.gr.jp writes: About ALTER FUNCTION towards aggregate function, why we should raise an error strictly? I agree we probably shouldn't --- traditionally we have allowed that, AFAIR, so changing it would break existing applications for little

Re: [HACKERS] pg_ctl idempotent option

2013-01-21 Thread Phil Sorber
On Fri, Jan 18, 2013 at 8:48 PM, Phil Sorber p...@omniti.com wrote: +1 Is there more work being done on this, or is the current patch ready to review? -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Teaching pg_receivexlog to follow timeline switches

2013-01-21 Thread Phil Sorber
On Fri, Jan 18, 2013 at 7:55 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 18.01.2013 06:38, Phil Sorber wrote: Is it possible to re-use walreceiver code from the backend? I was thinking that it would actually be very useful to have the whole replication functionality modularized

Re: [HACKERS] Review: Patch to compute Max LSN of Data Pages

2013-01-21 Thread Amit kapila
On Sunday, January 20, 2013 10:50 AM Amit kapila wrote: On Sunday, January 20, 2013 4:04 AM Dickson S. Guedes wrote: 2013/1/18 Amit kapila amit.kap...@huawei.com: Please find the rebased Patch for Compute MAX LSN. The function 'remove_parent_refernces' couldn't be called

Re: [HACKERS] Request for vote to move forward with recovery.conf overhaul

2013-01-21 Thread Phil Sorber
On Fri, Dec 21, 2012 at 2:46 PM, Bruce Momjian br...@momjian.us wrote: There has been discussion in the past of removing or significantly changing the way streaming replication/point-in-time-recovery (PITR) is setup in Postgres. Currently the file recovery.conf is used, but that was designed

Re: [HACKERS] Re: [PATCH] unified frontend support for pg_malloc et al and palloc/pfree mulation (was xlogreader-v4)

2013-01-21 Thread Steve Singer
On 13-01-21 02:28 AM, Andres Freund wrote: I haven't removed it from the patch afaik, so it would be great to get a profile here! Its only for xlogdump, but that tool helped me immensely and I don't want to maintain it independently... Here is the output from tprof Here is the baseline:

Re: [HACKERS] Re: [PATCH] unified frontend support for pg_malloc et al and palloc/pfree mulation (was xlogreader-v4)

2013-01-21 Thread Andres Freund
On 2013-01-21 11:59:18 -0500, Steve Singer wrote: On 13-01-21 02:28 AM, Andres Freund wrote: I haven't removed it from the patch afaik, so it would be great to get a profile here! Its only for xlogdump, but that tool helped me immensely and I don't want to maintain it independently... Here

[HACKERS] [PATCH] pg_isready (was: [WIP] pg_ping utility)

2013-01-21 Thread Phil Sorber
Changing up the subject line because this is no longer a work in progress nor is it pg_ping anymore. On Sun, Jan 20, 2013 at 10:36 PM, Craig Ringer cr...@2ndquadrant.com wrote: On 01/21/2013 11:26 AM, Robert Haas wrote: On Sun, Jan 20, 2013 at 2:59 PM, Phil Sorber p...@omniti.com wrote: Ok. I

Re: [HACKERS] Event Triggers: adding information

2013-01-21 Thread Dimitri Fontaine
Robert Haas robertmh...@gmail.com writes: Ok. Will prepare a non controversial patch for ddl_command_end. Thanks. I will make a forceful effort to review that in a timely fashion when it's posted. Please find it attached to this email. COLUMNS=72 git diff --stat

Re: [HACKERS] count(*) of zero rows returns 1

2013-01-21 Thread Marti Raudsepp
On Tue, Jan 15, 2013 at 5:47 AM, Gurjeet Singh singh.gurj...@gmail.com wrote: postgres=# select * from test_0_col_table ; -- (20 rows) Interestingly, PostgreSQL 9.2 has regressed here. Not sure if we care, but worth mentioning: psql (9.2.2) test=# select count(*) from foo1; count

Re: [HACKERS] proposal: fix corner use case of variadic fuctions usage

2013-01-21 Thread Pavel Stehule
Hello 2013/1/19 Tom Lane t...@sss.pgh.pa.us: Pavel Stehule pavel.steh...@gmail.com writes: 2013/1/18 Tom Lane t...@sss.pgh.pa.us: The approach is also inherently seriously inefficient. ... What is important - for this use case - there is simple and perfect possible optimization - in this

Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-21 Thread Stefan Kaltenbrunner
On 01/21/2013 02:00 PM, Tom Lane wrote: Pavan Deolasee pavan.deola...@gmail.com writes: On Sun, Jan 20, 2013 at 4:29 AM, Tom Lane t...@sss.pgh.pa.us wrote: As submitted, this broke pg_dump for dumping from pre-8.0 servers. (7.4 didn't accept commas in SET TRANSACTION syntax, and versions

[HACKERS] [PATCH] PQping Docs

2013-01-21 Thread Phil Sorber
Attached is a patch that adds a note about the FATAL messages that appear in the logs if you don't pass a valid user or dbname to PQping or PQpingParams. This was requested in the pg_isready thread. libpq_pqping_doc.diff Description: Binary data -- Sent via pgsql-hackers mailing list

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-21 Thread Josh Berkus
IMHO that's the single most important task of a review. Really? I'd say the most important task for a review is does the patch do what it says it does?. That is, if the patch is supposed to implement feature X, does it actually? If it's a performance patch, does performance actually improve?

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-21 Thread Tom Lane
Josh Berkus j...@agliodbs.com writes: IMHO that's the single most important task of a review. Really? I'd say the most important task for a review is does the patch do what it says it does?. That is, if the patch is supposed to implement feature X, does it actually? If it's a performance

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-21 Thread Josh Berkus
But even before that, you have to ask whether what it's supposed to do is something we want. The reviewer can't usually answer that though. -- Josh Berkus PostgreSQL Experts Inc. http://pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] count(*) of zero rows returns 1

2013-01-21 Thread Tom Lane
Marti Raudsepp ma...@juffo.org writes: Interestingly, PostgreSQL 9.2 has regressed here. Not sure if we care, but worth mentioning: Regressed? The output looks the same to me as it has for some time. test=# select * from foo1; (No rows) Time: 1012.567 ms How did you get that? I don't

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-21 Thread Robert Haas
On Mon, Jan 21, 2013 at 2:09 PM, Josh Berkus j...@agliodbs.com wrote: But even before that, you have to ask whether what it's supposed to do is something we want. The reviewer can't usually answer that though. They can answer whether THEY want it, though. And Tom, Andrew, and I all just got

Re: [HACKERS] pg_dump transaction's read-only mode

2013-01-21 Thread Tom Lane
Stefan Kaltenbrunner ste...@kaltenbrunner.cc writes: On 01/21/2013 02:00 PM, Tom Lane wrote: (It's entirely likely that the 7.0 server I keep around for testing this is the last one in captivity anywhere. But IIRC, we've heard fairly recent reports of people still using 7.2. We'd have to

Re: [HACKERS] count(*) of zero rows returns 1

2013-01-21 Thread Marti Raudsepp
On Mon, Jan 21, 2013 at 9:33 PM, Tom Lane t...@sss.pgh.pa.us wrote: test=# select * from foo1; (No rows) Time: 1012.567 ms How did you get that? I don't believe it's possible in the default output format. Oh I see, it's because I have \x auto in my .psqlrc. If I set \x auto or \x on then

Re: [HACKERS] Removing PD_ALL_VISIBLE

2013-01-21 Thread Robert Haas
On Mon, Jan 21, 2013 at 1:52 AM, Jeff Davis pg...@j-davis.com wrote: Of course, there is an argument that this patch will simplify the code, but I'm not sure if its enough to justify the additional contention which may or may not show up in the benchmarks we are running, but we know its

Re: [HACKERS] Re: [PATCH] unified frontend support for pg_malloc et al and palloc/pfree mulation (was xlogreader-v4)

2013-01-21 Thread Steve Singer
On 13-01-21 12:15 PM, Andres Freund wrote: On 2013-01-21 11:59:18 -0500, Steve Singer wrote: On 13-01-21 02:28 AM, Andres Freund wrote: I haven't removed it from the patch afaik, so it would be great to get a profile here! Its only for xlogdump, but that tool helped me immensely and I don't

Re: [HACKERS] Teaching pg_receivexlog to follow timeline switches

2013-01-21 Thread Noah Misch
This patch was in Needs Review status, but you committed it on 2013-01-17. I have marked it as such in the CF app. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-21 Thread Dimitri Fontaine
Robert Haas robertmh...@gmail.com writes: On Sun, Jan 20, 2013 at 7:07 PM, Jeff Janes jeff.ja...@gmail.com wrote: As a junior reviewer, I'd like to know if my main task should be to decide between 1) writing a review convincing you or Tom that your judgement is hasty, or 2) to convince the

Re: [HACKERS] Event Triggers: adding information

2013-01-21 Thread Robert Haas
On Mon, Jan 21, 2013 at 12:27 PM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Please find it attached to this email. Nice clean patch, thanks! Committed, after tinkering with the CommandCounterIncrement() stuff a bit. I will respond to the rest of your email later. Reading through this

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-21 Thread Phil Sorber
On Wed, Jan 16, 2013 at 8:18 AM, Abhijit Menon-Sen a...@2ndquadrant.com wrote: Here's a breakdown based purely on the names from the CF page (i.e. I didn't check archives to see who actually posted reviews, and didn't take into account reviews posted without updating the CF page). FWIW, I

Re: [HACKERS] Request for vote to move forward with recovery.conf overhaul

2013-01-21 Thread Michael Paquier
On Tue, Jan 22, 2013 at 1:11 AM, Phil Sorber p...@omniti.com wrote: On Fri, Dec 21, 2012 at 2:46 PM, Bruce Momjian br...@momjian.us wrote: There has been discussion in the past of removing or significantly changing the way streaming replication/point-in-time-recovery (PITR) is setup in

[HACKERS] Prepared statements fail after schema changes with surprising error

2013-01-21 Thread Peter van Hardenberg
A user reported an interesting issue today. After restoring a dump created with --clean on a running application in his development environment his application started complaining of missing tables despite those tables very clearly existing. After a little thinking, we determined that this was

Re: [HACKERS] Event Triggers: adding information

2013-01-21 Thread Dickson S. Guedes
2013/1/21 Robert Haas robertmh...@gmail.com: Another thing is that we might want to document that if a command errors out, ddl_command_end will never be reached; and perhaps also that if ddl_command_start errors out, the command itself will never be reached. Perhaps this is so obvious as to

Re: [HACKERS] Prepared statements fail after schema changes with surprising error

2013-01-21 Thread Tom Lane
Peter van Hardenberg p...@pvh.ca writes: A user reported an interesting issue today. After restoring a dump created with --clean on a running application in his development environment his application started complaining of missing tables despite those tables very clearly existing. After a

Re: [HACKERS] Re: Slave enters in recovery and promotes when WAL stream with master is cut + delay master/slave

2013-01-21 Thread Michael Paquier
On Fri, Jan 18, 2013 at 6:20 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: Hmm, so it's the same issue I thought I fixed yesterday. My patch only fixed it for the case that the timeline switch is in the first page of the segment. When it's not, you still get two calls for a WAL

Re: [HACKERS] Re: Slave enters in recovery and promotes when WAL stream with master is cut + delay master/slave

2013-01-21 Thread Michael Paquier
On Tue, Jan 22, 2013 at 9:06 AM, Michael Paquier michael.paqu...@gmail.comwrote: On Fri, Jan 18, 2013 at 6:20 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: Hmm, so it's the same issue I thought I fixed yesterday. My patch only fixed it for the case that the timeline switch is in

Re: [HACKERS] Request for vote to move forward with recovery.conf overhaul

2013-01-21 Thread Robert Haas
On Mon, Jan 21, 2013 at 6:23 PM, Michael Paquier michael.paqu...@gmail.com wrote: Yes, that is one of the most important patches in the list, and I could put some effort in it for either review or coding. I think it would be great if you could elaborate on your reasons for feeling that this

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-21 Thread Robert Haas
On Mon, Jan 21, 2013 at 6:23 PM, Phil Sorber p...@omniti.com wrote: On Wed, Jan 16, 2013 at 8:18 AM, Abhijit Menon-Sen a...@2ndquadrant.com wrote: Here's a breakdown based purely on the names from the CF page (i.e. I didn't check archives to see who actually posted reviews, and didn't take

Re: [HACKERS] Prepared statements fail after schema changes with surprising error

2013-01-21 Thread Peter Geoghegan
On 22 January 2013 00:00, Tom Lane t...@sss.pgh.pa.us wrote: Works for me ... That's what I thought. But looking at RangeVarGetRelidExtended() and recomputeNamespacePath(), do you suppose that the problem could be that access privileges used by the app differed for a schema (or, more accurately,

Re: [HACKERS] Request for vote to move forward with recovery.conf overhaul

2013-01-21 Thread Michael Paquier
On Tue, Jan 22, 2013 at 9:27 AM, Robert Haas robertmh...@gmail.com wrote: On Mon, Jan 21, 2013 at 6:23 PM, Michael Paquier michael.paqu...@gmail.com wrote: Yes, that is one of the most important patches in the list, and I could put some effort in it for either review or coding. I think

Re: [HACKERS] Prepared statements fail after schema changes with surprising error

2013-01-21 Thread Dickson S. Guedes
2013/1/21 Peter van Hardenberg p...@pvh.ca: A user reported an interesting issue today. After restoring a dump created with --clean on a running application in his development environment his application started complaining of missing tables despite those tables very clearly existing. After

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-21 Thread Robert Haas
On Mon, Jan 21, 2013 at 5:48 PM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Advice:You don't do things that way, this way is the only one we will ever accept, because we've been sweating blood over the years to get in a position where it now works.

Re: [HACKERS] Prepared statements fail after schema changes with surprising error

2013-01-21 Thread Tom Lane
Peter Geoghegan peter.geoghega...@gmail.com writes: On 22 January 2013 00:00, Tom Lane t...@sss.pgh.pa.us wrote: Works for me ... That's what I thought. But looking at RangeVarGetRelidExtended() and recomputeNamespacePath(), do you suppose that the problem could be that access privileges

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-21 Thread Josh Berkus
Robert, http://www.postgresql.org/message-id/28927.1236820...@sss.pgh.pa.us That's not a positive review, but when it comes down to it, it's a pretty factual email. IMHO, anyway, and YMMV. Really? I've always thought that was a pretty constructive review. It certainly gave me the laundry

Re: [HACKERS] dividing privileges for replication role.

2013-01-21 Thread Tomonari Katsumata
Hi, Magnus, Josh, Michael, Craig Thank you for comments and registring to CommitFest. I made a patch to divide privileges for replication role. Currently(9.2), the privilege for replication role is true / false which means that standby server is able to connect to another server or not with

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-21 Thread Phil Sorber
On Mon, Jan 21, 2013 at 8:23 PM, Robert Haas robertmh...@gmail.com wrote: What I don't like is when I (or anyone) posts a patch and somebody says something that boils down to no one wants that. *That* ticks me off. Because you know what? At a minimum, *I* want that. If I didn't, I wouldn't

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-21 Thread Phil Sorber
On Mon, Jan 21, 2013 at 8:47 PM, Josh Berkus j...@agliodbs.com wrote: My own experience is different from yours, I guess. I actually like it when I post a patch, or suggest a concept, and Tom fires back with a laundry list of reasons it won't work. This can be a problem with new submitters,

Re: [HACKERS] proposal: fix corner use case of variadic fuctions usage

2013-01-21 Thread Tom Lane
Pavel Stehule pavel.steh...@gmail.com writes: so here is rewritten patch I've applied the infrastructure parts of this, but not the changes to format() and concat(). Why are the format and concat patches so randomly different? Not only is the internal implementation completely different for no

Re: [HACKERS] dividing privileges for replication role.

2013-01-21 Thread Tom Lane
Tomonari Katsumata t.katsumata1...@gmail.com writes: Why is it better to do this with a privilege, rather than just using pg_hba.conf? You are right. Handling with pg_hba.conf is an easy way. But I think many users think about switch over, so the pg_hba.conf is same on master and standby.

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-21 Thread Robert Haas
On Mon, Jan 21, 2013 at 8:47 PM, Josh Berkus j...@agliodbs.com wrote: http://www.postgresql.org/message-id/28927.1236820...@sss.pgh.pa.us That's not a positive review, but when it comes down to it, it's a pretty factual email. IMHO, anyway, and YMMV. Really? I've always thought that was a

Re: [HACKERS] Patch for removng unused targets

2013-01-21 Thread Etsuro Fujita
I'd like to rework on this optimization and submit a patch at the next CF. Is that okay? Thanks, Best regards, Etsuro Fujita From: Craig Ringer [mailto:cr...@2ndquadrant.com] Sent: Friday, January 18, 2013 8:30 PM To: Alexander Korotkov Cc: Tom Lane; Etsuro Fujita; pgsql-hackers

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-21 Thread Pavan Deolasee
On Tue, Jan 22, 2013 at 7:57 AM, Phil Sorber p...@omniti.com wrote: On Mon, Jan 21, 2013 at 8:47 PM, Josh Berkus j...@agliodbs.com wrote: My own experience is different from yours, I guess. I actually like it when I post a patch, or suggest a concept, and Tom fires back with a laundry list of

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-21 Thread Tom Lane
Pavan Deolasee pavan.deola...@gmail.com writes: For me our reluctance for any kind of change is a major demoralizing factor. I hardly think we're reluctant for any kind of change --- the rate of commits belies that. What we want is a convincing case that a proposed change is an improvement

Re: Review of pg_basebackup and pg_receivexlog to use non-blocking socket communication, was: Re: [HACKERS] Re: [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown

2013-01-21 Thread Amit Kapila
On Monday, January 21, 2013 6:22 PM Magnus Hagander On Fri, Jan 18, 2013 at 7:50 AM, Amit Kapila amit.kap...@huawei.com wrote: On Wednesday, January 16, 2013 4:02 PM Heikki Linnakangas wrote: On 07.01.2013 16:23, Boszormenyi Zoltan wrote: Since my other patch against pg_basebackup is now

Re: [HACKERS] Patch for removng unused targets

2013-01-21 Thread Craig Ringer
On 01/22/2013 01:24 PM, Etsuro Fujita wrote: I'd like to rework on this optimization and submit a patch at the next CF. Is that okay? That sounds very sensible to me, given how busy CF2013-01 is and the remaining time before 9.3. -- Craig Ringer

Re: [HACKERS] Prepared statements fail after schema changes with surprising error

2013-01-21 Thread Peter van Hardenberg
Hm - I'm still able to recreate the test the user's running using pg_dump/pg_restore. I'm still working to see if I can minimize the test-case, but this is against 9.2.2. Would you prefer I test against HEAD? regression=# create table z1 (f1 int); CREATE TABLE regression=# prepare sz1 as select *

Re: [HACKERS] Prepared statements fail after schema changes with surprising error

2013-01-21 Thread Peter van Hardenberg
Okay - I've narrowed it down to an interaction with schema recreation. Here's a minimal test-case I created by paring back the restore from the pg_restore output until I only had the essence remaining: -- setup drop table z1; create table z1 (f1 int); insert into z1 values (1); prepare sz1 as

Re: [HACKERS] Prepared statements fail after schema changes with surprising error

2013-01-21 Thread Tom Lane
Peter van Hardenberg p...@pvh.ca writes: Okay - I've narrowed it down to an interaction with schema recreation. Here's a minimal test-case I created by paring back the restore from the pg_restore output until I only had the essence remaining: Hm ... I'm too tired to trace through the code to

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-21 Thread Magnus Hagander
On Jan 22, 2013 1:31 AM, Robert Haas robertmh...@gmail.com wrote: On Mon, Jan 21, 2013 at 6:23 PM, Phil Sorber p...@omniti.com wrote: On Wed, Jan 16, 2013 at 8:18 AM, Abhijit Menon-Sen a...@2ndquadrant.com wrote: Here's a breakdown based purely on the names from the CF page (i.e. I didn't