Re: [HACKERS] New Python vs. old PG on raccoon and jaguarundi

2014-12-20 Thread Christian Ullrich
* From: Noah Misch [mailto:n...@leadboat.com] Buildfarm member jaguarundi, which has Python 3.4, activated --with- python for REL9_1_STABLE as of its 2014-12-15 run. Please remove -- with-python or test against an older Python. It already omits --with- python for REL9_0_STABLE. Done; sorry

Re: [HACKERS] PATCH: decreasing memory needlessly consumed by array_agg

2014-12-20 Thread Ali Akbar
2014-12-16 11:01 GMT+07:00 Ali Akbar the.ap...@gmail.com: 2014-12-16 10:47 GMT+07:00 Ali Akbar the.ap...@gmail.com: 2014-12-16 6:27 GMT+07:00 Tomas Vondra t...@fuzzy.cz: Just fast-viewing the patch. The patch is not implementing the checking for not creating new context in

Re: [HACKERS] INSERT ... ON CONFLICT {UPDATE | IGNORE}

2014-12-20 Thread Martijn van Oosterhout
On Fri, Dec 19, 2014 at 05:32:43PM -0800, Peter Geoghegan wrote: Most people would list the columns, but if there is a really bizarre constraint, with non-default opclasses, or an exclusion constraint, it's probably been given a name that you could use. What I find curious about the

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2014-12-20 Thread Amit Kapila
On Wed, Dec 17, 2014 at 11:32 AM, Amit Kapila amit.kapil...@gmail.com wrote: On Tue, Dec 16, 2014 at 10:11 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 12/16/2014 06:30 PM, Andrew Dunstan wrote: I'm not clear why human readability is the major criterion here. As for that,

Re: [HACKERS] Re: [pgsql-pkg-debian] Updated libpq5 packages cause connection errors on postgresql 9.2

2014-12-20 Thread Magnus Hagander
On Fri, Dec 19, 2014 at 3:57 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: On Fri, Dec 19, 2014 at 11:52 AM, Christoph Berg c...@df7cb.de wrote: Googling for digest too big for rsa key seems to indicate that this problem occurs when you are using

Re: [HACKERS] Table-level log_autovacuum_min_duration

2014-12-20 Thread Michael Paquier
On Thu, Dec 18, 2014 at 11:15 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Michael Paquier wrote: Hi all, Today I spent a bit of time looking at the activity of autovacuum for one table particularly bloated. log_autovacuum_min_duration was enabled and set to a high value but even with

Re: [HACKERS] POLA violation with \c service=

2014-12-20 Thread David Fetter
On Fri, Dec 19, 2014 at 07:03:36PM -0700, David Johnston wrote: On Wed, Dec 17, 2014 at 8:25 AM, David Fetter [via PostgreSQL] ml-node+s1045698n5831124...@n5.nabble.com wrote: On Wed, Dec 17, 2014 at 08:14:04AM -0500, Andrew Dunstan wrote: On 12/17/2014 04:11 AM, Heikki Linnakangas

Re: [HACKERS] Initdb-cs_CZ.WIN-1250 buildfarm failures

2014-12-20 Thread Noah Misch
On Sat, Dec 20, 2014 at 05:14:03PM +0100, CSPUG wrote: On 20.12.2014 07:39, Noah Misch wrote: Buildfarm members magpie, treepie and fulmar went absent on 2014-10-29. Since returning on 2014-11-16, they have consistently failed with 'initdb: invalid locale name cs_CZ.WIN-1250'. No commits

Re: [HACKERS] [PATCH] HINT: pg_hba.conf changed since last config reload

2014-12-20 Thread Steve Singer
On 12/19/2014 10:41 AM, Alex Shulgin wrote: I don't think so. The scenario this patch relies on assumes that the DBA will remember to look in the log if something goes wrong, and in your case there would be a message like the following: WARNING: pg_hba.conf not reloaded So an extra hint

Re: [HACKERS] Initdb-cs_CZ.WIN-1250 buildfarm failures

2014-12-20 Thread Tom Lane
Noah Misch n...@leadboat.com writes: On Sat, Dec 20, 2014 at 05:14:03PM +0100, CSPUG wrote: On 20.12.2014 07:39, Noah Misch wrote: Buildfarm members magpie, treepie and fulmar went absent on 2014-10-29. Since returning on 2014-11-16, they have consistently failed with 'initdb: invalid locale

Re: [HACKERS] Initdb-cs_CZ.WIN-1250 buildfarm failures

2014-12-20 Thread Pavel Stehule
2014-12-20 17:48 GMT+01:00 Noah Misch n...@leadboat.com: On Sat, Dec 20, 2014 at 05:14:03PM +0100, CSPUG wrote: On 20.12.2014 07:39, Noah Misch wrote: Buildfarm members magpie, treepie and fulmar went absent on 2014-10-29. Since returning on 2014-11-16, they have consistently failed

Re: [HACKERS] Initdb-cs_CZ.WIN-1250 buildfarm failures

2014-12-20 Thread Tomas Vondra
On 20.12.2014 18:13, Pavel Stehule wrote: 2014-12-20 17:48 GMT+01:00 Noah Misch n...@leadboat.com $ LANG=cs_CZ.WIN-1250 locale LC_NUMERIC It is Microsoft encoding, - it is not available on Linux Not true. It is available on Linux, and the regression tests were running with it for a

Re: [HACKERS] Initdb-cs_CZ.WIN-1250 buildfarm failures

2014-12-20 Thread Pavel Stehule
2014-12-20 18:17 GMT+01:00 Tomas Vondra t...@fuzzy.cz: On 20.12.2014 18:13, Pavel Stehule wrote: 2014-12-20 17:48 GMT+01:00 Noah Misch n...@leadboat.com $ LANG=cs_CZ.WIN-1250 locale LC_NUMERIC It is Microsoft encoding, - it is not available on Linux Not true. It is available

Re: [HACKERS] Initdb-cs_CZ.WIN-1250 buildfarm failures

2014-12-20 Thread Tom Lane
Tomas Vondra t...@fuzzy.cz writes: On 20.12.2014 18:13, Pavel Stehule wrote: It is Microsoft encoding, - it is not available on Linux Not true. It is available on Linux, and the regression tests were running with it for a long time (essentially from the moment magpie was added to the

Re: [HACKERS] Initdb-cs_CZ.WIN-1250 buildfarm failures

2014-12-20 Thread Andrew Dunstan
On 12/20/2014 12:32 PM, Tom Lane wrote: Immediate recommendation is to restart the buildfarm critters with the missing locale removed from their configurations. If you can find the locale again somewhere, by all means re-enable it, but better less testing than no testing in the meantime.

Re: hash_create API changes (was Re: [HACKERS] speedup tidbitmap patch: hash BlockNumber)

2014-12-20 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: On 2014-12-19 22:03:55 -0600, Jim Nasby wrote: What I am thinking is not using all of those fields in their raw form to calculate the hash value. IE: something analogous to: hash_any(SharedBufHash, (rot(forkNum, 2) | dbNode) ^ relNode) 32 |

Re: [HACKERS] Initdb-cs_CZ.WIN-1250 buildfarm failures

2014-12-20 Thread Tomas Vondra
On 20.12.2014 17:48, Noah Misch wrote: On Sat, Dec 20, 2014 at 05:14:03PM +0100, CSPUG wrote: On 20.12.2014 07:39, Noah Misch wrote: Buildfarm members magpie, treepie and fulmar went absent on 2014-10-29. Since returning on 2014-11-16, they have consistently failed with 'initdb: invalid

Re: [HACKERS] Initdb-cs_CZ.WIN-1250 buildfarm failures

2014-12-20 Thread Tomas Vondra
On 20.12.2014 18:32, Tom Lane wrote: Tomas Vondra t...@fuzzy.cz writes: On 20.12.2014 18:13, Pavel Stehule wrote: It is Microsoft encoding, - it is not available on Linux Not true. It is available on Linux, and the regression tests were running with it for a long time (essentially from the

Re: [HACKERS] Initdb-cs_CZ.WIN-1250 buildfarm failures

2014-12-20 Thread Tom Lane
Tomas Vondra t...@fuzzy.cz writes: I believe the locale system (at the OS level) works just like before. I remember I had to manually create the locales while initially setting up the animals. Then, ~2 months ago something happened (I asssume a yum update) and some of the locales disappeared.

Re: [HACKERS] Initdb-cs_CZ.WIN-1250 buildfarm failures

2014-12-20 Thread Tom Lane
Tomas Vondra t...@fuzzy.cz writes: But clearly, something changed between RH 6.5 and 6.6, because on 6.5 I get this: $ LANG=cs_CZ.WIN-1250 locale LC_NUMERIC , � 3;3 44 160 CP1250 while on 6.6 I get this: $ LANG=cs_CZ.WIN-1250 locale LC_NUMERIC , 3;3 44 160 ANSI_X3.4-1968

Re: [HACKERS] Initdb-cs_CZ.WIN-1250 buildfarm failures

2014-12-20 Thread Tomas Vondra
On 20.12.2014 19:05, Tom Lane wrote: Tomas Vondra t...@fuzzy.cz writes: I believe the locale system (at the OS level) works just like before. I remember I had to manually create the locales while initially setting up the animals. Then, ~2 months ago something happened (I asssume a yum update)

Re: [HACKERS] Initdb-cs_CZ.WIN-1250 buildfarm failures

2014-12-20 Thread Tom Lane
Tomas Vondra t...@fuzzy.cz writes: On 20.12.2014 19:05, Tom Lane wrote: I am betting that you recreated them differently from before. And you're probably right. Apparently, I recreated them like this: $ localedef -v -c -i cs_CZ -f WIN-1250 cs_CZ.WIN-1250 but the correct way seems to

Re: [HACKERS] Initdb-cs_CZ.WIN-1250 buildfarm failures

2014-12-20 Thread CSPUG
On 20.12.2014 07:39, Noah Misch wrote: Buildfarm members magpie, treepie and fulmar went absent on 2014-10-29. Since returning on 2014-11-16, they have consistently failed with 'initdb: invalid locale name cs_CZ.WIN-1250'. No commits in that period readily explain a regression in this area.

Re: [HACKERS] Initdb-cs_CZ.WIN-1250 buildfarm failures

2014-12-20 Thread Tomas Vondra
On 20.12.2014 19:35, Tom Lane wrote: Tomas Vondra t...@fuzzy.cz writes: On 20.12.2014 19:05, Tom Lane wrote: I am betting that you recreated them differently from before. And you're probably right. Apparently, I recreated them like this: $ localedef -v -c -i cs_CZ -f WIN-1250

Re: [HACKERS] PATCH: decreasing memory needlessly consumed by array_agg

2014-12-20 Thread Tomas Vondra
Hi! First of all, thanks for the review - the insights and comments are spot-on. More comments below. On 20.12.2014 09:26, Ali Akbar wrote: 2014-12-16 11:01 GMT+07:00 Ali Akbar the.ap...@gmail.com mailto:the.ap...@gmail.com: 2014-12-16 10:47 GMT+07:00 Ali Akbar the.ap...@gmail.com

Re: [HACKERS] PATCH: decreasing memory needlessly consumed by array_agg

2014-12-20 Thread Tomas Vondra
Attached is v5 of the patch, fixing an error with releasing a shared memory context (invalid flag values in a few calls). kind regards Tomas Vondra diff --git a/src/backend/executor/nodeSubplan.c b/src/backend/executor/nodeSubplan.c index d9faf20..9c97755 100644 ---

Re: hash_create API changes (was Re: [HACKERS] speedup tidbitmap patch: hash BlockNumber)

2014-12-20 Thread Jim Nasby
On 12/20/14, 11:51 AM, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2014-12-19 22:03:55 -0600, Jim Nasby wrote: What I am thinking is not using all of those fields in their raw form to calculate the hash value. IE: something analogous to: hash_any(SharedBufHash,

Re: [HACKERS] GiST kNN search queue (Re: KNN-GiST with recheck)

2014-12-20 Thread Peter Geoghegan
On Wed, Dec 17, 2014 at 6:07 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: How about adding a src/backend/lib/README for that, per attached? I took a quick look at this. Some observations: * I like the idea of adding a .../lib README. However, the README fails to note that ilist.c

Re: [HACKERS] INSERT ... ON CONFLICT {UPDATE | IGNORE}

2014-12-20 Thread Peter Geoghegan
On Sat, Dec 20, 2014 at 2:16 AM, Martijn van Oosterhout klep...@svana.org wrote: What I find curious about the opclass thing is: when do you ever have an opclass that has a different idea of equality than the default opclass for the type? In other words, when is B-Tree strategy number 3 not

Re: [HACKERS] INSERT ... ON CONFLICT {UPDATE | IGNORE}

2014-12-20 Thread Peter Geoghegan
On Thu, Dec 18, 2014 at 9:31 AM, Peter Geoghegan p...@heroku.com wrote: So I think there needs to be some kind of logic to de-recognize the table alias foo. Once I rewrote the query to use TARGET and EXCLUDED correctly, I've put this through an adaptation of my usual torture test, and it ran

Re: [HACKERS] Role Attribute Bitmask Catalog Representation

2014-12-20 Thread Adam Brightwell
Alvaro and Stephen, I propose this patch on top of Adam's v5. Also included is a full patch against master. I have attached an updated patch for review (role-attribute-bitmask-v7.patch). This patch incorporates the 'v5a' patch proposed by Alvaro, input validation (Assert) check in

Re: [HACKERS] Doing better at HINTing an appropriate column within errorMissingColumn()

2014-12-20 Thread Peter Geoghegan
On Tue, Dec 16, 2014 at 12:18 PM, Stephen Frost sfr...@snowman.net wrote: * Tom Lane (t...@sss.pgh.pa.us) wrote: So my two cents is that when considering a qualified name, this patch should take levenshtein distance across the two components equally. There's no good reason to suppose that

Re: [HACKERS] Doing better at HINTing an appropriate column within errorMissingColumn()

2014-12-20 Thread Peter Geoghegan
On Sat, Dec 20, 2014 at 3:17 PM, Peter Geoghegan p...@heroku.com wrote: Attached patch implements this scheme. I had another thought: NAMEDATALEN + 1 is a better representation of infinity for matching purposes than INT_MAX. I probably should have made that change, too. It would then not have

Re: [HACKERS] PATCH: decreasing memory needlessly consumed by array_agg

2014-12-20 Thread Alvaro Herrera
Tomas Vondra wrote: Attached is v5 of the patch, fixing an error with releasing a shared memory context (invalid flag values in a few calls). The functions that gain a new argument should get their comment updated, to explain what the new argument is for. Also, what is it with this hunk? @@

Re: [HACKERS] Parallel Seq Scan

2014-12-20 Thread Amit Kapila
On Fri, Dec 19, 2014 at 6:21 PM, Stephen Frost sfr...@snowman.net wrote: Amit, * Amit Kapila (amit.kapil...@gmail.com) wrote: 1. Parallel workers help a lot when there is an expensive qualification to evaluated, the more expensive the qualification the more better are results. I'd