Re: [HACKERS] Rework the way multixact truncations work

2015-10-24 Thread Noah Misch
I'm several days into a review of this change (commits 4f627f8 and aa29c1c). There's one part of the design I want to understand before commenting on specific code. What did you anticipate to be the consequences of failing to remove SLRU segment files that MultiXactState->oldestMultiXactId implies

Re: [HACKERS] [patch] extensions_path GUC

2015-10-24 Thread David E. Wheeler
On Oct 23, 2015, at 9:26 AM, Jim Nasby wrote: > I would love it if make check worked. make installcheck adds extra effort to > extension develoopment, not to mention leaving your actual install in a less > than pristine state. I’ve wanted this for a long time. I think it would have to create a

Re: [HACKERS] Parallel Seq Scan

2015-10-24 Thread Noah Misch
On Sat, Oct 24, 2015 at 07:49:07AM -0400, Robert Haas wrote: > On Fri, Oct 23, 2015 at 9:38 PM, Noah Misch wrote: > > Since that specification permits ParamListInfo consumers to ignore > > paramMask, > > the plpgsql_param_fetch() change from copy-paramlistinfo-fixes.patch is > > still > > formal

Re: [HACKERS] JDBC driver debug out?

2015-10-24 Thread Tatsuo Ishii
Thanks. It works. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp > Add > > DriverManager.setLogWriter(new PrintWriter(System.out)); > > below the setLogLevel and it will > > I'll fix this though > > Dave Cramer

Re: [HACKERS] Proposal: Trigonometric functions in degrees

2015-10-24 Thread Simon Riggs
On 24 October 2015 at 05:24, Dean Rasheed wrote: > Currently PostgreSQL only has trigonometric functions that work in > radians. I think it would be quite useful to have an equivalent set of > functions that worked in degrees. In other environments these are > commonly spelled sind(), cosd(), etc

Re: [HACKERS] Patch (2): Implement failover on libpq connect level.

2015-10-24 Thread Robert Haas
On Fri, Oct 23, 2015 at 4:02 PM, Korry Douglas wrote: > When you call pg_is_in_recovery(), you should schema-qualify the function > name, just in case some other version of that function exists in the > search_path. I wonder whether it's really a good idea to put this kind of logic into libpq at

Re: [HACKERS] Parallel Seq Scan

2015-10-24 Thread Robert Haas
On Fri, Oct 23, 2015 at 9:38 PM, Noah Misch wrote: > Since that specification permits ParamListInfo consumers to ignore paramMask, > the plpgsql_param_fetch() change from copy-paramlistinfo-fixes.patch is still > formally required. So why am I not just doing that, then? Seems a lot more surgical

Re: [HACKERS] JDBC driver debug out?

2015-10-24 Thread Dave Cramer
Add DriverManager.setLogWriter(new PrintWriter(System.out)); below the setLogLevel and it will I'll fix this though Dave Cramer da...@postgresintl.com www.postgresintl.com On 23 October 2015 at 22:35, Tatsuo Ishii wrote: > Unfortunately it doesn't work (no debug trace). > > Best regards, >

[HACKERS] Proposal: Trigonometric functions in degrees

2015-10-24 Thread Dean Rasheed
Currently PostgreSQL only has trigonometric functions that work in radians. I think it would be quite useful to have an equivalent set of functions that worked in degrees. In other environments these are commonly spelled sind(), cosd(), etc. Partly, this would be a matter of convenience. It's quit

Re: [HACKERS] Freeze avoidance of very large table.

2015-10-24 Thread Masahiko Sawada
On Sat, Oct 24, 2015 at 10:59 AM, Amit Kapila wrote: > On Mon, Oct 5, 2015 at 9:53 PM, Masahiko Sawada > wrote: >> >> On Mon, Oct 5, 2015 at 11:03 PM, Fujii Masao >> wrote: >> > On Fri, Oct 2, 2015 at 8:14 PM, Masahiko Sawada >> > wrote: >> >>> +#define Anum_pg_class_relallfrozen12 >> >

Re: [HACKERS] Allow ssl_renegotiation_limit in PG 9.5

2015-10-24 Thread Shay Rojansky
> > > Here's a patch that adds back the GUC, with default/min/max 0 and > > GUC_NO_SHOW_ALL | GUC_NOT_IN_SAMPLE | GUC_DISALLOW_IN_FILE. > > > > This is my first pg patch, please be gentle with any screwups :) > > Why, you dummy. > > No, actually, this looks fine. I've committed it and back-patched