Re: [HACKERS] Relax requirement for INTO with SELECT in pl/pgsql

2016-06-05 Thread Pavel Stehule
2016-06-05 5:45 GMT+02:00 David G. Johnston : > On Tuesday, March 22, 2016, Merlin Moncure wrote: > >> >> Anyways, here's the patch with documentation adjustments as promised. >> I ended up keeping the 'without result' section because it contained >> useful information about plan caching, >> >> m

[HACKERS] Reference to UT1

2016-06-05 Thread Thomas Munro
Hi The manual[1] says "Technically,PostgreSQL uses UT1 rather than UTC because leap seconds are not handled." I'm certainly no expert on this stuff but it seems to me that we are using POSIX time[2] or Unix time, not UT1. By my reading, UT1 is one of several time scales of interest to scientists

Re: [HACKERS] pg9.6 segfault using simple query (related to use fk for join estimates)

2016-06-05 Thread Tomas Vondra
Hi, While this thread was effectively superseded by the 'new design' thread [1], I'd like to address a few points raised here, as they are relevant for the new design (at least I believe so). [1] https://www.postgresql.org/message-id/31041.1465069...@sss.pgh.pa.us On 06/04/2016 08:15 PM, Tom

Re: [HACKERS] New design for FK-based join selectivity estimation

2016-06-05 Thread Tomas Vondra
Hi, On 06/04/2016 09:44 PM, Tom Lane wrote: This is a branch of the discussion in https://www.postgresql.org/message-id/flat/20160429102531.GA13701%40huehner.biz but I'm starting a new thread as the original title is getting increasingly off-topic. I complained in that thread that the FK join s

[HACKERS] Typo in parallel comment of heap_delete()

2016-06-05 Thread Jim Nasby
I'm pretty sure this is a typo... -- Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX Experts in Analytics, Data Architecture and PostgreSQL Data in Trouble? Get it in Treble! http://BlueTreble.com 855-TREBLE2 (855-873-2532) mobile: 512-569-9461 diff --git a/src/backend/access/heap/h

Re: [HACKERS] Parallel query and temp_file_limit

2016-06-05 Thread Peter Geoghegan
On Wed, May 18, 2016 at 12:01 PM, Peter Geoghegan wrote: >> I think for 9.6 we just have to document this issue. In the next >> release, we could (and might well want to) try to do something more >> clever. > > Works for me. You may wish to update comments within fd.c at the same time. I've crea

Re: [HACKERS] New design for FK-based join selectivity estimation

2016-06-05 Thread Tom Lane
I wrote: > ... Here is a sketch of what I think is a better way: > ... > It's possible that we could reduce the cost of matching non-EC join > quals as well, with some trick along the line of pre-matching non-EC > RestrictInfos to FK items. I'm unsure that that is worth the trouble > though. Afte

Re: [HACKERS] [sqlsmith] Failed assertion in joinrels.c

2016-06-05 Thread Tom Lane
Michael Paquier writes: > Still, on back branches I think that it would be a good idea to have a > better error message for the ones that already throw an error, like > "trigger with OID %u does not exist". Switching from elog to ereport > would be a good idea, but wouldn't it be a problem to chan

[HACKERS] [sqlsmith] Failed assertion in postgres_fdw/deparse.c:1116

2016-06-05 Thread Andreas Seltenreich
Creating some foreign tables via postgres_fdw in the regression db of master as of de33af8, sqlsmith triggers the following assertion: TRAP: FailedAssertion("!(const Node*)(var))->type) == T_Var))", File: "deparse.c", Line: 1116) gdb says var is holding a T_PlaceHolderVar instead. In a

Re: [HACKERS] Statement timeout

2016-06-05 Thread Tatsuo Ishii
>> BTW, aren't you missing a re-enable of the timeout for statements after >> the first one? > > Will check. You are right. Here is the revised patch. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp diff --git a/src

Re: [HACKERS] [sqlsmith] Failed assertion in joinrels.c

2016-06-05 Thread Michael Paquier
On Sun, Jun 5, 2016 at 4:28 PM, Michael Paquier wrote: > On Sun, Jun 5, 2016 at 12:29 AM, Tom Lane wrote: >> Michael Paquier writes: >>> This is still failing: >>> =# select indexdef from pg_catalog.pg_indexes where indexdef is not NULL; >>> ERROR: XX000: cache lookup failed for index 2619 >>>

Re: [HACKERS] [sqlsmith] Failed assertion in joinrels.c

2016-06-05 Thread Michael Paquier
On Sun, Jun 5, 2016 at 12:29 AM, Tom Lane wrote: > Michael Paquier writes: >> This is still failing: >> =# select indexdef from pg_catalog.pg_indexes where indexdef is not NULL; >> ERROR: XX000: cache lookup failed for index 2619 >> LOCATION: pg_get_indexdef_worker, ruleutils.c:1054 >> Do we wa