Re: [HACKERS] dividing money by money

2010-07-17 Thread Andy Balholm
On Jul 17, 2010, at 3:20 AM, Peter Eisentraut wrote: On fre, 2010-07-16 at 10:31 -0400, Tom Lane wrote: The other argument that I found convincing was that if the operator was defined to yield numeric, people might think that the result was exact ... which of course it won't be, either way.

Re: [HACKERS] dividing money by money

2010-07-16 Thread Andy Balholm
On Jul 15, 2010, at 7:25 PM, Tom Lane wrote: * I didn't like this bit in cash_numeric(): result-n_sign_dscale = NUMERIC_SIGN(result) | fpoint; Not only is that unwarranted chumminess with the implementation of numeric, it's flat-out wrong. If the result isn't exactly the right

Re: [HACKERS] dividing money by money

2010-06-21 Thread Andy Balholm
On Jun 21, 2010, at 11:47 AM, Kevin Grittner wrote: Yes, although the line endings are Windows format (CR/LF). The line endings must have gotten changed in transit. My original diff used just LF. I made it on a Mac. The only issue is with the general guideline to make the new code blend

Re: [HACKERS] ANNOUNCE list (was Re: New PGXN Extension site)

2010-06-17 Thread Andy Balholm
Marc Fournier wrote: But, I think you and I are exceptions here, in that we use the web interface for moderation, and not just email ... Is it possible that the ones that use email for moderating the lists have aggressive spam filters? Then they might not receive most of the list postings

Re: [HACKERS] dividing money by money

2010-06-01 Thread Andy Balholm
Thanks for the explanation of CommitFests. On May 30, 2010, at 6:53 AM, Kevin Grittner wrote: You would then generate a diff in context format and post to the -hackers list with that file as an attachment. I made my diff with src/tools/make_diff, as suggested in the Developer FAQ. But

Re: [HACKERS] dividing money by money

2010-05-31 Thread Andy Balholm
On May 30, 2010, at 6:53 AM, Kevin Grittner wrote: You would then generate a diff in context format and post to the -hackers list with that file as an attachment. Here it is: dividing-money.diff Description: Binary data Don't forget to add it to the CommitFest page:

Re: [HACKERS] dividing money by money

2010-05-30 Thread Andy Balholm
On May 30, 2010, at 6:53 AM, Kevin Grittner wrote: You would basically move the functions and their prototypes to cash.c and cash.h, and then (instead of CREATE FUNCTION, etc.) add corresponding entries to pg_proc.h and pg_operator.h. (If I'm missing something, someone please jump in.) Of

Re: [HACKERS] [BUGS] dividing money by money

2010-05-28 Thread Andy Balholm
I'm not quite sure how to go about changing it from an add-on function to a built-in one. So if you want to do that, go ahead. If you'd rather I did, just tell me how it's done. Andy Balholm (509) 276-2065 a...@balholm.com On May 26, 2010, at 11:18 AM, Kevin Grittner wrote: Hi Andy, Do