Re: [HACKERS] [COMMITTERS] pgsql: Improve memory management for external sorts.

2016-03-20 Thread Andres Freund
On 2016-03-18 14:40:33 -0400, Robert Haas wrote: > > Oops. Thanks for the report. Does this fix it? > > Trying again to attach the patch. Yes, that removes the warning, and looks correct. Andres Freund -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] [COMMITTERS] pgsql: Improve memory management for external sorts.

2016-03-19 Thread Robert Haas
On Fri, Mar 18, 2016 at 2:25 PM, Andres Freund wrote: > On 2016-03-17 20:11:00 +, Robert Haas wrote: >> Improve memory management for external sorts. >> >> Introduce a new memory context which stores tuple data, and reset it >> at the end of each merge pass; this helps

Re: [HACKERS] [COMMITTERS] pgsql: Improve memory management for external sorts.

2016-03-19 Thread Peter Geoghegan
On Fri, Mar 18, 2016 at 11:43 AM, Andres Freund wrote: > Yes, that removes the warning, and looks correct. Thanks. We should be careful to not repeat this mistake when the quicksort patch goes in. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list

Re: [HACKERS] [COMMITTERS] pgsql: Improve memory management for external sorts.

2016-03-19 Thread Peter Geoghegan
On Sat, Mar 19, 2016 at 6:38 AM, Robert Haas wrote: > It would be helpful if you could either (a) confirm that that patch > still applies and that it has no issues of this type or (b) post an > updated version. I don't think that it has a problem with lacking the right

Re: [HACKERS] [COMMITTERS] pgsql: Improve memory management for external sorts.

2016-03-19 Thread Robert Haas
On Fri, Mar 18, 2016 at 4:22 PM, Peter Geoghegan wrote: > On Fri, Mar 18, 2016 at 11:43 AM, Andres Freund wrote: >> Yes, that removes the warning, and looks correct. > > Thanks. We should be careful to not repeat this mistake when the > quicksort patch goes

Re: [HACKERS] [COMMITTERS] pgsql: Improve memory management for external sorts.

2016-03-19 Thread Robert Haas
On Fri, Mar 18, 2016 at 2:39 PM, Robert Haas wrote: > On Fri, Mar 18, 2016 at 2:25 PM, Andres Freund wrote: >> On 2016-03-17 20:11:00 +, Robert Haas wrote: >>> Improve memory management for external sorts. >>> >>> Introduce a new memory context