В письме от 3 сентября 2017 11:45:43 пользователь Alvaro Herrera написал:
> > I've just made sure that patch is still applyable to the current master.
> >
> > And I am still waiting for reviews :-)
>
> I see that this patch adds a few tests for reloptions, for instance in
> bloom. I think we sh
Nikolay Shaplov wrote:
> В письме от 25 июня 2017 21:05:49 пользователь Nikolay Shaplov написал:
>
> I've just made sure that patch is still applyable to the current master.
>
> And I am still waiting for reviews :-)
I see that this patch adds a few tests for reloptions, for instance in
bloom.
В письме от 26 марта 2017 15:02:12 пользователь Alvaro Herrera написал:
> Nikolay Shaplov wrote:
> > If I would think about it now: we always know how many options we will
> > have. So we can just pass this number to palloc and assert if somebody
> > adds more options then expected... What do yo th
Nikolay Shaplov wrote:
> В письме от 17 марта 2017 14:21:26 пользователь Alvaro Herrera написал:
>
> > Please make sure to mark functions as static (e.g. bringetreloptcatalog).
> I am a bit confused here:
>
> For brin and nbtree this is a good idea: brin.c and nbtree.c has AM-handler
> inside it
В письме от 17 марта 2017 14:21:26 пользователь Alvaro Herrera написал:
> Please make sure to mark functions as static (e.g. bringetreloptcatalog).
I am a bit confused here:
For brin and nbtree this is a good idea: brin.c and nbtree.c has AM-handler
inside it, and there are other static functio
В письме от 26 марта 2017 15:02:12 Вы написали:
> Nikolay Shaplov wrote:
> > If I would think about it now: we always know how many options we will
> > have. So we can just pass this number to palloc and assert if somebody
> > adds more options then expected... What do yo think about it.
>
> I thi
В письме от 23 марта 2017 16:14:58 пользователь Fabrízio de Royes Mello
написал:
> On Thu, Mar 23, 2017 at 3:58 PM, Alvaro Herrera
>
> wrote:
> > Copying Fabrízio Mello here, who spent some time trying to work on
> > reloptions too. He may have something to say about the new
> > functionality t
Nikolay Shaplov wrote:
> If I would think about it now: we always know how many options we will have.
> So we can just pass this number to palloc and assert if somebody adds more
> options then expected... What do yo think about it.
I think we need to preserve the ability to add custom options,
В письме от 17 марта 2017 14:21:26 пользователь Alvaro Herrera написал:
> I gave this patch a quick skim.
Thanks!
> At first I was confused by the term
> "catalog"; I thought it meant we stored options in a system table. But
> that's not what is meant at all; instead, what we do is build these
>
On Thu, Mar 23, 2017 at 3:58 PM, Alvaro Herrera
wrote:
>
> Copying Fabrízio Mello here, who spent some time trying to work on
> reloptions too. He may have something to say about the new
> functionality that this patch provides.
>
Thanks Álvaro, I'll look the patch and try to help in some way.
Copying Fabrízio Mello here, who spent some time trying to work on
reloptions too. He may have something to say about the new
functionality that this patch provides.
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Service
By the way, it would be very good if you could review some patches, too.
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to
I gave this patch a quick skim. At first I was confused by the term
"catalog"; I thought it meant we stored options in a system table. But
that's not what is meant at all; instead, what we do is build these
"catalogs" in memory. Maybe a different term could have been used, but
I'm not sure it's
13 matches
Mail list logo
