Re: [HACKERS] [PATCH] bitmap indexes

2013-09-26 Thread Antonin Houska
On 09/26/2013 12:20 AM, Alvaro Herrera wrote: This led me to research how these indexes are stored. I note that what we're doing here is to create another regular table and a btree index on top of it, and those are the ones that actually store the index data. This seems grotty and completely

Re: [HACKERS] [PATCH] bitmap indexes

2013-09-26 Thread Abhijit Menon-Sen
At 2013-09-25 19:20:17 -0300, alvhe...@2ndquadrant.com wrote: Here are some quick items while skimming this patch. Great, that gives me plenty to work on. At this point, I think it's appropriate to mark this patch as returned with feedback (which I will do), since the changes needed seem

Re: [HACKERS] [PATCH] bitmap indexes

2013-09-26 Thread Jeff Janes
On Wed, Sep 25, 2013 at 3:20 PM, Alvaro Herrera alvhe...@2ndquadrant.comwrote: Hi, Here are some quick items while skimming this patch. I am looking at commit 6448de29d from your github repo, branch bmi. What's with the pg_bitmapindex stuff in pg_namespace.h? It doesn't seem to be used

Re: [HACKERS] [PATCH] bitmap indexes

2013-09-26 Thread Abhijit Menon-Sen
At 2013-09-26 08:39:05 -0700, jeff.ja...@gmail.com wrote: I don't know about grottiness, but it certainly seems like it would deadlock like crazy. Hi Jeff. I don't understand the deadlock scenario you're thinking of. Could you explain, please? -- Abhijit -- Sent via pgsql-hackers mailing

Re: [HACKERS] [PATCH] bitmap indexes

2013-09-25 Thread Alvaro Herrera
Hi, Here are some quick items while skimming this patch. I am looking at commit 6448de29d from your github repo, branch bmi. What's with the pg_bitmapindex stuff in pg_namespace.h? It doesn't seem to be used anywhere. This led me to research how these indexes are stored. I note that what

Re: [HACKERS] [PATCH] bitmap indexes

2013-09-24 Thread Jeff Janes
On Sat, Sep 14, 2013 at 11:14 AM, Abhijit Menon-Sen a...@2ndquadrant.comwrote: Hi. This is a cleaned-up and rebased version of the bitmap index patch from Gavin Sherry, later revised by Gianni Ciolli and Gabriele Bartolini, and others including Daniel Bausch. I've been working on this

Re: [HACKERS] [PATCH] bitmap indexes

2013-09-24 Thread Abhijit Menon-Sen
At 2013-09-24 09:51:00 -0700, jeff.ja...@gmail.com wrote: I get wrong answers from this index sometimes. Thanks for the report and the test case. I'll investigate. -- Abhijit -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] [PATCH] bitmap indexes

2013-09-15 Thread Jaime Casanova
On Sat, Sep 14, 2013 at 1:14 PM, Abhijit Menon-Sen a...@2ndquadrant.com wrote: Hi. This is a cleaned-up and rebased version of the bitmap index patch from Gavin Sherry, later revised by Gianni Ciolli and Gabriele Bartolini, and others including Daniel Bausch. Hi Abhijit, Please, in the

Re: [HACKERS] [PATCH] bitmap indexes

2013-09-15 Thread Abhijit Menon-Sen
Hi Jaime. At 2013-09-15 23:32:11 -0500, ja...@2ndquadrant.com wrote: bitmapxlog.c:658:32: warning: ‘reln’ may be used uninitialized in this function [-Wuninitialized] I added an XXX comment about this one, will investigate and fix. Will look into the other errors as well, many thanks for the

Re: [HACKERS] [PATCH] bitmap indexes

2013-09-14 Thread Andres Freund
Hi Abhijit, On 2013-09-14 23:44:24 +0530, Abhijit Menon-Sen wrote: I've been working on this patch for a while, and have made some progress towards (a) general fixing, and (b) a working VACUUM implementation (the major remaining piece). Unfortunately, I've been busy moving house, and the