Re: [HACKERS] [patch] Build pgoutput with MSVC

2017-05-05 Thread MauMau
From: Michael Paquier Magnus has already pushed it as 28d1c8c. +if exist src\backend\replication\libpqwalreceiver\win32ver.rc del /q src\backend\replication\pgoutput\win32ver.rc This is not right by the way, you need to check for the existence of the file in pgoutput/, not libpqwalreceiver/.

Re: [HACKERS] [patch] Build pgoutput with MSVC

2017-05-05 Thread Michael Paquier
On Sat, May 6, 2017 at 7:07 AM, MauMau wrote: > From: Magnus Hagander > If that's all that's required, I'll just go ahead and commit it right > away, including the clean.bat. > > I think the problem with clean.bat isn't cleaning up pgoutput.dll -- > that one goes in a

Re: [HACKERS] [patch] Build pgoutput with MSVC

2017-05-05 Thread MauMau
From: Magnus Hagander If that's all that's required, I'll just go ahead and commit it right away, including the clean.bat. I think the problem with clean.bat isn't cleaning up pgoutput.dll -- that one goes in a different directory. But it does need to clean up the win32ver.rc file that gets

Re: [HACKERS] [patch] Build pgoutput with MSVC

2017-05-05 Thread Petr Jelinek
On 05/05/17 12:10, Magnus Hagander wrote: > > On Fri, May 5, 2017 at 11:58 AM, Michael Paquier > > wrote: > > On Fri, May 5, 2017 at 6:10 PM, MauMau > wrote: > > The

Re: [HACKERS] [patch] Build pgoutput with MSVC

2017-05-05 Thread Magnus Hagander
On Fri, May 5, 2017 at 11:58 AM, Michael Paquier wrote: > On Fri, May 5, 2017 at 6:10 PM, MauMau wrote: > > The pgoutput is not built with MSVC. The attached patch fixes this. > > I confirmed that a few INSERTs were replicated correctly. > > > >

Re: [HACKERS] [patch] Build pgoutput with MSVC

2017-05-05 Thread Michael Paquier
On Fri, May 5, 2017 at 6:10 PM, MauMau wrote: > The pgoutput is not built with MSVC. The attached patch fixes this. > I confirmed that a few INSERTs were replicated correctly. > > Should I add this matter in the PostgreSQL 10 Open Items page? Yes, with Peter as committer

[HACKERS] [patch] Build pgoutput with MSVC

2017-05-05 Thread MauMau
Hello, I tried logical replication on Windows, but it failed like this: postgres=# create subscription mysub connection 'host=localhost port=5433 user=tuna dbname=postgres' publication mypub with (nocopy data); NOTICE: synchronized table states ERROR: could not create replication slot