Hi Surafel,
Thank you for your review!
But I have not finish fixing a patch yet.
> v Use tage in documentation
ok.
> v Don’t modified existing test case add new one instead
These existing tests I modified are the results of commands "SELECT
pg_get_triggerdef(oid, true) ... ".
I modified them
Hi Naoki,
On 3/17/17 11:58 AM, Surafel Temesgen wrote:
I am sending the review of this patch
This thread has been idle for a week. Please respond and/or post a new
patch by 2017-03-28 00:00 AoE (UTC-12) or this submission will be marked
"Returned with Feedback".
--
-David
da...@pgmasters
>
>
> I am sending the review of this patch
I found the following
v Use tage in documentation
v Don’t modified existing test case add new one instead
v Comment in pg_constraint.c is extended make it short
v Error message can be more guider if it tells about general rule
v Wrong result i
"Okano, Naoki" writes:
> Peter Eisentraut wrote:
>>> I have a feeling that this was proposed a few times in the ancient past
>>> but did not go through because of locking issues. I can't find any
>>> emails about it through. Does anyone remember? Have you thought about
>>> locking issues?
>>>
Peter Eisentraut wrote:
> On 3/8/17 04:12, Okano, Naoki wrote:
> > Peter Eisentraut wrote:
> >> I have a feeling that this was proposed a few times in the ancient past
> >> but did not go through because of locking issues. I can't find any
> >> emails about it through. Does anyone remember? Have
On 3/8/17 04:12, Okano, Naoki wrote:
> Peter Eisentraut wrote:
>> I have a feeling that this was proposed a few times in the ancient past
>> but did not go through because of locking issues. I can't find any
>> emails about it through. Does anyone remember? Have you thought about
>> locking issu
Peter Eisentraut wrote:
> I have a feeling that this was proposed a few times in the ancient past
> but did not go through because of locking issues. I can't find any
> emails about it through. Does anyone remember? Have you thought about
> locking issues?
Is this e-mail you are finding?
https:/
On 2/7/17 03:11, Okano, Naoki wrote:
> I tried to cretae a patch for CREATE OR REPLACE TRIGGER.
I have a feeling that this was proposed a few times in the ancient past
but did not go through because of locking issues. I can't find any
emails about it through. Does anyone remember? Have you thou
On 11/14/16 8:51 PM, Tom Lane wrote:
1. The impression I have is that most people write trigger functions
so that they can be shared across multiple uses. That'd be impossible
with anonymous trigger function blocks. So you'd be trading off merging
two commands into one, versus having to write o
On Thursday, February 9, 2017 4:41 AM Robert Haas wrote:
> You should add this to the next CommitFest so it doesn't get missed.
>
> https://commitfest.postgresql.org/
Thank you for your kind advice!
I have added this patch to the CommitFest 2017-03.
Regards,
Okano Naoki
Fujitsu
--
Sent via pg
On Tue, Feb 7, 2017 at 3:11 AM, Okano, Naoki wrote:
> On Wednesday, November 16, 2016 4:31 PM Okano Naoki wrote:
>> > But in any case it would be a serious mistake to do this without first
>> > implementing CREATE OR REPLACE TRIGGER. I think that's an entirely
>> > separate
>> > proposal and you
On Wednesday, November 16, 2016 4:31 PM Okano Naoki wrote:
> > But in any case it would be a serious mistake to do this without first
> > implementing CREATE OR REPLACE TRIGGER. I think that's an entirely
> > separate
> > proposal and you would be well advised to treat it as such.
> I see. Ther
> But in any case it would be a serious mistake to do this without first
> implementing CREATE OR REPLACE TRIGGER. I think that's an entirely separate
> proposal and you would be well advised to treat it as such.
I see. There are more problems than I expected...
Let me start with 'OR REPLACE' cl
"Okano, Naoki" writes:
> I would like to add the following support for a trigger.
> This implementation enables to create a trigger efficiently
> in single command.
> It had been discussed before. The link is as shown below.
> https://www.postgresql.org/message-id/CAA-aLv4m%3Df9cc1zcUzM49pE8%2
Hi,
I would like to add the following support for a trigger.
This implementation enables to create a trigger efficiently
in single command.
It had been discussed before. The link is as shown below.
https://www.postgresql.org/message-id/CAA-aLv4m%3Df9cc1zcUzM49pE8%2B2NpytUDraTgfBmkTOkMN_wO2w%4
15 matches
Mail list logo