Re: [HACKERS] Cannot cancel the change of a tablespace

2010-07-01 Thread Guillaume Lelarge
Le 01/07/2010 22:13, Robert Haas a écrit : > On Thu, Jul 1, 2010 at 12:11 PM, Guillaume Lelarge > wrote: >> Le 01/07/2010 17:54, Robert Haas a écrit : >>> On Thu, Jul 1, 2010 at 10:18 AM, Robert Haas wrote: On Thu, Jul 1, 2010 at 5:30 AM, Guillaume Lelarge wrote: On Tue, Jun 2

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-07-01 Thread Robert Haas
On Thu, Jul 1, 2010 at 12:11 PM, Guillaume Lelarge wrote: > Le 01/07/2010 17:54, Robert Haas a écrit : >> On Thu, Jul 1, 2010 at 10:18 AM, Robert Haas wrote: >>> On Thu, Jul 1, 2010 at 5:30 AM, Guillaume Lelarge >>> wrote: >>> On Tue, Jun 29, 2010 at 9:42 PM, Bruce Momjian wrote: S

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-07-01 Thread Guillaume Lelarge
Le 01/07/2010 17:54, Robert Haas a écrit : > On Thu, Jul 1, 2010 at 10:18 AM, Robert Haas wrote: >> On Thu, Jul 1, 2010 at 5:30 AM, Guillaume Lelarge >> wrote: >> On Tue, Jun 29, 2010 at 9:42 PM, Bruce Momjian wrote: >>> So this is not something we want fixed for 9.0, as indicated by Sim

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-07-01 Thread Robert Haas
On Thu, Jul 1, 2010 at 10:18 AM, Robert Haas wrote: > On Thu, Jul 1, 2010 at 5:30 AM, Guillaume Lelarge > wrote: > On Tue, Jun 29, 2010 at 9:42 PM, Bruce Momjian wrote: >> So this is not something we want fixed for 9.0, as indicated by Simon? >> I don't see the patch on the commit-fe

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-07-01 Thread Robert Haas
On Thu, Jul 1, 2010 at 5:30 AM, Guillaume Lelarge wrote: On Tue, Jun 29, 2010 at 9:42 PM, Bruce Momjian wrote: > So this is not something we want fixed for 9.0, as indicated by Simon? > I don't see the patch on the commit-fest page yet. > > Finally, I added it to the next commit fest

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-07-01 Thread Guillaume Lelarge
Le 30/06/2010 06:53, Guillaume Lelarge a écrit : > Le 30/06/2010 05:25, Tom Lane a écrit : >> Robert Haas writes: >>> On Tue, Jun 29, 2010 at 9:42 PM, Bruce Momjian wrote: So this is not something we want fixed for 9.0, as indicated by Simon? I don't see the patch on the commit-fest pag

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-30 Thread Robert Haas
On Tue, Jun 29, 2010 at 11:25 PM, Tom Lane wrote: > Robert Haas writes: >> On Tue, Jun 29, 2010 at 9:42 PM, Bruce Momjian wrote: >>> So this is not something we want fixed for 9.0, as indicated by Simon? >>> I don't see the patch on the commit-fest page yet. > >> I tend to think we should fix it

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-29 Thread Guillaume Lelarge
Le 30/06/2010 05:25, Tom Lane a écrit : > Robert Haas writes: >> On Tue, Jun 29, 2010 at 9:42 PM, Bruce Momjian wrote: >>> So this is not something we want fixed for 9.0, as indicated by Simon? >>> I don't see the patch on the commit-fest page yet. > >> I tend to think we should fix it for 9.0,

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-29 Thread Tom Lane
Robert Haas writes: > On Tue, Jun 29, 2010 at 9:42 PM, Bruce Momjian wrote: >> So this is not something we want fixed for 9.0, as indicated by Simon? >> I don't see the patch on the commit-fest page yet. > I tend to think we should fix it for 9.0, but could be talked out of > it if someone has a

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-29 Thread Robert Haas
On Tue, Jun 29, 2010 at 9:42 PM, Bruce Momjian wrote: > Tom Lane wrote: >> Guillaume Lelarge writes: >> > Still not sure what to do right now for this patch :) >> >> Put it on the commitfest list, if you didn't already. > > So this is not something we want fixed for 9.0, as indicated by Simon? >

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-29 Thread Bruce Momjian
Tom Lane wrote: > Guillaume Lelarge writes: > > Still not sure what to do right now for this patch :) > > Put it on the commitfest list, if you didn't already. So this is not something we want fixed for 9.0, as indicated by Simon? I don't see the patch on the commit-fest page yet. -- Bruce M

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-29 Thread Tom Lane
Guillaume Lelarge writes: > Still not sure what to do right now for this patch :) Put it on the commitfest list, if you didn't already. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://w

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-29 Thread Guillaume Lelarge
Le 23/06/2010 23:29, Guillaume Lelarge a écrit : > Le 23/06/2010 22:54, Tom Lane a écrit : >> Robert Haas writes: >>> On Mon, Jun 21, 2010 at 12:46 PM, Guillaume Lelarge >>> wrote: I added a CHECK_FOR_INTERRUPTS call in the copy_relation_data(), copy_dir(), and copy_file() functions. Wo

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-23 Thread Guillaume Lelarge
Le 23/06/2010 22:54, Tom Lane a écrit : > Robert Haas writes: >> On Mon, Jun 21, 2010 at 12:46 PM, Guillaume Lelarge >> wrote: >>> I added a CHECK_FOR_INTERRUPTS call in the copy_relation_data(), >>> copy_dir(), and copy_file() functions. Works for me on ALTER TABLE ... >>> SET TABLESPACE and ALT

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-23 Thread Tom Lane
Robert Haas writes: > On Mon, Jun 21, 2010 at 12:46 PM, Guillaume Lelarge > wrote: >> I added a CHECK_FOR_INTERRUPTS call in the copy_relation_data(), >> copy_dir(), and copy_file() functions. Works for me on ALTER TABLE ... >> SET TABLESPACE and ALTER DATABASE ... SET TABLESPACE, in 9.0 and 8.4.

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-23 Thread Robert Haas
On Mon, Jun 21, 2010 at 12:46 PM, Guillaume Lelarge wrote: > Today, I tried to cancel the change of a tablespace for a table (ALTER > TABLE ... SET TABLESPACE). I got the "Cancel request sent" but the query > continued and finally succeed. It was a big issue for my customer, and I > wanted to look

Re: [HACKERS] Cannot cancel the change of a tablespace

2010-06-21 Thread Simon Riggs
On Mon, 2010-06-21 at 18:46 +0200, Guillaume Lelarge wrote: > Today, I tried to cancel the change of a tablespace for a table (ALTER > TABLE ... SET TABLESPACE). I got the "Cancel request sent" but the query > continued and finally succeed. It was a big issue for my customer, and I > wanted to loo

[HACKERS] Cannot cancel the change of a tablespace

2010-06-21 Thread Guillaume Lelarge
Hi, Today, I tried to cancel the change of a tablespace for a table (ALTER TABLE ... SET TABLESPACE). I got the "Cancel request sent" but the query continued and finally succeed. It was a big issue for my customer, and I wanted to look more into that issue. So, I got a look at the source code and