Re: [HACKERS] Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)

2015-03-09 Thread Alvaro Herrera
Michael Paquier wrote: On Sun, Mar 1, 2015 at 2:38 AM, Stephen Frost sfr...@snowman.net wrote: I'm going to mark this back to 'waiting on author' in case there's something material that I've missed which you can clarify. I had started this review thinking to help move it along but after

Re: [HACKERS] Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)

2015-03-01 Thread Michael Paquier
On Sun, Mar 1, 2015 at 2:38 AM, Stephen Frost sfr...@snowman.net wrote: I'm going to mark this back to 'waiting on author' in case there's something material that I've missed which you can clarify. I had started this review thinking to help move it along but after re-reading the thread and

Re: [HACKERS] Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)

2015-03-01 Thread Stephen Frost
* Michael Paquier (michael.paqu...@gmail.com) wrote: On Sun, Mar 1, 2015 at 2:38 AM, Stephen Frost sfr...@snowman.net wrote: I'm going to mark this back to 'waiting on author' in case there's something material that I've missed which you can clarify. I had started this review thinking to

Re: [HACKERS] Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)

2015-02-28 Thread Stephen Frost
* Michael Paquier (michael.paqu...@gmail.com) wrote: On Wed, Feb 25, 2015 at 4:27 AM, Peter Eisentraut pete...@gmx.net wrote: On 2/23/15 1:27 AM, Michael Paquier wrote: I would like to have an extension in tree that also does this, so we have a regression test of this functionality.

Re: [HACKERS] Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)

2015-02-25 Thread Jim Nasby
On 2/24/15 1:23 AM, Michael Paquier wrote: On Mon, Feb 23, 2015 at 9:31 PM, Robert Haas robertmh...@gmail.com mailto:robertmh...@gmail.com wrote: On Feb 22, 2015, at 5:41 AM, Michael Paquier michael.paqu...@gmail.com mailto:michael.paqu...@gmail.com wrote: This is up to the

Re: [HACKERS] Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)

2015-02-25 Thread Michael Paquier
On Wed, Feb 25, 2015 at 4:27 AM, Peter Eisentraut pete...@gmx.net wrote: On 2/23/15 1:27 AM, Michael Paquier wrote: I would like to have an extension in tree that also does this, so we have a regression test of this functionality. Sure. Here is one in the patch attached added as a test

Re: [HACKERS] Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)

2015-02-24 Thread Peter Eisentraut
On 2/23/15 1:27 AM, Michael Paquier wrote: I would like to have an extension in tree that also does this, so we have a regression test of this functionality. Sure. Here is one in the patch attached added as a test module. The name of the module is regress_dynamic. Perhaps the name could be

Re: [HACKERS] Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)

2015-02-23 Thread Robert Haas
On Feb 22, 2015, at 5:41 AM, Michael Paquier michael.paqu...@gmail.com wrote: This is up to the maintainer of each extension to manage their code tree. However I can imagine that some people would be grateful if we allow them to not need sql/ and expected/ containing only one single

Re: [HACKERS] Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)

2015-02-22 Thread Michael Paquier
On Sat, Feb 21, 2015 at 6:51 AM, Peter Eisentraut pete...@gmx.net wrote: On 2/20/15 1:56 AM, Michael Paquier wrote: We'd still need the .gitignore files somewhere. Do you want to move them one directory up? I am not sure I am getting what you are pointing to... For extensions that already

Re: [HACKERS] Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)

2015-02-22 Thread Peter Eisentraut
On 2/22/15 5:41 AM, Michael Paquier wrote: You could argue that these .gitignore files don't actually belong there, but your patch doesn't change or move those files, and even modules that have non-empty sql/ or expected/ directories have .gitignore files there, so it is considered the

Re: [HACKERS] Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)

2015-02-22 Thread Michael Paquier
On Mon, Feb 23, 2015 at 12:00 AM, Peter Eisentraut pete...@gmx.net wrote: On 2/22/15 5:41 AM, Michael Paquier wrote: You could argue that these .gitignore files don't actually belong there, but your patch doesn't change or move those files, and even modules that have non-empty sql/ or

Re: [HACKERS] Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)

2015-02-19 Thread Peter Eisentraut
On 1/14/15 11:31 PM, Michael Paquier wrote: pg_regress will fail with test suites using only source files if the destination folders do not exist in the code tree. This is annoying because this forces to maintain empty folders sql/ and expected/ with a .gitignore ignoring everything. We'd

Re: [HACKERS] Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)

2015-02-19 Thread Michael Paquier
On Fri, Feb 20, 2015 at 5:50 AM, Peter Eisentraut pete...@gmx.net wrote: On 1/14/15 11:31 PM, Michael Paquier wrote: pg_regress will fail with test suites using only source files if the destination folders do not exist in the code tree. This is annoying because this forces to maintain empty

[HACKERS] Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)

2015-01-14 Thread Michael Paquier
Hi all, pg_regress will fail with test suites using only source files if the destination folders do not exist in the code tree. This is annoying because this forces to maintain empty folders sql/ and expected/ with a .gitignore ignoring everything. The issue has been discussed here