[HACKERS] Feature freeze and the great elog changeover

2003-06-25 Thread Tom Lane
I had originally planned to spend the next week editing all the elog() calls in the backend to convert them to ereport() format where helpful, add SQLSTATE values, and update wording to match the style guidelines that were agreed to awhile back. However, it looks like the same reasons that were

Re: [HACKERS] Feature freeze and the great elog changeover

2003-06-25 Thread Bruce Momjian
Good idea. This is similar to the pgindent run, though that usually happens just _before_ beta. --- Tom Lane wrote: I had originally planned to spend the next week editing all the elog() calls in the backend to convert

Re: [HACKERS] Feature freeze and the great elog changeover

2003-06-25 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Good idea. This is similar to the pgindent run, though that usually happens just _before_ beta. Right. It still should; I'd recommend we do that after I finish the error message edits. I think at least one person had volunteered to help with the

Re: [HACKERS] Feature freeze and the great elog changeover

2003-06-25 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Good idea. This is similar to the pgindent run, though that usually happens just _before_ beta. Right. It still should; I'd recommend we do that after I finish the error message edits. I think at least one person had volunteered

Re: [HACKERS] Feature freeze and the great elog changeover

2003-06-25 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: I think at least one person had volunteered to help with the editing; that might be a good thing if they're still willing. There's something upwards of 4000 elog calls to be looked at :-( Do we get error numbers with that? :-) That is the point ...

Re: [HACKERS] Feature freeze and the great elog changeover

2003-06-25 Thread Paul Ramsey
Lots of hardcoded english... is i8n something which gets raised often, or is it lingue franca enough that people don't care? (Since all the messages are going to be looked at anyways...) Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: I think at least one person had volunteered to help

Re: [HACKERS] Feature freeze and the great elog changeover

2003-06-25 Thread Tom Lane
Paul Ramsey [EMAIL PROTECTED] writes: Lots of hardcoded english... What makes you think it's hardcoded? We've had internationalization support for awhile. (One of the results I'd like to accomplish in this pass is to reduce the number of junk messages that translators need to look at, by

Re: [HACKERS] Feature freeze and the great elog changeover

2003-06-25 Thread Paul Ramsey
Tom Lane wrote: Paul Ramsey [EMAIL PROTECTED] writes: Lots of hardcoded english... What makes you think it's hardcoded? We've had internationalization support for awhile. (One of the results I'd like to accomplish in this pass is to reduce the number of junk messages that translators need to

Re: [HACKERS] Feature freeze and the great elog changeover

2003-06-25 Thread Tom Lane
Paul Ramsey [EMAIL PROTECTED] writes: I am probably just misunderstanding something. See http://candle.pha.pa.us/main/writings/pgsql/sgml/nls.html regards, tom lane ---(end of broadcast)--- TIP 4: Don't 'kill -9' the

Re: [HACKERS] Feature freeze and the great elog changeover

2003-06-25 Thread Dennis Björklund
On Wed, 25 Jun 2003, Paul Ramsey wrote: Ignorance on my part, probably. You mentioned elog() so I grepped for it and found lots of this stuff: elog(FATAL, data directory %s was not found, checkdir) elog(FATAL, could not read permissions of directory %s: %m, checkdir); I

Re: [HACKERS] Feature freeze and the great elog changeover

2003-06-25 Thread The Hermit Hacker
On Wed, 25 Jun 2003, Tom Lane wrote: I had originally planned to spend the next week editing all the elog() calls in the backend to convert them to ereport() format where helpful, add SQLSTATE values, and update wording to match the style guidelines that were agreed to awhile back. However,