Re: [HACKERS] Incorrectly reporting config errors

2014-01-22 Thread Kevin Grittner
Tom Lane wrote: > Kevin Grittner writes: >> My preference would be to not generate noise for interim states; >> just report net changes. > > Yeah.  Is it worth explicitly detecting and dropping redundant assignments > to the same variable?  A naive check for that would be O(N^2) in the > number o

Re: [HACKERS] Incorrectly reporting config errors

2014-01-22 Thread Tom Lane
Kevin Grittner writes: > My preference would be to not generate noise for interim states; > just report net changes. Yeah. Is it worth explicitly detecting and dropping redundant assignments to the same variable? A naive check for that would be O(N^2) in the number of entries in the conf file,

Re: [HACKERS] Incorrectly reporting config errors

2014-01-22 Thread Andres Freund
On 2014-01-22 12:10:30 -0500, Tom Lane wrote: > Kevin Grittner writes: > > My preference would be to not generate noise for interim states; > > just report net changes. > > Yeah. Is it worth explicitly detecting and dropping redundant assignments > to the same variable? A naive check for that w

Re: [HACKERS] Incorrectly reporting config errors

2014-01-22 Thread Kevin Grittner
Andres Freund wrote: > A rather common and sensible configuration is to have a common > configuration file used across servers, which then is overwritten > by a per-server or per-cluster config file containing values > specific to a server/cluster. Agreed. My preference would be to not generate

Re: [HACKERS] Incorrectly reporting config errors

2014-01-21 Thread Andres Freund
On 2014-01-21 16:13:11 -0500, Robert Haas wrote: > On Tue, Jan 21, 2014 at 3:37 PM, Tom Lane wrote: > > Robert Haas writes: > >> I kind of agree with Thom. I understand why it's doing what it's > >> doing, but it still seems sort of lame. > > > > Well, the point of the message is to report that

Re: [HACKERS] Incorrectly reporting config errors

2014-01-21 Thread Adrian Klaver
On 01/21/2014 12:29 PM, Robert Haas wrote: On Tue, Jan 21, 2014 at 1:59 PM, Thom Brown wrote: On 21 January 2014 18:35, Tom Lane wrote: Thom Brown writes: I'm getting a report of a config error when changing a config value that requires a restart: ... 2014-01-21 18:14:53 GMT [28718]: [4-1]

Re: [HACKERS] Incorrectly reporting config errors

2014-01-21 Thread Tom Lane
Robert Haas writes: > The only real argument for the message: > LOG: configuration file "/home/thom/Development/data/postgresql.conf" > contains errors; unaffected changes were applied > ...is that somebody might think that the presence of a single error > caused all the changes to be ignored.

Re: [HACKERS] Incorrectly reporting config errors

2014-01-21 Thread Robert Haas
On Tue, Jan 21, 2014 at 3:37 PM, Tom Lane wrote: > Robert Haas writes: >> I kind of agree with Thom. I understand why it's doing what it's >> doing, but it still seems sort of lame. > > Well, the point of the message is to report that we failed to apply > all the settings requested by the file.

Re: [HACKERS] Incorrectly reporting config errors

2014-01-21 Thread Tom Lane
Robert Haas writes: > I kind of agree with Thom. I understand why it's doing what it's > doing, but it still seems sort of lame. Well, the point of the message is to report that we failed to apply all the settings requested by the file. If you prefer some wording squishier than "error", we coul

Re: [HACKERS] Incorrectly reporting config errors

2014-01-21 Thread Robert Haas
On Tue, Jan 21, 2014 at 1:59 PM, Thom Brown wrote: > On 21 January 2014 18:35, Tom Lane wrote: >> Thom Brown writes: >>> I'm getting a report of a config error when changing a config value >>> that requires a restart: >>> ... >>> 2014-01-21 18:14:53 GMT [28718]: [4-1] user=,db=,client= LOG: >>>

Re: [HACKERS] Incorrectly reporting config errors

2014-01-21 Thread Thom Brown
On 21 January 2014 18:35, Tom Lane wrote: > Thom Brown writes: >> I'm getting a report of a config error when changing a config value >> that requires a restart: >> ... >> 2014-01-21 18:14:53 GMT [28718]: [4-1] user=,db=,client= LOG: >> received SIGHUP, reloading configuration files >> 2014-01-21

Re: [HACKERS] Incorrectly reporting config errors

2014-01-21 Thread Adrian Klaver
On 01/21/2014 10:26 AM, Thom Brown wrote: Hi all, I'm getting a report of a config error when changing a config value that requires a restart: In postgresql.conf max_connections = 92 (pg_ctl restart) postgres=# show max_connections ; max_connections - 92 (1 row) (Edit

Re: [HACKERS] Incorrectly reporting config errors

2014-01-21 Thread Tom Lane
Thom Brown writes: > I'm getting a report of a config error when changing a config value > that requires a restart: > ... > 2014-01-21 18:14:53 GMT [28718]: [4-1] user=,db=,client= LOG: > received SIGHUP, reloading configuration files > 2014-01-21 18:14:53 GMT [28718]: [5-1] user=,db=,client= LOG:

[HACKERS] Incorrectly reporting config errors

2014-01-21 Thread Thom Brown
Hi all, I'm getting a report of a config error when changing a config value that requires a restart: In postgresql.conf max_connections = 92 (pg_ctl restart) postgres=# show max_connections ; max_connections - 92 (1 row) (Edit postgresql.conf so that max_connections = 93)