Re: [HACKERS] Patch: add --if-exists to pg_recvlogical

2017-11-01 Thread Catalin Iacob
On Fri, Sep 29, 2017 at 3:06 PM, Peter Eisentraut wrote: > On 9/22/17 15:31, Peter Eisentraut wrote: >> I suggest you create a patch that focuses on the --create part. >> >> You can create a separate follow-on patch for the --start part if you >> wish, but I

Re: [HACKERS] Patch: add --if-exists to pg_recvlogical

2017-09-29 Thread Peter Eisentraut
On 9/22/17 15:31, Peter Eisentraut wrote: > I suggest you create a patch that focuses on the --create part. > > You can create a separate follow-on patch for the --start part if you > wish, but I think that that patch would be rejected. I have moved this entry to the next commit fest, awaiting

Re: [HACKERS] Patch: add --if-exists to pg_recvlogical

2017-09-22 Thread Peter Eisentraut
On 9/20/17 02:26, Rosser Schwarz wrote: > The more I think about it, I don't think it's nonsensical, though. > --create-slot --if-exists or --drop-slot --if-not-exists, obviously. I > mean, do you even logic? Those pieces make sense. We have many CREATE IF NOT EXISTS and DROP IF EXISTS commands.

Re: [HACKERS] Patch: add --if-exists to pg_recvlogical

2017-09-20 Thread Rosser Schwarz
On Tue, Sep 19, 2017 at 1:12 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 9/17/17 18:21, Rosser Schwarz wrote: > > On Fri, Sep 1, 2017 at 10:22 AM, Peter Eisentraut > > > > wrote: > >> I

Re: [HACKERS] Patch: add --if-exists to pg_recvlogical

2017-09-19 Thread Peter Eisentraut
On 9/17/17 18:21, Rosser Schwarz wrote: > On Fri, Sep 1, 2017 at 10:22 AM, Peter Eisentraut > > wrote: >> I understand the --drop-slot part.  But I don't understand what it means >> to ignore a missing replication slot

Re: [HACKERS] Patch: add --if-exists to pg_recvlogical

2017-09-17 Thread Rosser Schwarz
On Fri, Sep 1, 2017 at 10:22 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > I understand the --drop-slot part. But I don't understand what it means > to ignore a missing replication slot when running --start. I'm not sure I do either, honestly. I followed the Principle of

Re: [HACKERS] Patch: add --if-exists to pg_recvlogical

2017-09-15 Thread Peter Eisentraut
On 9/15/17 13:18, Rosser Schwarz wrote: > On Fri, Sep 15, 2017 at 04:15 Daniel Gustafsson > wrote: > > This patch is "Waiting for Author” due to the above review comments > from Peter > and Thomas.  Do you think you will have time to address

Re: [HACKERS] Patch: add --if-exists to pg_recvlogical

2017-09-15 Thread Rosser Schwarz
On Fri, Sep 15, 2017 at 04:15 Daniel Gustafsson wrote: > This patch is "Waiting for Author” due to the above review comments from > Peter > and Thomas. Do you think you will have time to address these shortly so > we can > move this patch further in the process? I have a

Re: [HACKERS] Patch: add --if-exists to pg_recvlogical

2017-09-15 Thread Daniel Gustafsson
> On 09 Sep 2017, at 06:05, Thomas Munro wrote: > > On Sat, Sep 2, 2017 at 5:22 AM, Peter Eisentraut > wrote: >> >> + --if-exists >> + >> + >> +Do not error out when --drop-slot or >> --start are >>

Re: [HACKERS] Patch: add --if-exists to pg_recvlogical

2017-09-08 Thread Thomas Munro
On Sat, Sep 2, 2017 at 5:22 AM, Peter Eisentraut wrote: > > + --if-exists > + > + > +Do not error out when --drop-slot or > --start are > +specified and a slot with the specified name does not exist. > + > + >

Re: [HACKERS] Patch: add --if-exists to pg_recvlogical

2017-09-01 Thread Peter Eisentraut
On 8/26/17 15:40, Rosser Schwarz wrote: > On Fri, Aug 25, 2017 at 12:34 PM, Robert Haas > wrote: > > On Sun, May 21, 2017 at 3:04 PM, Rosser Schwarz > > wrote: > > While

Re: [HACKERS] Patch: add --if-exists to pg_recvlogical

2017-08-26 Thread Rosser Schwarz
On Fri, Aug 25, 2017 at 12:34 PM, Robert Haas wrote: > On Sun, May 21, 2017 at 3:04 PM, Rosser Schwarz > wrote: > > While doing some scripting around pg_recvlogical at $work, I found a need > > for $subject. Attached, find a patch to that

Re: [HACKERS] Patch: add --if-exists to pg_recvlogical

2017-08-25 Thread Robert Haas
On Sun, May 21, 2017 at 3:04 PM, Rosser Schwarz wrote: > While doing some scripting around pg_recvlogical at $work, I found a need > for $subject. Attached, find a patch to that effect. > > I tried simply to mirror the logic used elsewhere. I don't think there's >

[HACKERS] Patch: add --if-exists to pg_recvlogical

2017-05-21 Thread Rosser Schwarz
Hackers, While doing some scripting around pg_recvlogical at $work, I found a need for $subject. Attached, find a patch to that effect. I tried simply to mirror the logic used elsewhere. I don't think there's anything controversial here, but welcome any comments or suggestions. This applies and