On tis, 2011-02-08 at 02:05 -0800, Ibrar Ahmed wrote:
> I have modified the code to use ADD_STARTUP_OPTION instead of writing code
> again.
Committed this version.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.o
On Fri, Feb 11, 2011 at 10:45 AM, Stephen Frost wrote:
> * Robert Haas (robertmh...@gmail.com) wrote:
>> On Tue, Feb 8, 2011 at 5:05 AM, Ibrar Ahmed wrote:
>> > And tried the patch on Windows and Linux and it works for me.
>>
>> Does this need more review, or should it be marked "Ready for Comm
* Robert Haas (robertmh...@gmail.com) wrote:
> On Tue, Feb 8, 2011 at 5:05 AM, Ibrar Ahmed wrote:
> > And tried the patch on Windows and Linux and it works for me.
>
> Does this need more review, or should it be marked "Ready for Committer"?
I think it can be marked ready for committer. Heikk
On Tue, Feb 8, 2011 at 5:05 AM, Ibrar Ahmed wrote:
> Stephen Frost!
> I have modified the code to use ADD_STARTUP_OPTION instead of writing code
> again.
> And tried the patch on Windows and Linux and it works for me.
Does this need more review, or should it be marked "Ready for Committer"?
--
Stephen Frost!
I have modified the code to use ADD_STARTUP_OPTION instead of writing code
again.
And tried the patch on Windows and Linux and it works for me.
On Sun, Feb 6, 2011 at 10:19 AM, Stephen Frost wrote:
> Ibrar,
>
> * Ibrar Ahmed (ibrar.ah...@gmail.com) wrote:
> > I have reviewed
Ibrar,
* Ibrar Ahmed (ibrar.ah...@gmail.com) wrote:
> I have reviewed/tested this patch.
Great, thanks for that!
> In my point code should be like this
>
> *if (conn->client_encoding_initial && conn->client_encoding_initial[0])
>{
>if (packet)
>{
>
On Wed, Feb 2, 2011 at 5:22 AM, Ibrar Ahmed wrote:
> Hi!,
>
> I have reviewed/tested this patch.
>
> OS = "Linux ubuntu 2.6.35-22-generic #33-Ubuntu SMP Sun Sep 19 20:34:50 UTC
> 2010 i686 GNU/Linux"
> PostgreSQL Version = Head (9.1devel)
>
> Patch gives the desired results(still testing), but co
Hi!,
I have reviewed/tested this patch.
OS = "Linux ubuntu 2.6.35-22-generic #33-Ubuntu SMP Sun Sep 19 20:34:50 UTC
2010 i686 GNU/Linux"
PostgreSQL Version = Head (9.1devel)
Patch gives the desired results(still testing), but couple of questions with
this portion of the code.
*
if (conn->
On 29.01.2011 19:23, Peter Eisentraut wrote:
> Also, do we really need a new set of states for this..? I would have
> thought, just reading through the patch, that we could use the existing
> OPTION_SEND/OPTION_WAIT states..
Don't know. Maybe Heikki could comment; he wrote that initially.
On lör, 2011-01-29 at 11:50 -0500, Stephen Frost wrote:
> Greetings,
>
> * Peter Eisentraut (pete...@gmx.net) wrote:
> > I have adjusted your old patch for the current tree, and it seems to
> > work. I think it was just forgotten last time because the move to
> > PQconnectdbParams had to happen f
Greetings,
* Peter Eisentraut (pete...@gmx.net) wrote:
> I have adjusted your old patch for the current tree, and it seems to
> work. I think it was just forgotten last time because the move to
> PQconnectdbParams had to happen first. But I'll throw it back into the
> ring now.
Right off the ba
11 matches
Mail list logo
