On 10/05/2011 03:58 AM, Amit Khandekar wrote:
On 5 October 2011 12:29, Alex Hunsakerbada...@gmail.com wrote:
Find it attached. [ Note I didn't put the check inside the if (ret ==
utf8_str) as it seemed a bit cleaner (indentation wise) to have it
outside ]
I have no more issues with the
On 10/07/2011 12:51 PM, Alex Hunsaker wrote:
On Wed, Oct 5, 2011 at 20:36, Robert Haasrobertmh...@gmail.com wrote:
On Wed, Oct 5, 2011 at 5:03 PM, Alex Hunsakerbada...@gmail.com wrote:
On Wed, Oct 5, 2011 at 08:18, Robert Haasrobertmh...@gmail.com wrote:
On Wed, Oct 5, 2011 at 3:58 AM,
On Wed, Nov 2, 2011 at 17:12, Andrew Dunstan and...@dunslane.net wrote:
Considering that the issue appears to have been ignored from
mid-February until early October, I don't see why it should now get to
jump to the head of the queue. Other people may have different
opinions, of course.
On Wed, Oct 5, 2011 at 20:36, Robert Haas robertmh...@gmail.com wrote:
On Wed, Oct 5, 2011 at 5:03 PM, Alex Hunsaker bada...@gmail.com wrote:
On Wed, Oct 5, 2011 at 08:18, Robert Haas robertmh...@gmail.com wrote:
On Wed, Oct 5, 2011 at 3:58 AM, Amit Khandekar
amit.khande...@enterprisedb.com
On Tue, Oct 4, 2011 at 23:46, Amit Khandekar
amit.khande...@enterprisedb.com wrote:
On 4 October 2011 22:57, Alex Hunsaker bada...@gmail.com wrote:
On Tue, Oct 4, 2011 at 03:09, Amit Khandekar
amit.khande...@enterprisedb.com wrote:
On 4 October 2011 14:04, Alex Hunsaker bada...@gmail.com
On Wed, Oct 5, 2011 at 00:30, Alex Hunsaker bada...@gmail.com wrote:
On Tue, Oct 4, 2011 at 23:46, Amit Khandekar
amit.khande...@enterprisedb.com wrote:
You mean the final changes in plperl_helpers.h would look like
something like this right? :
static inline char *
utf_u2e(const char
On 5 October 2011 12:29, Alex Hunsaker bada...@gmail.com wrote:
On Wed, Oct 5, 2011 at 00:30, Alex Hunsaker bada...@gmail.com wrote:
On Tue, Oct 4, 2011 at 23:46, Amit Khandekar
amit.khande...@enterprisedb.com wrote:
You mean the final changes in plperl_helpers.h would look like
something
On Wed, Oct 5, 2011 at 3:58 AM, Amit Khandekar
amit.khande...@enterprisedb.com wrote:
I have no more issues with the patch.
Thanks!
I think this patch needs to be added to the open CommitFest, with
links to the reviews, and marked Ready for Committer.
--
Robert Haas
EnterpriseDB:
On Wed, Oct 5, 2011 at 08:18, Robert Haas robertmh...@gmail.com wrote:
On Wed, Oct 5, 2011 at 3:58 AM, Amit Khandekar
amit.khande...@enterprisedb.com wrote:
I have no more issues with the patch.
Thanks!
I think this patch needs to be added to the open CommitFest, with
links to the reviews,
On Wed, Oct 5, 2011 at 5:03 PM, Alex Hunsaker bada...@gmail.com wrote:
On Wed, Oct 5, 2011 at 08:18, Robert Haas robertmh...@gmail.com wrote:
On Wed, Oct 5, 2011 at 3:58 AM, Amit Khandekar
amit.khande...@enterprisedb.com wrote:
I have no more issues with the patch.
Thanks!
I think this
On 04.10.2011 08:35, Amit Khandekar wrote:
On 3 October 2011 22:37, Alex Hunsakerbada...@gmail.com wrote:
It might be worth adding a regression test also...
I could not find any basic pl/perl tests in the regression
serial_schedule. I am not sure if we want to add just this scenario
without
On Mon, Oct 3, 2011 at 23:35, Amit Khandekar
amit.khande...@enterprisedb.com wrote:
WHen GetDatabaseEncoding() != PG_UTF8 case, ret will not be equal to
utf8_str, so pg_verify_mbstr_len() will not get called. That's the
reason, pg_verify_mbstr_len() is under the ( ret == utf8_str )
condition.
On 4 October 2011 14:04, Alex Hunsaker bada...@gmail.com wrote:
On Mon, Oct 3, 2011 at 23:35, Amit Khandekar
amit.khande...@enterprisedb.com wrote:
WHen GetDatabaseEncoding() != PG_UTF8 case, ret will not be equal to
utf8_str, so pg_verify_mbstr_len() will not get called. That's the
reason,
On Tue, Oct 4, 2011 at 03:09, Amit Khandekar
amit.khande...@enterprisedb.com wrote:
On 4 October 2011 14:04, Alex Hunsaker bada...@gmail.com wrote:
On Mon, Oct 3, 2011 at 23:35, Amit Khandekar
amit.khande...@enterprisedb.com wrote:
WHen GetDatabaseEncoding() != PG_UTF8 case, ret will not be
On 4 October 2011 22:57, Alex Hunsaker bada...@gmail.com wrote:
On Tue, Oct 4, 2011 at 03:09, Amit Khandekar
amit.khande...@enterprisedb.com wrote:
On 4 October 2011 14:04, Alex Hunsaker bada...@gmail.com wrote:
On Mon, Oct 3, 2011 at 23:35, Amit Khandekar
amit.khande...@enterprisedb.com
On 12 February 2011 14:48, Alex Hunsaker bada...@gmail.com wrote:
On Sun, Feb 6, 2011 at 15:31, Andrew Dunstan and...@dunslane.net wrote:
Force strings passed to and from plperl to be in UTF8 encoding.
String are converted to UTF8 on the way into perl and to the
database encoding on the way
On Mon, Oct 3, 2011 at 04:20, Amit Khandekar
amit.khande...@enterprisedb.com wrote:
Is there a plan to commit this issue? I am still seeing this issue on
PG 9.1 STABLE branch. Attached is a small patch that targets only the
specific issue in the described testcase :
create or replace
On 3 October 2011 22:37, Alex Hunsaker bada...@gmail.com wrote:
On Mon, Oct 3, 2011 at 04:20, Amit Khandekar
amit.khande...@enterprisedb.com wrote:
Is there a plan to commit this issue? I am still seeing this issue on
PG 9.1 STABLE branch. Attached is a small patch that targets only the
On Sun, Feb 6, 2011 at 15:31, Andrew Dunstan and...@dunslane.net wrote:
Force strings passed to and from plperl to be in UTF8 encoding.
String are converted to UTF8 on the way into perl and to the
database encoding on the way back. This avoids a number of
observed anomalies, and ensures Perl
On 02/06/2011 05:31 PM, Andrew Dunstan wrote:
Force strings passed to and from plperl to be in UTF8 encoding.
String are converted to UTF8 on the way into perl and to the
database encoding on the way back. This avoids a number of
observed anomalies, and ensures Perl a consistent view of
On Sun, Feb 6, 2011 at 18:02, Andrew Dunstan and...@dunslane.net wrote:
On 02/06/2011 05:31 PM, Andrew Dunstan wrote:
Force strings passed to and from plperl to be in UTF8 encoding.
String are converted to UTF8 on the way into perl and to the
database encoding on the way back. This
On 02/06/2011 09:13 PM, Alex Hunsaker wrote:
I would have loved to add some regression
tests for some of this (like the example hek2cstr states). Is there
any way to do that?
I can't think of an obvious way. Anyone else?
cheers
ndrew
--
Sent via pgsql-hackers mailing list
22 matches
Mail list logo
