Robert Haas writes:
> Yeah, random() is the wrong thing. It should use PostmasterRandom().
> Fixed to do that instead.
I am not very happy about this patch; have you considered the security
implications of what you just did? If you haven't, I'll tell you:
you just made
On Thu, Oct 15, 2015 at 11:32 PM, Amit Kapila wrote:
> On Thu, Oct 15, 2015 at 8:35 PM, Dmitry Vasilyev
> wrote:
>>
>> I think that function dsm_impl_windows() with EACCES error should not
>> do ereport() with FATAL level. It works, but it is
On Sat, Oct 17, 2015 at 12:07 AM, Robert Haas wrote:
>
> On Thu, Oct 15, 2015 at 11:32 PM, Amit Kapila
wrote:
> > Another some what related point is currently we are using random()
> > function to ensure a unique name for dsm and it seems to me
Amit Kapila writes:
> On Sat, Oct 17, 2015 at 12:07 AM, Robert Haas wrote:
>> Maybe we need to be using PostmasterRandom() rather than random() for
>> the control segment name.
> +1. Though I think it is better to investigate the actual cause
On Thu, Oct 15, 2015 at 11:32 PM, Amit Kapila wrote:
> Another some what related point is currently we are using random()
> function to ensure a unique name for dsm and it seems to me that
> it is always going to generate same number on first invocation (at least
> thats
On Fri, Oct 16, 2015 at 12:16 PM, Kyotaro HORIGUCHI <
horiguchi.kyot...@lab.ntt.co.jp> wrote:
> This is wrong, current code does well for this case. I should
> broke the code during investigating the problem.
>
> > > So, to make the windows version behave as the same,
> > > dsm_impl_windows should